From ac49000738e63a46185b803e56d087b16a67f60d Mon Sep 17 00:00:00 2001
From: cliffhall <cliff@futurescale.com>
Date: Sat, 11 Jul 2026 23:23:19 -0400
Subject: [PATCH] =?UTF-8?q?cli:=20address=20#1672=20review=20nits=20?=
 =?UTF-8?q?=E2=80=94=20correct=20doc=20ref=20+=20hoist=20normalizeServerUr?=
 =?UTF-8?q?l?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- The JSDoc referenced a non-existent `resolveServerConfig`; name the real
  `resolveServerConfigs` (core/mcp/node/config.ts) in plain text (it isn't
  imported here, so an @link wouldn't resolve).
- Hoist the doubly-computed `normalizeServerUrl(serverUrl)` in buildHandoff to
  a single `normalizedUrl` reused for the query param and the serverUrl field.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BrihGWcrM9JGRyu41nzZYw
---
 clients/cli/src/cli.ts | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/clients/cli/src/cli.ts b/clients/cli/src/cli.ts
index c4ac4e7a..cfdc2c3c 100644
--- a/clients/cli/src/cli.ts
+++ b/clients/cli/src/cli.ts
@@ -541,7 +541,8 @@ async function waitForStoredToken(
 
 /**
  * Derive the web deep-link `transport` value (`http` | `sse`) for a handoff.
- * Mirrors {@link resolveServerConfig}'s URL-path auto-detection (`/sse` → sse,
+ * Mirrors `resolveServerConfigs` (core/mcp/node/config.ts) URL-path
+ * auto-detection (`/sse` → sse,
  * everything else → http) but, unlike that resolver, defaults to `http` instead
  * of throwing on an ambiguous path — the handoff is best-effort, and the web
  * {@link parseDeepLink} likewise defaults an unknown/missing transport to http.
@@ -583,18 +584,19 @@ function buildHandoff(
   // Treat an empty MCP_INSPECTOR_API_TOKEN the same as unset — an empty token
   // can't satisfy the deep-link autoConnect gate.
   const apiToken = process.env.MCP_INSPECTOR_API_TOKEN || undefined;
+  const normalizedUrl = normalizeServerUrl(serverUrl);
   // Canonical #1576 deep-link shape: the normalized serverUrl (matching the
   // OAuth-store key form the web app reuses) plus the resolved transport, gated
   // by `autoConnect=<token>` — the same per-launch token the web parser
   // requires. Omitted when no token is set; the `note` below flags that the
   // link will be rejected until the web inspector is launched with a token.
   const params = new URLSearchParams({
-    serverUrl: normalizeServerUrl(serverUrl),
+    serverUrl: normalizedUrl,
     transport: deepLinkTransport(serverUrl, transport),
   });
   if (apiToken) params.set("autoConnect", apiToken);
   return {
-    serverUrl: normalizeServerUrl(serverUrl),
+    serverUrl: normalizedUrl,
     deepLink: `http://${host}:${clientPort}/?${params.toString()}`,
     portForwardCmd: `coder port-forward <workspace> --tcp ${clientPort}:${clientPort} --tcp ${sandboxPort}:${sandboxPort}`,
     oauthStatePath: statePath,