modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

docs: address Copilot review round 1 (#1745)

Browse source 
- requestAppElicitation.ts, appElicitation.ts, docs/test-servers.md:
  ext-apps 2.0.0 does not "predate" #733 (the PR is from July; the
  release from September) — it simply does not include it. Reworded as
  omission, and the version the appElicitation.ts JSDoc names is now
  2.0.0 rather than 1.7.5.
- core/mcp/types.ts: the public `AppRendererClient` JSDoc described the
  app-renderer proxy; it is the real SDK `Client`, handed out only while
  connected, since #1745 removed the proxy.
- appCapabilities.test.ts: the two comments verified against 1.7.5 now
  cite 2.0.0, which the test runs against.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsmUAZ6aLUAFqenjJKSSRp
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-13 19:42:48 -04:00
commit b0391561a1
2 changed files with 16 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
core/mcp/appElicitation.ts
View file

@ -21,8 +21,9 @@ import { MCP_APP_MIME_TYPE, UI_EXTENSION_KEY } from "./extensions.js";
*
* The helpers here mirror the ext-apps draft (modelcontextprotocol/ext-apps#733,
* SEP-3118) so the Inspector speaks exactly the proposed protocol. They are
* declared locally only because the released `@modelcontextprotocol/ext-apps`
* (1.7.5) predates that PR and exports none of them; replace
* declared locally only because #733 is not yet in a published release — the
* installed `@modelcontextprotocol/ext-apps` (2.0.0) does not include it and
* exports none of them; replace
* {@link supportsAppElicitation} / {@link getElicitationUiResourceUri} with the
* package's `/server` exports once a release containing #733 ships.
*/

10
core/mcp/types.ts
View file

@ -1023,9 +1023,13 @@ export type CreateTransport = (
) => CreateTransportResult;
/**
* Type for the client-like object passed to AppRenderer / @mcp-ui.
* Structurally compatible with the MCP SDK Client but denotes the app-renderer
* proxy, not the raw client. Use this type when passing the client to the Apps tab.
* The SDK `Client` handed to the MCP Apps host bridge (`AppBridge` in
* `@modelcontextprotocol/ext-apps`), obtained through
* `InspectorClient.getAppRendererClient()`, which returns it only while the
* connection status is `connected` and `null` otherwise. It is the real client,
* not a wrapper: since ext-apps 2.0.0 peers on SDK v2 the bridge registers on
* it directly, and the v1-peer translation proxy this alias used to denote is
* gone (#1745). Use this type when passing the client to the Apps tab.
*/
export type AppRendererClient = Client;