modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Remove transport/serverUrl parsing from start.js

Browse source 
Move transport configuration parsing to cli.js as suggested in PR review. The CLI entry point (cli.js) should handle config file parsing and pass parameters to start.js.
This commit is contained in:
Felix Weinberger 2025-08-05 13:30:16 +01:00
commit b6dc2ceeb9
No known key found for this signature in database
1 changed files with 0 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

24
client/bin/start.js
View file

@ -18,8 +18,6 @@ function getClientUrl(
authDisabled, authDisabled,
sessionToken, sessionToken,
serverPort, serverPort,
transport,
serverUrl,
) { ) {
const host = process.env.HOST || "localhost"; const host = process.env.HOST || "localhost";
const baseUrl = `http://${host}:${port}`; const baseUrl = `http://${host}:${port}`;
@ -31,12 +29,6 @@ function getClientUrl(
if (!authDisabled) { if (!authDisabled) {
params.set("MCP_PROXY_AUTH_TOKEN", sessionToken); params.set("MCP_PROXY_AUTH_TOKEN", sessionToken);
} }
if (transport) {
params.set("transport", transport);
}
if (serverUrl) {
params.set("serverUrl", serverUrl);
}
return params.size > 0 ? `${baseUrl}/?${params.toString()}` : baseUrl; return params.size > 0 ? `${baseUrl}/?${params.toString()}` : baseUrl;
} }
@ -136,8 +128,6 @@ async function startDevClient(clientOptions) {
sessionToken, sessionToken,
abort, abort,
cancelled, cancelled,
transport,
serverUrl,
} = clientOptions; } = clientOptions;
const clientCommand = "npx"; const clientCommand = "npx";
const host = process.env.HOST || "localhost"; const host = process.env.HOST || "localhost";
@ -155,8 +145,6 @@ async function startDevClient(clientOptions) {
authDisabled, authDisabled,
sessionToken, sessionToken,
SERVER_PORT, SERVER_PORT,
transport,
serverUrl,
); );
// Give vite time to start before opening or logging the URL // Give vite time to start before opening or logging the URL
@ -190,8 +178,6 @@ async function startProdClient(clientOptions) {
sessionToken, sessionToken,
abort, abort,
cancelled, cancelled,
transport,
serverUrl,
} = clientOptions; } = clientOptions;
const inspectorClientPath = resolve( const inspectorClientPath = resolve(
__dirname, __dirname,
@ -206,8 +192,6 @@ async function startProdClient(clientOptions) {
authDisabled, authDisabled,
sessionToken, sessionToken,
SERVER_PORT, SERVER_PORT,
transport,
serverUrl,
); );
await spawnPromise("node", [inspectorClientPath], { await spawnPromise("node", [inspectorClientPath], {
@ -229,8 +213,6 @@ async function main() {
let command = null; let command = null;
let parsingFlags = true; let parsingFlags = true;
let isDev = false; let isDev = false;
let transport = null;
let serverUrl = null;
for (let i = 0; i < args.length; i++) { for (let i = 0; i < args.length; i++) {
const arg = args[i]; const arg = args[i];
@ -256,10 +238,6 @@ async function main() {
} else { } else {
envVars[envVar] = ""; envVars[envVar] = "";
} }
} else if (parsingFlags && arg === "--transport" && i + 1 < args.length) {
transport = args[++i];
} else if (parsingFlags && arg === "--server-url" && i + 1 < args.length) {
serverUrl = args[++i];
} else if (!command && !isDev) { } else if (!command && !isDev) {
command = arg; command = arg;
} else if (!isDev) { } else if (!isDev) {
@ -319,8 +297,6 @@ async function main() {
sessionToken, sessionToken,
abort, abort,
cancelled, cancelled,
transport,
serverUrl,
}; };
await (isDev await (isDev