modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: resolve the servers list outside the override's state updater (#2095)

Browse source 
`record` read `serversRef.current` from inside the `setRecords` updater. A
functional updater must be pure -- React may defer or replay it -- so the
pairing resolved at whatever moment the updater happened to run rather than
when the record was written. A list read committing in between would then be
paired with the record as its baseline, and the very read that should have
superseded the override would instead certify it.

Read the list once, at call time, and use it for both the pairing and the
prune.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0177mPHAdECD18nLLCTwR5rh
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-08-25 20:33:14 -04:00
commit bbffafded1
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
clients/web/src/hooks/usePaginatedListsOverride.ts
View file

@ -82,8 +82,13 @@ export function usePaginatedListsOverride(
}, [servers]);
const record = useCallback((serverId: string, value: boolean) => {
// Read outside the updater. A functional updater must be pure — React may
// defer or replay it — and this one would otherwise resolve the ref at
// whatever moment it happened to run. A list read committing in between
// would then be paired with the record as its baseline, so the very read
// that should have superseded the override would instead certify it.
const list = serversRef.current;
setRecords((previous) => {
const list = serversRef.current;
const next = new Map<string, OverrideRecord>();
// Carry forward only the records the list has not moved past, so a
// session that toggles across many servers does not accumulate a record