From c026d4d84a190d998d4dba3cee6d4db8d41272bb Mon Sep 17 00:00:00 2001 From: cliffhall Date: Sat, 4 Jul 2026 15:42:22 -0400 Subject: [PATCH] docs: address review nits on the v2/main merge MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - transport.ts: update the SSE-branch comment to say the default path uses fetchWithOptionalAuthIntercept (proxy-aware baseFetch + optional auth-challenge intercept), not the bare proxy-aware baseFetch. - clients/cli/README.md: fix the §5 mid-session validation link to use the ../../specification/ prefix like the sibling links in the same sentence (previously resolved to a nonexistent clients/cli/ path). Both flagged by the @claude review of PR #1601; comment/doc-only, no runtime change. Co-Authored-By: Claude Opus 4.8 (1M context) Claude-Session: https://claude.ai/code/session_01S3fTN8H3R8YV4yUGvZjYnX --- clients/cli/README.md | 2 +- core/mcp/node/transport.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/clients/cli/README.md b/clients/cli/README.md index 098fe620..98eed8f6 100644 --- a/clients/cli/README.md +++ b/clients/cli/README.md @@ -153,7 +153,7 @@ npx @modelcontextprotocol/inspector --cli --catalog mcp.json --server my-http-se --method tools/list ``` -See [EMA / enterprise-managed auth](../../specification/v2_auth_ema.md) and [OAuth smoke testing](../../specification/v2_auth_smoke_testing.md) (§3 Stytch/CIMD; [§5 mid-session manual validation](v2_auth_smoke_testing.md#5-mid-session-auth--step-up--manual-validation) — CLI **C1–C2**). +See [EMA / enterprise-managed auth](../../specification/v2_auth_ema.md) and [OAuth smoke testing](../../specification/v2_auth_smoke_testing.md) (§3 Stytch/CIMD; [§5 mid-session manual validation](../../specification/v2_auth_smoke_testing.md#5-mid-session-auth--step-up--manual-validation) — CLI **C1–C2**). ## Exit codes & error envelopes diff --git a/core/mcp/node/transport.ts b/core/mcp/node/transport.ts index ee04c855..59260bc2 100644 --- a/core/mcp/node/transport.ts +++ b/core/mcp/node/transport.ts @@ -148,7 +148,8 @@ export function createTransportNode( const url = new URL(sseConfig.url); // A caller-supplied eventSourceInit.fetch wins as-is (explicit fetch is not - // re-wrapped for proxying); the default path uses the proxy-aware baseFetch. + // re-wrapped for proxying); the default path uses fetchWithOptionalAuthIntercept + // (the proxy-aware baseFetch plus the optional auth-challenge intercept). const sseFetch = (sseConfig.eventSourceInit?.fetch as typeof fetch) || fetchWithOptionalAuthIntercept;