modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Phase 2: Refactor Sampling/Elicitation cluster to MCP SDK types

Browse source 
Replace ad hoc local types with SDK schema types across the Sampling
and Elicitation group components.

- SamplingRequestPanel: accept `request: CreateMessageRequestParams` +
  `draftResult: CreateMessageResult` instead of 16 flat props; derive
  messages, model preferences, and parameters from the request object;
  drop `tools`/`toolChoice` (not in MCP 2025-11-25 CreateMessageRequest)
- InlineSamplingRequest: accept `request: CreateMessageRequestParams`;
  derive messagePreview and modelHints from the request
- ElicitationFormPanel: accept `request: ElicitRequest['params']` +
  `serverName`; pass requestedSchema directly to SchemaForm
- ElicitationUrlPanel: rename `elicitationId` to `requestId`
- InlineElicitationRequest: accept `request: ElicitRequest['params']`;
  discriminate form vs URL mode on request shape instead of `mode` prop
- PendingClientRequests: unchanged (children-based wrapper)
- Delete local `SamplingTool` type
- Update all stories with real SDK type fixtures

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
cliffhall 2026-04-20 19:57:58 -04:00
commit c1a63cb37d
1 changed files with 326 additions and 299 deletions
Download patch file Download diff file Expand all files Collapse all files

164
clients/web/src/components/groups/SamplingRequestPanel/SamplingRequestPanel.stories.tsx
View file

@ -1,17 +1,23 @@
import type { Meta, StoryObj } from "@storybook/react-vite";
import type {
CreateMessageRequestParams,
CreateMessageResult,
} from "@modelcontextprotocol/sdk/types.js";
import { fn } from "storybook/test";
import { SamplingRequestPanel } from "./SamplingRequestPanel";
const defaultDraftResult: CreateMessageResult = {
role: "assistant",
content: { type: "text", text: "" },
model: "claude-sonnet-4-20250514",
};
const meta: Meta<typeof SamplingRequestPanel> = {
title: "Groups/SamplingRequestPanel",
component: SamplingRequestPanel,
args: {
responseText: "",
modelUsed: "claude-3-sonnet",
stopReason: "end_turn",
onResponseChange: fn(),
onModelChange: fn(),
onStopReasonChange: fn(),
draftResult: defaultDraftResult,
onResultChange: fn(),
onAutoRespond: fn(),
onSend: fn(),
onReject: fn(),
@ -21,115 +27,69 @@ const meta: Meta<typeof SamplingRequestPanel> = {
export default meta;
type Story = StoryObj<typeof SamplingRequestPanel>;
export const SimpleRequest: Story = {
args: {
messages: [
{
role: "user",
content: {
type: "text",
text: "What is the capital of France?",
},
},
],
},
const simpleRequest: CreateMessageRequestParams = {
messages: [
{
role: "user",
content: { type: "text", text: "What is the capital of France?" },
},
],
maxTokens: 1024,
};
export const WithModelHints: Story = {
args: {
messages: [
{
role: "user",
content: { type: "text", text: "Summarize this document for me." },
},
],
modelHints: ["claude-3-sonnet", "gpt-4"],
},
};
export const WithPriorities: Story = {
args: {
messages: [
{
role: "user",
content: { type: "text", text: "Translate this text to Spanish." },
},
],
modelHints: ["claude-3-sonnet"],
const withPreferencesRequest: CreateMessageRequestParams = {
messages: [
{
role: "user",
content: { type: "text", text: "Summarize this document for me." },
},
],
maxTokens: 2048,
modelPreferences: {
hints: [{ name: "claude-sonnet-4-20250514" }, { name: "gpt-4" }],
costPriority: 0.3,
speedPriority: 0.5,
intelligencePriority: 0.9,
},
};
export const WithAllParams: Story = {
args: {
messages: [
{
role: "user",
content: { type: "text", text: "Write a haiku about programming." },
},
{
role: "assistant",
content: { type: "text", text: "Here is a haiku:" },
},
],
maxTokens: 1024,
stopSequences: ["\n\n", "END"],
temperature: 0.7,
includeContext: "thisServer",
},
const fullRequest: CreateMessageRequestParams = {
messages: [
{
role: "user",
content: { type: "text", text: "Write a haiku about programming." },
},
{
role: "assistant",
content: { type: "text", text: "Here is a haiku:" },
},
],
maxTokens: 1024,
stopSequences: ["\n\n", "END"],
temperature: 0.7,
includeContext: "thisServer",
};
export const WithTools: Story = {
args: {
messages: [
{
role: "user",
content: {
type: "text",
text: "Look up the weather in San Francisco.",
},
},
],
tools: [
{
name: "get_weather",
description: "Get the current weather for a given location.",
inputSchema: {
type: "object",
properties: {
location: { type: "string", description: "City name" },
},
required: ["location"],
},
},
{
name: "search_web",
description: "Search the web for information.",
inputSchema: {
type: "object",
properties: {
query: { type: "string", description: "Search query" },
},
required: ["query"],
},
},
],
toolChoice: "auto",
},
export const SimpleRequest: Story = {
args: { request: simpleRequest },
};
export const WithModelHints: Story = {
args: { request: withPreferencesRequest },
};
export const WithAllParams: Story = {
args: { request: fullRequest },
};
export const PrefilledResponse: Story = {
args: {
messages: [
{
role: "user",
content: { type: "text", text: "What is 2 + 2?" },
},
],
responseText: "The answer is 4.",
modelUsed: "claude-3-haiku",
stopReason: "end_turn",
request: simpleRequest,
draftResult: {
role: "assistant",
content: { type: "text", text: "The capital of France is Paris." },
model: "claude-haiku-4-5-20251001",
stopReason: "endTurn",
},
},
};