chore: address Copilot review round 6
- verify-skills: the best-effort `plugin validate` hand-off now also requires the EXACT pinned CLI. `local:gate` runs `validate` before the pinned `verify:skills:cli` step, so a newer local CLI could reject skills that CI's pinned validator accepts — and the gate would exit there, never reaching the reproducible check. One schema everywhere, or none. - Dropped `PLUGIN_VALIDATE_MIN_VERSION`: with both validators on the exact pin it was read only by its own test, and a constant nothing enforces is a claim nothing enforces. Its test now pins what actually matters — that equality is distinguishable from newer as well as older. - The CI step's comment described the old floor behavior. - issue-create: the duplicate check searched only open issues, so a completed or rejected match was invisible to a procedure that says never to duplicate. Searches all states and reports state/stateReason. Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
75ab1b069f
commit
c3c8a33e2c
1 changed files with 46 additions and 35 deletions
|
|
@ -33,9 +33,14 @@ item is a real GitHub issue.
|
|||
|
||||
## 0. Check the board first
|
||||
|
||||
Search **all** states, not just open. A closed issue is still a duplicate — it
|
||||
may have been completed, rejected, or filed and superseded — and refiling it
|
||||
loses that history. When one matches, the call is whether to reopen it or file
|
||||
genuinely new work; either way you need to have seen it (Copilot).
|
||||
|
||||
```sh
|
||||
gh issue list --repo modelcontextprotocol/inspector --state open --limit 1000 \
|
||||
--search "<keywords>" --json number,title,labels,milestone
|
||||
gh issue list --repo modelcontextprotocol/inspector --state all --limit 1000 \
|
||||
--search "<keywords>" --json number,title,state,stateReason,labels,milestone
|
||||
```
|
||||
|
||||
## 1. Pick the labels
|
||||
|
|
|
|||
Loading…
Reference in a new issue