modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

docs: scope §5a to web captures and drop the historical-consistency claim

Browse source 
Copilot review round 1 on #2271:

- §5 covers the TUI as well as the web UI, but a TUI capture has no Playwright
  viewport and no fullPage mode. §5a is now explicitly the browser path, with a
  one-line TUI instruction (size the terminal so nothing wraps) that hands off
  to §5b, which is retitled to say it applies to both.
- The claim that every existing shot was taken at 1280x900 was wrong —
  specification/screenshots holds 1554x1374 and 3184x1516 among others. 1280x900
  is now presented as the standard being adopted, grounded in the web smokes,
  with the assorted older sizes named as the problem rather than the precedent.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017nLLLTGc37hQiC8s3mNyhq
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-06 12:12:49 -04:00
commit c61a553031
1 changed files with 16 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

23
.claude/skills/pr-flow/SKILL.md
View file

@ -107,14 +107,21 @@ committed — so attach them to the PR body from there rather than referencing a
in-repo path. Name them for what they show (`tools-tab-before.png`), not
`Screenshot 2026-07-31 at 14.02.11.png`.
### 5a. Capture settings
### 5a. Capture settings — web
**Shoot at 1280×900, full page.** That is the viewport the web smokes already
use (`scripts/smoke-web-*.mjs`) and what every existing shot in the repo was
taken at, so a reviewer comparing two PRs is comparing the same thing. Prefer a
full-page shot over a Playwright `clip` region: a clip sized to one panel cuts
off anything placed beside it, and two clips of different sizes make a
before/after pair hard to read as a pair.
Everything in 5a is about a **browser** capture and assumes Playwright driving
the web client. A **TUI** change has no viewport and no `fullPage` mode: size
the terminal so no line wraps or truncates, and go straight to 5b, which applies
to every image regardless of how it was taken.
**Shoot the web client at 1280×900, full page.** That is the viewport the web
smokes already use (`scripts/smoke-web-*.mjs`), and adopting it as the standard
here is what makes a reviewer comparing two PRs compare the same thing — the
older shots checked into `specification/screenshots/` were taken at assorted
sizes, which is the problem, not the precedent. Prefer a full-page shot over a
Playwright `clip` region: a clip sized to one panel cuts off anything placed
beside it, and two clips of different sizes make a before/after pair hard to
read as a pair.
⚠️ **Widening the window does not widen the Monitor sidebar.** The
main/sidebar split is a draggable divider whose width is stored independently of
@ -159,7 +166,7 @@ Two more mechanics worth setting before the shutter:
line is the actual assertion and the image is the evidence. **Say in the PR
body that the outline is script-added**, not app UI.
### 5b. Read the shot back before uploading
### 5b. Read the shot back before uploading — web and TUI
**Open every image and confirm nothing is cut off at either edge** — no
truncated row, clipped badge, or value running under a panel border, and no