diff --git a/clients/cli/__tests__/clear-stored-auth-for-relogin.test.ts b/clients/cli/__tests__/clear-stored-auth-for-relogin.test.ts index 9b5e587d..be763289 100644 --- a/clients/cli/__tests__/clear-stored-auth-for-relogin.test.ts +++ b/clients/cli/__tests__/clear-stored-auth-for-relogin.test.ts @@ -6,6 +6,7 @@ import { getStateFilePath, resetNodeOAuthStorageCache, } from "@inspector/core/auth/node/storage-node.js"; +import { MIN_REVOCATION_REQUEST_BUDGET_MS } from "@inspector/core/auth/revocation.js"; import { clearStoredAuthForRelogin } from "../src/clear-stored-auth-for-relogin.js"; const AS_ISSUER = "https://as.example.com"; @@ -379,6 +380,35 @@ describe("clearStoredAuthForRelogin", () => { } }); + // The zero-budget case above passes under the old `remainingMs <= 0` bound + // too, so it says nothing about the floor. This one is the floor's own + // detector: a budget that is genuinely positive, and genuinely too small to + // complete a request, must be spent on no request at all (#2252). The + // budget only shrinks as the loop runs, so a slow machine cannot flip it. + it("issues no request for a positive budget below the minimum", async () => { + seedBothSpellings("live-r", "stale-r"); + const fetchSpy = vi + .spyOn(globalThis, "fetch") + .mockResolvedValue(new Response(null, { status: 200 })); + try { + const outcome = await clearStoredAuthForRelogin("https://example.com", { + budgetMs: MIN_REVOCATION_REQUEST_BUDGET_MS - 1, + }); + expect(fetchSpy).not.toHaveBeenCalled(); + expect(outcome).toMatchObject({ status: "failed" }); + // The *plan* was never attempted, so the report has to be this loop's + // own — naming the server URL — and not the per-grant one from inside + // `executeOAuthRevocation`. Without that distinction the assertion + // passes on the old `<= 0` bound too: the plan would be handed a 4ms + // budget, and core's identical floor would decline it one level down. + expect(outcome?.status === "failed" ? outcome.detail : "").toContain( + 'budget was exhausted before "', + ); + } finally { + fetchSpy.mockRestore(); + } + }); + it("reports a later failure over an earlier success", async () => { seedBothSpellings("live-r", "stale-r"); const fetchSpy = vi