feat(web): enforce localhost-only binding; expand loopback origin allow-list (#1796)
Closes #1795. Enforce localhost-only binding in code (the "never 0.0.0.0" rule was only a spec note): refuse an all-interfaces HOST — across every spelling the OS binds as the wildcard (inet_aton decimal/octal/hex, IPv6, IPv4-mapped, zone-scoped, IDNA/Unicode) — unless DANGEROUSLY_BIND_ALL_INTERFACES=true (Docker's sanctioned opt-in). Fixes the reported stdio-connect 403 by expanding the default loopback origin allow-list to all three interchangeable forms. Hardening surfaced across an extended review: closes an IDNA/fullwidth wildcard bypass, a blank-ALLOWED_ORIGINS fail-open, and the CLI/TUI OAuth-callback wildcard bind (loopback-only now, RFC 8252); canonicalizes the origin allow-list the way a browser does; derives frame-ancestors from the real embedder list (IPv6-literal exclusion verified in headless Chromium); strictPort on all three bind points; and preserves the CLI exit-code map + JSON envelope through the mcp-inspector --cli launcher path. Shared host normalization lives in core/node/hostUrl.ts. Docs + tests + smokes throughout. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This commit is contained in:
parent
33e88eac9f
commit
cea22d86b8
1 changed files with 1610 additions and 86 deletions
12
AGENTS.md
12
AGENTS.md
|
|
@ -17,6 +17,10 @@ inspector/
|
|||
│ │ │ # sandbox-controller.ts (MCP Apps sandbox HTTP server),
|
||||
│ │ │ # inject-auth-token.ts (embeds the API token into served index.html),
|
||||
│ │ │ # vite-base-config.ts (shared optimizeDeps exclusions),
|
||||
│ │ │ # resolve-bind-host.ts (bind-host POLICY: refuses an
|
||||
│ │ │ # all-interfaces HOST unless DANGEROUSLY_BIND_ALL_INTERFACES;
|
||||
│ │ │ # the all-interfaces DETECTION is core/node/hostUrl.isAllInterfacesHost.
|
||||
│ │ │ # Used by both bind points — web-server-config.ts + vite.config.ts — #1795),
|
||||
│ │ │ # browser-externalized-builtin-gate.ts (build-gate logic that fails
|
||||
│ │ │ # `vite build` on a browser-externalized Node built-in — #1769)
|
||||
│ │ └── static/ # sandbox_proxy.html (served by sandbox-controller for MCP Apps tab)
|
||||
|
|
@ -50,6 +54,14 @@ inspector/
|
|||
│ │ ├── remote/ # Browser HTTP/SSE transport + remote logger/fetch
|
||||
│ │ │ └── node/ # Hono-based remote server backend (used by remote/ above)
|
||||
│ │ └── state/ # InspectorClient state stores consumed by core/react/
|
||||
│ ├── node/ # Node-only shared helpers: version.ts (readInspectorVersion,
|
||||
│ │ # walks to the root package.json), hostUrl.ts (shared host
|
||||
│ │ # normalization + detection — formatHostForUrl brackets IPv6,
|
||||
│ │ # canonicalUrlHost canonicalizes a bind host the way a browser
|
||||
│ │ # builds `Origin`, isAllInterfacesHost is the wildcard-bind
|
||||
│ │ # predicate the guard is built on, isLoopbackHost gates the OAuth
|
||||
│ │ # callback listener; also stripBrackets. Used across
|
||||
│ │ # clients/web/server, clients/cli, and core/auth/node — #1795)
|
||||
│ ├── react/ # React hooks over the state stores
|
||||
│ └── storage/ # File I/O helpers (store-io.ts) used by OAuth persist backends
|
||||
├── test-servers/ # Composable MCP test servers + fixtures used by integration tests.
|
||||
|
|
|
|||
Loading…
Reference in a new issue