feat(web): enforce localhost-only binding; expand loopback origin allow-list (#1796)
Closes #1795. Enforce localhost-only binding in code (the "never 0.0.0.0" rule was only a spec note): refuse an all-interfaces HOST — across every spelling the OS binds as the wildcard (inet_aton decimal/octal/hex, IPv6, IPv4-mapped, zone-scoped, IDNA/Unicode) — unless DANGEROUSLY_BIND_ALL_INTERFACES=true (Docker's sanctioned opt-in). Fixes the reported stdio-connect 403 by expanding the default loopback origin allow-list to all three interchangeable forms. Hardening surfaced across an extended review: closes an IDNA/fullwidth wildcard bypass, a blank-ALLOWED_ORIGINS fail-open, and the CLI/TUI OAuth-callback wildcard bind (loopback-only now, RFC 8252); canonicalizes the origin allow-list the way a browser does; derives frame-ancestors from the real embedder list (IPv6-literal exclusion verified in headless Chromium); strictPort on all three bind points; and preserves the CLI exit-code map + JSON envelope through the mcp-inspector --cli launcher path. Shared host normalization lives in core/node/hostUrl.ts. Docs + tests + smokes throughout. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This commit is contained in:
parent
33e88eac9f
commit
cea22d86b8
1 changed files with 1610 additions and 86 deletions
|
|
@ -18,7 +18,10 @@ import {
|
|||
parseHeaderPair,
|
||||
type ServerConfigOptions,
|
||||
} from "../../../core/mcp/node/config.ts";
|
||||
import { buildWebServerConfig } from "./web-server-config.js";
|
||||
import {
|
||||
buildWebServerConfig,
|
||||
type WebServerConfig,
|
||||
} from "./web-server-config.js";
|
||||
import { startViteDevServer } from "./start-vite-dev-server.js";
|
||||
import { startHonoServer } from "./server.js";
|
||||
import { ensureWebBuild } from "./ensure-web-build.js";
|
||||
|
|
@ -232,12 +235,25 @@ export async function runWeb(argv: string[]): Promise<number> {
|
|||
process.exit(1);
|
||||
}
|
||||
|
||||
const webConfig = buildWebServerConfig({
|
||||
initialMcpConfig,
|
||||
mcpConfigPath,
|
||||
writable,
|
||||
initialServers,
|
||||
});
|
||||
let webConfig: WebServerConfig;
|
||||
try {
|
||||
webConfig = buildWebServerConfig({
|
||||
initialMcpConfig,
|
||||
mcpConfigPath,
|
||||
writable,
|
||||
initialServers,
|
||||
});
|
||||
} catch (err) {
|
||||
// e.g. the bind-host guard refusing HOST=0.0.0.0 — surface the actionable
|
||||
// message rather than a raw stack trace from the launcher's top-level handler.
|
||||
const message =
|
||||
err instanceof Error
|
||||
? err.message
|
||||
: /* v8 ignore next -- buildWebServerConfig only ever throws Error instances; this fallback is a defensive guard for the impossible non-Error throw. */
|
||||
"Invalid web server configuration.";
|
||||
console.error("Error:", message);
|
||||
process.exit(1);
|
||||
}
|
||||
const webRoot = join(__dirname, "..");
|
||||
const distRoot = join(webRoot, "dist");
|
||||
if (!isDev) {
|
||||
|
|
|
|||
Loading…
Reference in a new issue