feat(web): enforce localhost-only binding; expand loopback origin allow-list (#1796)
Closes #1795. Enforce localhost-only binding in code (the "never 0.0.0.0" rule was only a spec note): refuse an all-interfaces HOST — across every spelling the OS binds as the wildcard (inet_aton decimal/octal/hex, IPv6, IPv4-mapped, zone-scoped, IDNA/Unicode) — unless DANGEROUSLY_BIND_ALL_INTERFACES=true (Docker's sanctioned opt-in). Fixes the reported stdio-connect 403 by expanding the default loopback origin allow-list to all three interchangeable forms. Hardening surfaced across an extended review: closes an IDNA/fullwidth wildcard bypass, a blank-ALLOWED_ORIGINS fail-open, and the CLI/TUI OAuth-callback wildcard bind (loopback-only now, RFC 8252); canonicalizes the origin allow-list the way a browser does; derives frame-ancestors from the real embedder list (IPv6-literal exclusion verified in headless Chromium); strictPort on all three bind points; and preserves the CLI exit-code map + JSON envelope through the mcp-inspector --cli launcher path. Shared host normalization lives in core/node/hostUrl.ts. Docs + tests + smokes throughout. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This commit is contained in:
parent
33e88eac9f
commit
cea22d86b8
1 changed files with 1610 additions and 86 deletions
|
|
@ -57,6 +57,12 @@ export async function startViteDevServer(
|
|||
server: {
|
||||
port: config.port,
|
||||
host: config.hostname,
|
||||
// `strictPort: true` (matching `vite.config.ts`) so a busy port fails
|
||||
// loudly instead of silently binding a different one — the origin
|
||||
// allow-list and the sandbox `frame-ancestors` are derived from
|
||||
// `config.port`, so a drifted bind would 403 every connect and CSP-block
|
||||
// the MCP Apps iframe while the banner advertises the unusable port.
|
||||
strictPort: true,
|
||||
// Allow Vite to serve source files from the repo root (core/ lives
|
||||
// outside clients/web), matching `vite.config.ts`'s `server.fs.allow`.
|
||||
fs: {
|
||||
|
|
|
|||
Loading…
Reference in a new issue