chore: address Copilot review round 4
- verify:skills:cli — the authoritative validator is now a GUARANTEED step in `local:gate` and CI, not a best-effort hand-off. It resolves the CLI itself (an installed one at 2.1.233+, else a pinned `npx -y`), so both tiers run the same script and cannot drift. `verify:skills` keeps skipping when the CLI is absent, which is right for `validate`: fast, offline, no Claude Code required. - skill-manifest: the 1,536-char listing-entry cap covers `description` + `when_to_use` together; checking the description alone passed an over-cap entry. `when_to_use` is now parsed, validated and counted, with boundary tests at 1,536/1,537. - verify-skills: report the budget as *this repo's contribution*. The real listing budget is shared with bundled skills and the contributor's own ~/.claude/skills, none of which is visible from here, so the number was claiming more than it measured. - skill-eval: a negative case now means "no skill OF THIS REPO'S fired". It failed on any Skill invocation, so a contributor with an unrelated global skill got a false failure about their environment rather than these skills. - docs/architecture + local-dev: the Node backend runner gets its `@inspector/core` alias from `clients/web/tsup.runner.config.ts`, not from Vite. The old text sent runner work to the wrong config. - local-dev: the tarball does not ship "only each client's build/" — the allowlist also carries `clients/web/dist`, `clients/web/static` and the install helper. States the invariant that actually matters instead. - issue-triage: the test for needing triage is "no board card". Adding "and no milestone" would skip the approved-but-unboarded case the same section then handles. Also corrected the `$M` note: the lookup is `--state all`, so closed issues DO have entries — `isopen` is about the invariants, not the lookup. - issue-create: replaced "all five" with a per-version table. Steps 3 and 6 (milestone, Priority) do not exist for v1, so the old list opened with a rule the same skill later tells you to violate. Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
7e0bb8b58d
commit
d05e76d470
1 changed files with 330 additions and 51 deletions
10
AGENTS.md
10
AGENTS.md
|
|
@ -152,9 +152,13 @@ that from happening:
|
|||
runs `claude plugin validate` — the authoritative schema — when that CLI is on
|
||||
PATH **and new enough to have the subcommand** (2.1.233+; below that it exits
|
||||
nonzero as an unknown command, which must not fail the gate for someone who
|
||||
simply has not upgraded). Because the guard skips it when absent, CI installs
|
||||
a pinned CLI and runs it as its own step, so "authoritative validation runs in
|
||||
CI" is true rather than aspirational.
|
||||
simply has not upgraded).
|
||||
That best-effort hand-off keeps `validate` fast and offline, but it also
|
||||
means it usually does not run — so the authoritative check gets a **guaranteed
|
||||
step of its own**, `npm run verify:skills:cli`, in `local:gate` and in CI.
|
||||
It resolves the CLI rather than hoping for one: an installed CLI when it is
|
||||
new enough, otherwise a **pinned** one via `npx -y`. Both tiers run the same
|
||||
script, so they cannot drift.
|
||||
⚠️ Frontmatter is only read when the opening `---` is the file's **first
|
||||
line** — no BOM, no leading blank line.
|
||||
2. **Every skill declares its invocation mode explicitly.**
|
||||
|
|
|
|||
Loading…
Reference in a new issue