chore: address Copilot review round 18
- board-ops: write board dumps to a temp dir, not the repo root. The boards are private, so a snapshot is a full export of item IDs and every card's Status and Priority — and the recipe left three such files in the worktree, one `git add -A` from being published in a PR. All three now go to `$BOARD_TMP`, and the snapshot step prints the path, since recovery needs it. - release: branch from `origin/v2/main` after fetching, and read the version once you are on it. A default clone has only `main` checked out, so the local ref may not exist and `package.json` was `main`'s — the released version rather than the one being bumped from. Added the one-liner for reading it before branching, since the branch name needs it. Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
1203246537
commit
d29bbbb763
1 changed files with 31 additions and 9 deletions
|
|
@ -33,13 +33,21 @@ The bump is part of the milestone's work, so it belongs on the develop branch
|
|||
and flows into `main` with everything else.
|
||||
|
||||
```sh
|
||||
# The branch name carries the version you are bumping TO, so read it first.
|
||||
# Branch from the REMOTE ref, and read the version only once you are on it.
|
||||
# A default clone has just `main` checked out, so a local `v2/main` may not
|
||||
# exist and `package.json` here is `main`'s — the released version, not the one
|
||||
# you are bumping from (Copilot).
|
||||
git fetch origin v2/main
|
||||
git checkout -b v2/chore/<ISSUE>-bump-<X-Y-Z> origin/v2/main
|
||||
node -p "require('./package.json').version" # what is on v2/main now
|
||||
git checkout -b v2/chore/<ISSUE>-bump-<X-Y-Z> v2/main
|
||||
npm version minor --no-git-tag-version # or major / patch; bump only, no tag
|
||||
node -p "require('./package.json').version" # confirm, then PR → v2/main
|
||||
```
|
||||
|
||||
The branch name carries the version you are bumping **to**, so it is named after
|
||||
that second reading. If you want it before branching:
|
||||
`git show origin/v2/main:package.json | node -p "JSON.parse(require('fs').readFileSync(0)).version"`.
|
||||
|
||||
⚠️ **Never copy a version out of this file.** It would be a version that has
|
||||
already shipped by the time you read it, and following it would cut a release
|
||||
branch named for the wrong release (Copilot).
|
||||
|
|
|
|||
Loading…
Reference in a new issue