Merge pull request #719 from richardkmichael/fix-704-trim-command-whitespace
fix: Trim whitespace from Command input to prevent ENOENT
This commit is contained in:
commit
d48164aa09
3 changed files with 550 additions and 512 deletions
|
|
@ -268,6 +268,7 @@ const Sidebar = ({
|
||||||
placeholder="Command"
|
placeholder="Command"
|
||||||
value={command}
|
value={command}
|
||||||
onChange={(e) => setCommand(e.target.value)}
|
onChange={(e) => setCommand(e.target.value)}
|
||||||
|
onBlur={(e) => setCommand(e.target.value.trim())}
|
||||||
className="font-mono"
|
className="font-mono"
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
|
|
|
||||||
|
|
@ -31,7 +31,7 @@ Object.defineProperty(navigator, "clipboard", {
|
||||||
// Setup fake timers
|
// Setup fake timers
|
||||||
jest.useFakeTimers();
|
jest.useFakeTimers();
|
||||||
|
|
||||||
describe("Sidebar Environment Variables", () => {
|
describe("Sidebar", () => {
|
||||||
const defaultProps = {
|
const defaultProps = {
|
||||||
connectionStatus: "disconnected" as const,
|
connectionStatus: "disconnected" as const,
|
||||||
transportType: "stdio" as const,
|
transportType: "stdio" as const,
|
||||||
|
|
@ -69,16 +69,49 @@ describe("Sidebar Environment Variables", () => {
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
const openEnvVarsSection = () => {
|
|
||||||
const button = screen.getByTestId("env-vars-button");
|
|
||||||
fireEvent.click(button);
|
|
||||||
};
|
|
||||||
|
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
jest.clearAllMocks();
|
jest.clearAllMocks();
|
||||||
jest.clearAllTimers();
|
jest.clearAllTimers();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("Command and arguments", () => {
|
||||||
|
it("should trim whitespace from command input on blur", () => {
|
||||||
|
const setCommand = jest.fn();
|
||||||
|
renderSidebar({ command: " node server.js ", setCommand });
|
||||||
|
|
||||||
|
const commandInput = screen.getByLabelText("Command");
|
||||||
|
|
||||||
|
fireEvent.blur(commandInput);
|
||||||
|
expect(setCommand).toHaveBeenLastCalledWith("node server.js");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should handle whitespace-only command input on blur", () => {
|
||||||
|
const setCommand = jest.fn();
|
||||||
|
renderSidebar({ command: " ", setCommand });
|
||||||
|
|
||||||
|
const commandInput = screen.getByLabelText("Command");
|
||||||
|
|
||||||
|
fireEvent.blur(commandInput);
|
||||||
|
expect(setCommand).toHaveBeenLastCalledWith("");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not affect command without surrounding whitespace", () => {
|
||||||
|
const setCommand = jest.fn();
|
||||||
|
renderSidebar({ command: "node", setCommand });
|
||||||
|
|
||||||
|
const commandInput = screen.getByLabelText("Command");
|
||||||
|
|
||||||
|
fireEvent.blur(commandInput);
|
||||||
|
expect(setCommand).toHaveBeenLastCalledWith("node");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("Environment Variables", () => {
|
||||||
|
const openEnvVarsSection = () => {
|
||||||
|
const button = screen.getByTestId("env-vars-button");
|
||||||
|
fireEvent.click(button);
|
||||||
|
};
|
||||||
|
|
||||||
describe("Basic Operations", () => {
|
describe("Basic Operations", () => {
|
||||||
it("should add a new environment variable", () => {
|
it("should add a new environment variable", () => {
|
||||||
const setEnv = jest.fn();
|
const setEnv = jest.fn();
|
||||||
|
|
@ -127,164 +160,15 @@ describe("Sidebar Environment Variables", () => {
|
||||||
const valueInput = screen.getByDisplayValue("test_value");
|
const valueInput = screen.getByDisplayValue("test_value");
|
||||||
expect(valueInput).toHaveProperty("type", "password");
|
expect(valueInput).toHaveProperty("type", "password");
|
||||||
|
|
||||||
const toggleButton = screen.getByRole("button", { name: /show value/i });
|
const toggleButton = screen.getByRole("button", {
|
||||||
|
name: /show value/i,
|
||||||
|
});
|
||||||
fireEvent.click(toggleButton);
|
fireEvent.click(toggleButton);
|
||||||
|
|
||||||
expect(valueInput).toHaveProperty("type", "text");
|
expect(valueInput).toHaveProperty("type", "text");
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe("Authentication", () => {
|
|
||||||
const openAuthSection = () => {
|
|
||||||
const button = screen.getByTestId("auth-button");
|
|
||||||
fireEvent.click(button);
|
|
||||||
};
|
|
||||||
|
|
||||||
it("should update bearer token", () => {
|
|
||||||
const setBearerToken = jest.fn();
|
|
||||||
renderSidebar({
|
|
||||||
bearerToken: "",
|
|
||||||
setBearerToken,
|
|
||||||
transportType: "sse", // Set transport type to SSE
|
|
||||||
});
|
|
||||||
|
|
||||||
openAuthSection();
|
|
||||||
|
|
||||||
const tokenInput = screen.getByTestId("bearer-token-input");
|
|
||||||
fireEvent.change(tokenInput, { target: { value: "new_token" } });
|
|
||||||
|
|
||||||
expect(setBearerToken).toHaveBeenCalledWith("new_token");
|
|
||||||
});
|
|
||||||
|
|
||||||
it("should update header name", () => {
|
|
||||||
const setHeaderName = jest.fn();
|
|
||||||
renderSidebar({
|
|
||||||
headerName: "Authorization",
|
|
||||||
setHeaderName,
|
|
||||||
transportType: "sse",
|
|
||||||
});
|
|
||||||
|
|
||||||
openAuthSection();
|
|
||||||
|
|
||||||
const headerInput = screen.getByTestId("header-input");
|
|
||||||
fireEvent.change(headerInput, { target: { value: "X-Custom-Auth" } });
|
|
||||||
|
|
||||||
expect(setHeaderName).toHaveBeenCalledWith("X-Custom-Auth");
|
|
||||||
});
|
|
||||||
|
|
||||||
it("should clear bearer token", () => {
|
|
||||||
const setBearerToken = jest.fn();
|
|
||||||
renderSidebar({
|
|
||||||
bearerToken: "existing_token",
|
|
||||||
setBearerToken,
|
|
||||||
transportType: "sse", // Set transport type to SSE
|
|
||||||
});
|
|
||||||
|
|
||||||
openAuthSection();
|
|
||||||
|
|
||||||
const tokenInput = screen.getByTestId("bearer-token-input");
|
|
||||||
fireEvent.change(tokenInput, { target: { value: "" } });
|
|
||||||
|
|
||||||
expect(setBearerToken).toHaveBeenCalledWith("");
|
|
||||||
});
|
|
||||||
|
|
||||||
it("should properly render bearer token input", () => {
|
|
||||||
const { rerender } = renderSidebar({
|
|
||||||
bearerToken: "existing_token",
|
|
||||||
transportType: "sse", // Set transport type to SSE
|
|
||||||
});
|
|
||||||
|
|
||||||
openAuthSection();
|
|
||||||
|
|
||||||
// Token input should be a password field
|
|
||||||
const tokenInput = screen.getByTestId("bearer-token-input");
|
|
||||||
expect(tokenInput).toHaveProperty("type", "password");
|
|
||||||
|
|
||||||
// Update the token
|
|
||||||
fireEvent.change(tokenInput, { target: { value: "new_token" } });
|
|
||||||
|
|
||||||
// Rerender with updated token
|
|
||||||
rerender(
|
|
||||||
<TooltipProvider>
|
|
||||||
<Sidebar
|
|
||||||
{...defaultProps}
|
|
||||||
bearerToken="new_token"
|
|
||||||
transportType="sse"
|
|
||||||
/>
|
|
||||||
</TooltipProvider>,
|
|
||||||
);
|
|
||||||
|
|
||||||
// Token input should still exist after update
|
|
||||||
expect(screen.getByTestId("bearer-token-input")).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
|
|
||||||
it("should maintain token visibility state after update", () => {
|
|
||||||
const { rerender } = renderSidebar({
|
|
||||||
bearerToken: "existing_token",
|
|
||||||
transportType: "sse", // Set transport type to SSE
|
|
||||||
});
|
|
||||||
|
|
||||||
openAuthSection();
|
|
||||||
|
|
||||||
// Token input should be a password field
|
|
||||||
const tokenInput = screen.getByTestId("bearer-token-input");
|
|
||||||
expect(tokenInput).toHaveProperty("type", "password");
|
|
||||||
|
|
||||||
// Update the token
|
|
||||||
fireEvent.change(tokenInput, { target: { value: "new_token" } });
|
|
||||||
|
|
||||||
// Rerender with updated token
|
|
||||||
rerender(
|
|
||||||
<TooltipProvider>
|
|
||||||
<Sidebar
|
|
||||||
{...defaultProps}
|
|
||||||
bearerToken="new_token"
|
|
||||||
transportType="sse"
|
|
||||||
/>
|
|
||||||
</TooltipProvider>,
|
|
||||||
);
|
|
||||||
|
|
||||||
// Token input should still exist after update
|
|
||||||
expect(screen.getByTestId("bearer-token-input")).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
|
|
||||||
it("should maintain header name when toggling auth section", () => {
|
|
||||||
renderSidebar({
|
|
||||||
headerName: "X-API-Key",
|
|
||||||
transportType: "sse",
|
|
||||||
});
|
|
||||||
|
|
||||||
// Open auth section
|
|
||||||
openAuthSection();
|
|
||||||
|
|
||||||
// Verify header name is displayed
|
|
||||||
const headerInput = screen.getByTestId("header-input");
|
|
||||||
expect(headerInput).toHaveValue("X-API-Key");
|
|
||||||
|
|
||||||
// Close auth section
|
|
||||||
const authButton = screen.getByTestId("auth-button");
|
|
||||||
fireEvent.click(authButton);
|
|
||||||
|
|
||||||
// Reopen auth section
|
|
||||||
fireEvent.click(authButton);
|
|
||||||
|
|
||||||
// Verify header name is still preserved
|
|
||||||
expect(screen.getByTestId("header-input")).toHaveValue("X-API-Key");
|
|
||||||
});
|
|
||||||
|
|
||||||
it("should display default header name when not specified", () => {
|
|
||||||
renderSidebar({
|
|
||||||
headerName: undefined,
|
|
||||||
transportType: "sse",
|
|
||||||
});
|
|
||||||
|
|
||||||
openAuthSection();
|
|
||||||
|
|
||||||
const headerInput = screen.getByTestId("header-input");
|
|
||||||
expect(headerInput).toHaveAttribute("placeholder", "Authorization");
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe("Key Editing", () => {
|
describe("Key Editing", () => {
|
||||||
it("should maintain order when editing first key", () => {
|
it("should maintain order when editing first key", () => {
|
||||||
const setEnv = jest.fn();
|
const setEnv = jest.fn();
|
||||||
|
|
@ -319,7 +203,9 @@ describe("Sidebar Environment Variables", () => {
|
||||||
openEnvVarsSection();
|
openEnvVarsSection();
|
||||||
|
|
||||||
const middleKeyInput = screen.getByDisplayValue("SECOND_KEY");
|
const middleKeyInput = screen.getByDisplayValue("SECOND_KEY");
|
||||||
fireEvent.change(middleKeyInput, { target: { value: "NEW_SECOND_KEY" } });
|
fireEvent.change(middleKeyInput, {
|
||||||
|
target: { value: "NEW_SECOND_KEY" },
|
||||||
|
});
|
||||||
|
|
||||||
expect(setEnv).toHaveBeenCalledWith({
|
expect(setEnv).toHaveBeenCalledWith({
|
||||||
FIRST_KEY: "first_value",
|
FIRST_KEY: "first_value",
|
||||||
|
|
@ -406,7 +292,9 @@ describe("Sidebar Environment Variables", () => {
|
||||||
|
|
||||||
// Second key edit
|
// Second key edit
|
||||||
const secondKeyInput = screen.getByDisplayValue("SECOND_KEY");
|
const secondKeyInput = screen.getByDisplayValue("SECOND_KEY");
|
||||||
fireEvent.change(secondKeyInput, { target: { value: "NEW_SECOND_KEY" } });
|
fireEvent.change(secondKeyInput, {
|
||||||
|
target: { value: "NEW_SECOND_KEY" },
|
||||||
|
});
|
||||||
|
|
||||||
// Verify the final state matches what we expect
|
// Verify the final state matches what we expect
|
||||||
expect(setEnv).toHaveBeenLastCalledWith({
|
expect(setEnv).toHaveBeenLastCalledWith({
|
||||||
|
|
@ -422,7 +310,9 @@ describe("Sidebar Environment Variables", () => {
|
||||||
openEnvVarsSection();
|
openEnvVarsSection();
|
||||||
|
|
||||||
// Show the value
|
// Show the value
|
||||||
const toggleButton = screen.getByRole("button", { name: /show value/i });
|
const toggleButton = screen.getByRole("button", {
|
||||||
|
name: /show value/i,
|
||||||
|
});
|
||||||
fireEvent.click(toggleButton);
|
fireEvent.click(toggleButton);
|
||||||
|
|
||||||
const valueInput = screen.getByDisplayValue("test_value");
|
const valueInput = screen.getByDisplayValue("test_value");
|
||||||
|
|
@ -472,7 +362,7 @@ describe("Sidebar Environment Variables", () => {
|
||||||
expect(setEnv).toHaveBeenCalledWith({ "TEST-KEY@123": "test_value" });
|
expect(setEnv).toHaveBeenCalledWith({ "TEST-KEY@123": "test_value" });
|
||||||
});
|
});
|
||||||
|
|
||||||
it("should handle unicode characters", () => {
|
it("should handle unicode characters in key", () => {
|
||||||
const setEnv = jest.fn();
|
const setEnv = jest.fn();
|
||||||
const initialEnv = { TEST_KEY: "test_value" };
|
const initialEnv = { TEST_KEY: "test_value" };
|
||||||
renderSidebar({ env: initialEnv, setEnv });
|
renderSidebar({ env: initialEnv, setEnv });
|
||||||
|
|
@ -485,7 +375,7 @@ describe("Sidebar Environment Variables", () => {
|
||||||
expect(setEnv).toHaveBeenCalledWith({ "TEST_🔑": "test_value" });
|
expect(setEnv).toHaveBeenCalledWith({ "TEST_🔑": "test_value" });
|
||||||
});
|
});
|
||||||
|
|
||||||
it("should handle very long key names", () => {
|
it("should handle a very long key name", () => {
|
||||||
const setEnv = jest.fn();
|
const setEnv = jest.fn();
|
||||||
const initialEnv = { TEST_KEY: "test_value" };
|
const initialEnv = { TEST_KEY: "test_value" };
|
||||||
renderSidebar({ env: initialEnv, setEnv });
|
renderSidebar({ env: initialEnv, setEnv });
|
||||||
|
|
@ -499,165 +389,9 @@ describe("Sidebar Environment Variables", () => {
|
||||||
expect(setEnv).toHaveBeenCalledWith({ [longKey]: "test_value" });
|
expect(setEnv).toHaveBeenCalledWith({ [longKey]: "test_value" });
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe("Configuration Operations", () => {
|
|
||||||
const openConfigSection = () => {
|
|
||||||
const button = screen.getByTestId("config-button");
|
|
||||||
fireEvent.click(button);
|
|
||||||
};
|
|
||||||
|
|
||||||
it("should update MCP server request timeout", () => {
|
|
||||||
const setConfig = jest.fn();
|
|
||||||
renderSidebar({ config: DEFAULT_INSPECTOR_CONFIG, setConfig });
|
|
||||||
|
|
||||||
openConfigSection();
|
|
||||||
|
|
||||||
const timeoutInput = screen.getByTestId(
|
|
||||||
"MCP_SERVER_REQUEST_TIMEOUT-input",
|
|
||||||
);
|
|
||||||
fireEvent.change(timeoutInput, { target: { value: "5000" } });
|
|
||||||
|
|
||||||
expect(setConfig).toHaveBeenCalledWith(
|
|
||||||
expect.objectContaining({
|
|
||||||
MCP_SERVER_REQUEST_TIMEOUT: {
|
|
||||||
label: "Request Timeout",
|
|
||||||
description: "Timeout for requests to the MCP server (ms)",
|
|
||||||
value: 5000,
|
|
||||||
is_session_item: false,
|
|
||||||
},
|
|
||||||
}),
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
it("should update MCP server proxy address", () => {
|
|
||||||
const setConfig = jest.fn();
|
|
||||||
renderSidebar({ config: DEFAULT_INSPECTOR_CONFIG, setConfig });
|
|
||||||
|
|
||||||
openConfigSection();
|
|
||||||
|
|
||||||
const proxyAddressInput = screen.getByTestId(
|
|
||||||
"MCP_PROXY_FULL_ADDRESS-input",
|
|
||||||
);
|
|
||||||
fireEvent.change(proxyAddressInput, {
|
|
||||||
target: { value: "http://localhost:8080" },
|
|
||||||
});
|
|
||||||
|
|
||||||
expect(setConfig).toHaveBeenCalledWith(
|
|
||||||
expect.objectContaining({
|
|
||||||
MCP_PROXY_FULL_ADDRESS: {
|
|
||||||
label: "Inspector Proxy Address",
|
|
||||||
description:
|
|
||||||
"Set this if you are running the MCP Inspector Proxy on a non-default address. Example: http://10.1.1.22:5577",
|
|
||||||
value: "http://localhost:8080",
|
|
||||||
is_session_item: false,
|
|
||||||
},
|
|
||||||
}),
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
it("should update max total timeout", () => {
|
|
||||||
const setConfig = jest.fn();
|
|
||||||
renderSidebar({ config: DEFAULT_INSPECTOR_CONFIG, setConfig });
|
|
||||||
|
|
||||||
openConfigSection();
|
|
||||||
|
|
||||||
const maxTotalTimeoutInput = screen.getByTestId(
|
|
||||||
"MCP_REQUEST_MAX_TOTAL_TIMEOUT-input",
|
|
||||||
);
|
|
||||||
fireEvent.change(maxTotalTimeoutInput, {
|
|
||||||
target: { value: "10000" },
|
|
||||||
});
|
|
||||||
|
|
||||||
expect(setConfig).toHaveBeenCalledWith(
|
|
||||||
expect.objectContaining({
|
|
||||||
MCP_REQUEST_MAX_TOTAL_TIMEOUT: {
|
|
||||||
label: "Maximum Total Timeout",
|
|
||||||
description:
|
|
||||||
"Maximum total timeout for requests sent to the MCP server (ms) (Use with progress notifications)",
|
|
||||||
value: 10000,
|
|
||||||
is_session_item: false,
|
|
||||||
},
|
|
||||||
}),
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
it("should handle invalid timeout values entered by user", () => {
|
|
||||||
const setConfig = jest.fn();
|
|
||||||
renderSidebar({ config: DEFAULT_INSPECTOR_CONFIG, setConfig });
|
|
||||||
|
|
||||||
openConfigSection();
|
|
||||||
|
|
||||||
const timeoutInput = screen.getByTestId(
|
|
||||||
"MCP_SERVER_REQUEST_TIMEOUT-input",
|
|
||||||
);
|
|
||||||
fireEvent.change(timeoutInput, { target: { value: "abc1" } });
|
|
||||||
|
|
||||||
expect(setConfig).toHaveBeenCalledWith(
|
|
||||||
expect.objectContaining({
|
|
||||||
MCP_SERVER_REQUEST_TIMEOUT: {
|
|
||||||
label: "Request Timeout",
|
|
||||||
description: "Timeout for requests to the MCP server (ms)",
|
|
||||||
value: 0,
|
|
||||||
is_session_item: false,
|
|
||||||
},
|
|
||||||
}),
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
it("should maintain configuration state after multiple updates", () => {
|
|
||||||
const setConfig = jest.fn();
|
|
||||||
const { rerender } = renderSidebar({
|
|
||||||
config: DEFAULT_INSPECTOR_CONFIG,
|
|
||||||
setConfig,
|
|
||||||
});
|
|
||||||
|
|
||||||
openConfigSection();
|
|
||||||
// First update
|
|
||||||
const timeoutInput = screen.getByTestId(
|
|
||||||
"MCP_SERVER_REQUEST_TIMEOUT-input",
|
|
||||||
);
|
|
||||||
fireEvent.change(timeoutInput, { target: { value: "5000" } });
|
|
||||||
|
|
||||||
// Get the updated config from the first setConfig call
|
|
||||||
const updatedConfig = setConfig.mock.calls[0][0] as InspectorConfig;
|
|
||||||
|
|
||||||
// Rerender with the updated config
|
|
||||||
rerender(
|
|
||||||
<TooltipProvider>
|
|
||||||
<Sidebar
|
|
||||||
{...defaultProps}
|
|
||||||
config={updatedConfig}
|
|
||||||
setConfig={setConfig}
|
|
||||||
/>
|
|
||||||
</TooltipProvider>,
|
|
||||||
);
|
|
||||||
|
|
||||||
// Second update
|
|
||||||
const updatedTimeoutInput = screen.getByTestId(
|
|
||||||
"MCP_SERVER_REQUEST_TIMEOUT-input",
|
|
||||||
);
|
|
||||||
fireEvent.change(updatedTimeoutInput, { target: { value: "3000" } });
|
|
||||||
|
|
||||||
// Verify the final state matches what we expect
|
|
||||||
expect(setConfig).toHaveBeenLastCalledWith(
|
|
||||||
expect.objectContaining({
|
|
||||||
MCP_SERVER_REQUEST_TIMEOUT: {
|
|
||||||
label: "Request Timeout",
|
|
||||||
description: "Timeout for requests to the MCP server (ms)",
|
|
||||||
value: 3000,
|
|
||||||
is_session_item: false,
|
|
||||||
},
|
|
||||||
}),
|
|
||||||
);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe("Copy Configuration Features", () => {
|
|
||||||
beforeEach(() => {
|
|
||||||
jest.clearAllMocks();
|
|
||||||
jest.clearAllTimers();
|
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("Copy Server Features", () => {
|
||||||
const getCopyButtons = () => {
|
const getCopyButtons = () => {
|
||||||
return {
|
return {
|
||||||
serverEntry: screen.getByRole("button", { name: /server entry/i }),
|
serverEntry: screen.getByRole("button", { name: /server entry/i }),
|
||||||
|
|
@ -878,4 +612,307 @@ describe("Sidebar Environment Variables", () => {
|
||||||
expect(mockClipboardWrite).toHaveBeenCalledWith(expectedConfig);
|
expect(mockClipboardWrite).toHaveBeenCalledWith(expectedConfig);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("Authentication", () => {
|
||||||
|
const openAuthSection = () => {
|
||||||
|
const button = screen.getByTestId("auth-button");
|
||||||
|
fireEvent.click(button);
|
||||||
|
};
|
||||||
|
|
||||||
|
it("should update bearer token", () => {
|
||||||
|
const setBearerToken = jest.fn();
|
||||||
|
renderSidebar({
|
||||||
|
bearerToken: "",
|
||||||
|
setBearerToken,
|
||||||
|
transportType: "sse", // Set transport type to SSE
|
||||||
|
});
|
||||||
|
|
||||||
|
openAuthSection();
|
||||||
|
|
||||||
|
const tokenInput = screen.getByTestId("bearer-token-input");
|
||||||
|
fireEvent.change(tokenInput, { target: { value: "new_token" } });
|
||||||
|
|
||||||
|
expect(setBearerToken).toHaveBeenCalledWith("new_token");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should update header name", () => {
|
||||||
|
const setHeaderName = jest.fn();
|
||||||
|
renderSidebar({
|
||||||
|
headerName: "Authorization",
|
||||||
|
setHeaderName,
|
||||||
|
transportType: "sse",
|
||||||
|
});
|
||||||
|
|
||||||
|
openAuthSection();
|
||||||
|
|
||||||
|
const headerInput = screen.getByTestId("header-input");
|
||||||
|
fireEvent.change(headerInput, { target: { value: "X-Custom-Auth" } });
|
||||||
|
|
||||||
|
expect(setHeaderName).toHaveBeenCalledWith("X-Custom-Auth");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should clear bearer token", () => {
|
||||||
|
const setBearerToken = jest.fn();
|
||||||
|
renderSidebar({
|
||||||
|
bearerToken: "existing_token",
|
||||||
|
setBearerToken,
|
||||||
|
transportType: "sse", // Set transport type to SSE
|
||||||
|
});
|
||||||
|
|
||||||
|
openAuthSection();
|
||||||
|
|
||||||
|
const tokenInput = screen.getByTestId("bearer-token-input");
|
||||||
|
fireEvent.change(tokenInput, { target: { value: "" } });
|
||||||
|
|
||||||
|
expect(setBearerToken).toHaveBeenCalledWith("");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should properly render bearer token input", () => {
|
||||||
|
const { rerender } = renderSidebar({
|
||||||
|
bearerToken: "existing_token",
|
||||||
|
transportType: "sse", // Set transport type to SSE
|
||||||
|
});
|
||||||
|
|
||||||
|
openAuthSection();
|
||||||
|
|
||||||
|
// Token input should be a password field
|
||||||
|
const tokenInput = screen.getByTestId("bearer-token-input");
|
||||||
|
expect(tokenInput).toHaveProperty("type", "password");
|
||||||
|
|
||||||
|
// Update the token
|
||||||
|
fireEvent.change(tokenInput, { target: { value: "new_token" } });
|
||||||
|
|
||||||
|
// Rerender with updated token
|
||||||
|
rerender(
|
||||||
|
<TooltipProvider>
|
||||||
|
<Sidebar
|
||||||
|
{...defaultProps}
|
||||||
|
bearerToken="new_token"
|
||||||
|
transportType="sse"
|
||||||
|
/>
|
||||||
|
</TooltipProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
// Token input should still exist after update
|
||||||
|
expect(screen.getByTestId("bearer-token-input")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should maintain token visibility state after update", () => {
|
||||||
|
const { rerender } = renderSidebar({
|
||||||
|
bearerToken: "existing_token",
|
||||||
|
transportType: "sse", // Set transport type to SSE
|
||||||
|
});
|
||||||
|
|
||||||
|
openAuthSection();
|
||||||
|
|
||||||
|
// Token input should be a password field
|
||||||
|
const tokenInput = screen.getByTestId("bearer-token-input");
|
||||||
|
expect(tokenInput).toHaveProperty("type", "password");
|
||||||
|
|
||||||
|
// Update the token
|
||||||
|
fireEvent.change(tokenInput, { target: { value: "new_token" } });
|
||||||
|
|
||||||
|
// Rerender with updated token
|
||||||
|
rerender(
|
||||||
|
<TooltipProvider>
|
||||||
|
<Sidebar
|
||||||
|
{...defaultProps}
|
||||||
|
bearerToken="new_token"
|
||||||
|
transportType="sse"
|
||||||
|
/>
|
||||||
|
</TooltipProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
// Token input should still exist after update
|
||||||
|
expect(screen.getByTestId("bearer-token-input")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should maintain header name when toggling auth section", () => {
|
||||||
|
renderSidebar({
|
||||||
|
headerName: "X-API-Key",
|
||||||
|
transportType: "sse",
|
||||||
|
});
|
||||||
|
|
||||||
|
// Open auth section
|
||||||
|
openAuthSection();
|
||||||
|
|
||||||
|
// Verify header name is displayed
|
||||||
|
const headerInput = screen.getByTestId("header-input");
|
||||||
|
expect(headerInput).toHaveValue("X-API-Key");
|
||||||
|
|
||||||
|
// Close auth section
|
||||||
|
const authButton = screen.getByTestId("auth-button");
|
||||||
|
fireEvent.click(authButton);
|
||||||
|
|
||||||
|
// Reopen auth section
|
||||||
|
fireEvent.click(authButton);
|
||||||
|
|
||||||
|
// Verify header name is still preserved
|
||||||
|
expect(screen.getByTestId("header-input")).toHaveValue("X-API-Key");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should display default header name when not specified", () => {
|
||||||
|
renderSidebar({
|
||||||
|
headerName: undefined,
|
||||||
|
transportType: "sse",
|
||||||
|
});
|
||||||
|
|
||||||
|
openAuthSection();
|
||||||
|
|
||||||
|
const headerInput = screen.getByTestId("header-input");
|
||||||
|
expect(headerInput).toHaveAttribute("placeholder", "Authorization");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("Configuration", () => {
|
||||||
|
const openConfigSection = () => {
|
||||||
|
const button = screen.getByTestId("config-button");
|
||||||
|
fireEvent.click(button);
|
||||||
|
};
|
||||||
|
|
||||||
|
it("should update MCP server request timeout", () => {
|
||||||
|
const setConfig = jest.fn();
|
||||||
|
renderSidebar({ config: DEFAULT_INSPECTOR_CONFIG, setConfig });
|
||||||
|
|
||||||
|
openConfigSection();
|
||||||
|
|
||||||
|
const timeoutInput = screen.getByTestId(
|
||||||
|
"MCP_SERVER_REQUEST_TIMEOUT-input",
|
||||||
|
);
|
||||||
|
fireEvent.change(timeoutInput, { target: { value: "5000" } });
|
||||||
|
|
||||||
|
expect(setConfig).toHaveBeenCalledWith(
|
||||||
|
expect.objectContaining({
|
||||||
|
MCP_SERVER_REQUEST_TIMEOUT: {
|
||||||
|
label: "Request Timeout",
|
||||||
|
description: "Timeout for requests to the MCP server (ms)",
|
||||||
|
value: 5000,
|
||||||
|
is_session_item: false,
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should update MCP server proxy address", () => {
|
||||||
|
const setConfig = jest.fn();
|
||||||
|
renderSidebar({ config: DEFAULT_INSPECTOR_CONFIG, setConfig });
|
||||||
|
|
||||||
|
openConfigSection();
|
||||||
|
|
||||||
|
const proxyAddressInput = screen.getByTestId(
|
||||||
|
"MCP_PROXY_FULL_ADDRESS-input",
|
||||||
|
);
|
||||||
|
fireEvent.change(proxyAddressInput, {
|
||||||
|
target: { value: "http://localhost:8080" },
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(setConfig).toHaveBeenCalledWith(
|
||||||
|
expect.objectContaining({
|
||||||
|
MCP_PROXY_FULL_ADDRESS: {
|
||||||
|
label: "Inspector Proxy Address",
|
||||||
|
description:
|
||||||
|
"Set this if you are running the MCP Inspector Proxy on a non-default address. Example: http://10.1.1.22:5577",
|
||||||
|
value: "http://localhost:8080",
|
||||||
|
is_session_item: false,
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should update max total timeout", () => {
|
||||||
|
const setConfig = jest.fn();
|
||||||
|
renderSidebar({ config: DEFAULT_INSPECTOR_CONFIG, setConfig });
|
||||||
|
|
||||||
|
openConfigSection();
|
||||||
|
|
||||||
|
const maxTotalTimeoutInput = screen.getByTestId(
|
||||||
|
"MCP_REQUEST_MAX_TOTAL_TIMEOUT-input",
|
||||||
|
);
|
||||||
|
fireEvent.change(maxTotalTimeoutInput, {
|
||||||
|
target: { value: "10000" },
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(setConfig).toHaveBeenCalledWith(
|
||||||
|
expect.objectContaining({
|
||||||
|
MCP_REQUEST_MAX_TOTAL_TIMEOUT: {
|
||||||
|
label: "Maximum Total Timeout",
|
||||||
|
description:
|
||||||
|
"Maximum total timeout for requests sent to the MCP server (ms) (Use with progress notifications)",
|
||||||
|
value: 10000,
|
||||||
|
is_session_item: false,
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should handle invalid timeout values entered by user", () => {
|
||||||
|
const setConfig = jest.fn();
|
||||||
|
renderSidebar({ config: DEFAULT_INSPECTOR_CONFIG, setConfig });
|
||||||
|
|
||||||
|
openConfigSection();
|
||||||
|
|
||||||
|
const timeoutInput = screen.getByTestId(
|
||||||
|
"MCP_SERVER_REQUEST_TIMEOUT-input",
|
||||||
|
);
|
||||||
|
fireEvent.change(timeoutInput, { target: { value: "abc1" } });
|
||||||
|
|
||||||
|
expect(setConfig).toHaveBeenCalledWith(
|
||||||
|
expect.objectContaining({
|
||||||
|
MCP_SERVER_REQUEST_TIMEOUT: {
|
||||||
|
label: "Request Timeout",
|
||||||
|
description: "Timeout for requests to the MCP server (ms)",
|
||||||
|
value: 0,
|
||||||
|
is_session_item: false,
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should maintain configuration state after multiple updates", () => {
|
||||||
|
const setConfig = jest.fn();
|
||||||
|
const { rerender } = renderSidebar({
|
||||||
|
config: DEFAULT_INSPECTOR_CONFIG,
|
||||||
|
setConfig,
|
||||||
|
});
|
||||||
|
|
||||||
|
openConfigSection();
|
||||||
|
// First update
|
||||||
|
const timeoutInput = screen.getByTestId(
|
||||||
|
"MCP_SERVER_REQUEST_TIMEOUT-input",
|
||||||
|
);
|
||||||
|
fireEvent.change(timeoutInput, { target: { value: "5000" } });
|
||||||
|
|
||||||
|
// Get the updated config from the first setConfig call
|
||||||
|
const updatedConfig = setConfig.mock.calls[0][0] as InspectorConfig;
|
||||||
|
|
||||||
|
// Rerender with the updated config
|
||||||
|
rerender(
|
||||||
|
<TooltipProvider>
|
||||||
|
<Sidebar
|
||||||
|
{...defaultProps}
|
||||||
|
config={updatedConfig}
|
||||||
|
setConfig={setConfig}
|
||||||
|
/>
|
||||||
|
</TooltipProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
// Second update
|
||||||
|
const updatedTimeoutInput = screen.getByTestId(
|
||||||
|
"MCP_SERVER_REQUEST_TIMEOUT-input",
|
||||||
|
);
|
||||||
|
fireEvent.change(updatedTimeoutInput, { target: { value: "3000" } });
|
||||||
|
|
||||||
|
// Verify the final state matches what we expect
|
||||||
|
expect(setConfig).toHaveBeenLastCalledWith(
|
||||||
|
expect.objectContaining({
|
||||||
|
MCP_SERVER_REQUEST_TIMEOUT: {
|
||||||
|
label: "Request Timeout",
|
||||||
|
description: "Timeout for requests to the MCP server (ms)",
|
||||||
|
value: 3000,
|
||||||
|
is_session_item: false,
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
|
||||||
|
|
@ -181,7 +181,7 @@ const createTransport = async (req: express.Request): Promise<Transport> => {
|
||||||
const transportType = query.transportType as string;
|
const transportType = query.transportType as string;
|
||||||
|
|
||||||
if (transportType === "stdio") {
|
if (transportType === "stdio") {
|
||||||
const command = query.command as string;
|
const command = (query.command as string).trim();
|
||||||
const origArgs = shellParseArgs(query.args as string) as string[];
|
const origArgs = shellParseArgs(query.args as string) as string[];
|
||||||
const queryEnv = query.env ? JSON.parse(query.env as string) : {};
|
const queryEnv = query.env ? JSON.parse(query.env as string) : {};
|
||||||
const env = { ...defaultEnvironment, ...process.env, ...queryEnv };
|
const env = { ...defaultEnvironment, ...process.env, ...queryEnv };
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue