refactor(web): sweep AGENTS.md TypeScript + Mantine rule violations (#1771)

Codebase-wide sweep bringing the web client into strict compliance with the AGENTS.md TypeScript and Mantine/React conventions: ~170 inline 2+-static-prop elements extracted to named .withProps() constants across ~77 files, the AGENTS.md rule wording tightened to match (static-prop boundary + Accordion/Transition/data-*/Box exemptions), a real ScreenStage Box->Flex layout regression fixed (direction: column) with a Storybook regression guard, and an App.tsx double-cast tightened. Closes #1762.
This commit is contained in:
Cliff Hall 2026-07-25 11:38:49 -04:00 • committed by GitHub
commit da37692485
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -142,6 +142,18 @@ const EmptyState = Text.withProps({
py: "xl",
});
// Centered loader/status column shown while a resource is being read.
const CenteredStatus = Stack.withProps({
align: "center",
py: "xl",
});
const ReadErrorAlert = Alert.withProps({
color: "red",
variant: "light",
title: "Read Error",
});
const SCROLL_MAX_HEIGHT =
"calc(100dvh - var(--app-shell-header-height, 0px) - var(--app-shell-footer-height, 0px) - var(--mantine-spacing-xl) * 2)";
@ -248,10 +260,10 @@ export function ResourcesScreen({
onClick={handleClosePreview}
/>
</Group>
<Stack align="center" py="xl">
<CenteredStatus>
<Loader size="sm" />
<Text c="dimmed">Reading resource...</Text>
</Stack>
</CenteredStatus>
</Stack>
</PreviewCard>
);
@ -267,9 +279,9 @@ export function ResourcesScreen({
onClick={handleClosePreview}
/>
</Group>
<Alert color="red" variant="light" title="Read Error">
<ReadErrorAlert>
{readState.error ?? "Failed to read resource"}
</Alert>
</ReadErrorAlert>
</Stack>
</PreviewCard>
);