Refactor renamed the component groups to something less obtuse:

Elements -> Groups -> Screens -> Views
This commit is contained in:
cliffhall 2026-03-28 12:58:47 -04:00
commit dd46acba87
2 changed files with 151 additions and 144 deletions

View file

@ -0,0 +1,77 @@
import type { Meta, StoryObj } from "@storybook/react-vite";
import { fn } from "storybook/test";
import { ServerSettingsForm } from "./ServerSettingsForm";
const meta: Meta<typeof ServerSettingsForm> = {
title: "Groups/ServerSettingsForm",
component: ServerSettingsForm,
args: {
onConnectionModeChange: fn(),
onAddHeader: fn(),
onRemoveHeader: fn(),
onHeaderChange: fn(),
onAddMetadata: fn(),
onRemoveMetadata: fn(),
onMetadataChange: fn(),
onTimeoutChange: fn(),
onOAuthChange: fn(),
},
};
export default meta;
type Story = StoryObj<typeof ServerSettingsForm>;
export const DefaultSettings: Story = {
args: {
connectionMode: "proxy",
headers: [],
metadata: [],
connectionTimeout: 30000,
requestTimeout: 60000,
},
};
export const WithHeaders: Story = {
args: {
connectionMode: "proxy",
headers: [
{ key: "Authorization", value: "Bearer token-abc-123" },
{ key: "X-Custom-Header", value: "custom-value" },
],
metadata: [],
connectionTimeout: 30000,
requestTimeout: 60000,
},
};
export const WithOAuth: Story = {
args: {
connectionMode: "direct",
headers: [],
metadata: [],
connectionTimeout: 30000,
requestTimeout: 60000,
oauthClientId: "my-client-id",
oauthClientSecret: "super-secret-value",
oauthScopes: "read write admin",
},
};
export const AllConfigured: Story = {
args: {
connectionMode: "proxy",
headers: [
{ key: "Authorization", value: "Bearer token-abc-123" },
{ key: "X-Request-Id", value: "req-456" },
],
metadata: [
{ key: "userId", value: "user-789" },
{ key: "sessionId", value: "session-012" },
],
connectionTimeout: 15000,
requestTimeout: 45000,
oauthClientId: "my-client-id",
oauthClientSecret: "super-secret-value",
oauthScopes: "read write",
},
};

View file

@ -0,0 +1,218 @@
import {
ActionIcon,
Button,
Divider,
Group,
NumberInput,
Select,
Stack,
Text,
TextInput,
Title,
} from "@mantine/core";
export interface KeyValuePair {
key: string;
value: string;
}
export interface ServerSettingsFormProps {
connectionMode: "proxy" | "direct";
headers: KeyValuePair[];
metadata: KeyValuePair[];
connectionTimeout: number;
requestTimeout: number;
oauthClientId?: string;
oauthClientSecret?: string;
oauthScopes?: string;
onConnectionModeChange: (mode: string) => void;
onAddHeader: () => void;
onRemoveHeader: (index: number) => void;
onHeaderChange: (index: number, key: string, value: string) => void;
onAddMetadata: () => void;
onRemoveMetadata: (index: number) => void;
onMetadataChange: (index: number, key: string, value: string) => void;
onTimeoutChange: (field: string, value: number) => void;
onOAuthChange: (field: string, value: string) => void;
}
const CONNECTION_MODE_OPTIONS = [
{ value: "proxy", label: "Via Proxy" },
{ value: "direct", label: "Direct" },
];
const RemoveIcon = ActionIcon.withProps({
color: "red",
variant: "subtle",
});
const AddButton = Button.withProps({
size: "xs",
variant: "light",
});
const HintText = Text.withProps({
size: "sm",
c: "dimmed",
});
const EmptyHint = Text.withProps({
size: "sm",
c: "dimmed",
fs: "italic",
});
function KeyValueRows({
items,
onChange,
onRemove,
}: {
items: KeyValuePair[];
onChange: (index: number, key: string, value: string) => void;
onRemove: (index: number) => void;
}) {
if (items.length === 0) {
return null;
}
return (
<>
{items.map((item, index) => (
<Group key={index} grow>
<TextInput
placeholder="Key"
value={item.key}
onChange={(e) => onChange(index, e.currentTarget.value, item.value)}
/>
<TextInput
placeholder="Value"
value={item.value}
onChange={(e) => onChange(index, item.key, e.currentTarget.value)}
/>
<RemoveIcon onClick={() => onRemove(index)}>X</RemoveIcon>
</Group>
))}
</>
);
}
export function ServerSettingsForm({
connectionMode,
headers,
metadata,
connectionTimeout,
requestTimeout,
oauthClientId,
oauthClientSecret,
oauthScopes,
onConnectionModeChange,
onAddHeader,
onRemoveHeader,
onHeaderChange,
onAddMetadata,
onRemoveMetadata,
onMetadataChange,
onTimeoutChange,
onOAuthChange,
}: ServerSettingsFormProps) {
const handleTimeoutChange = (field: string) => (value: number | string) => {
const numValue =
typeof value === "string" ? parseInt(value, 10) || 0 : value;
onTimeoutChange(field, numValue);
};
return (
<Stack gap="md">
<Title order={5}>Connection Mode</Title>
<Select
data={CONNECTION_MODE_OPTIONS}
value={connectionMode}
onChange={(value) => {
if (value) onConnectionModeChange(value);
}}
description={
connectionMode === "proxy"
? "Route through inspector proxy (required for STDIO)"
: undefined
}
/>
<Divider />
<Group justify="space-between">
<Title order={5}>Custom Headers</Title>
<AddButton onClick={onAddHeader}>+ Add Header</AddButton>
</Group>
<HintText>Headers sent with every HTTP request to this server</HintText>
{headers.length === 0 ? (
<EmptyHint>No custom headers configured</EmptyHint>
) : (
<KeyValueRows
items={headers}
onChange={onHeaderChange}
onRemove={onRemoveHeader}
/>
)}
<Divider />
<Group justify="space-between">
<Title order={5}>Request Metadata</Title>
<AddButton onClick={onAddMetadata}>+ Add Metadata</AddButton>
</Group>
<HintText>
Metadata sent with every MCP request (included in _meta field)
</HintText>
{metadata.length === 0 ? (
<EmptyHint>No request metadata configured</EmptyHint>
) : (
<KeyValueRows
items={metadata}
onChange={onMetadataChange}
onRemove={onRemoveMetadata}
/>
)}
<Divider />
<Title order={5}>Timeouts</Title>
<Group>
<NumberInput
label="Connection Timeout"
suffix=" ms"
value={connectionTimeout}
onChange={handleTimeoutChange("connectionTimeout")}
/>
<NumberInput
label="Request Timeout"
suffix=" ms"
value={requestTimeout}
onChange={handleTimeoutChange("requestTimeout")}
/>
</Group>
<Divider />
<Title order={5}>OAuth Settings</Title>
<HintText>
Pre-configure OAuth credentials for servers requiring authentication
</HintText>
<TextInput
label="Client ID"
value={oauthClientId ?? ""}
onChange={(e) => onOAuthChange("clientId", e.currentTarget.value)}
/>
<TextInput
label="Client Secret"
value={oauthClientSecret ?? ""}
type="password"
onChange={(e) => onOAuthChange("clientSecret", e.currentTarget.value)}
/>
<TextInput
label="Scopes"
value={oauthScopes ?? ""}
onChange={(e) => onOAuthChange("scopes", e.currentTarget.value)}
/>
</Stack>
);
}