modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

test(scripts): stop the repo-guard test depending on the ambient env

Browse source 
`main refuses to run without a repo` called `main(undefined, …)` so the default
parameter would fire, then asserted it throws. The default reads
`process.env.GITHUB_REPOSITORY` — which GitHub Actions sets on every run — so
the assertion held only where the variable happened to be unset. It passed
locally and failed CI, the one environment where the default is always
populated.

The test now clears the variable and restores it, and a second test covers the
other half of the default: with it set, `main(undefined, …)` uses it instead of
throwing. Between them the default's behavior is pinned in both environments
rather than inherited from whichever one is running.

Verified both ways: 14 pass with the variable unset and with it set, and the
full `test:scripts` suite is 411/411 under the CI environment shape.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RWMJENjs1mExXE5XPJTEei
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-03 22:20:15 -04:00 • committed by GitHub
commit ddf2307c4c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 37 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

38
scripts/dependency-refresh.test.mjs
View file

@ -228,5 +228,41 @@ test("main says Incoming, not Todo, when it files without a milestone", () => {
});
test("main refuses to run without a repo", () => {
assert.throws(() => main(undefined, fakeSpawn()), /GITHUB_REPOSITORY unset/);
// `main`'s default reads process.env.GITHUB_REPOSITORY, which GitHub Actions
// sets on every run — so this has to clear the variable rather than assume
// the ambient environment lacks it. Relying on the ambient value passed
// locally and failed in CI, which is the one place the default is always
// populated.
const saved = process.env.GITHUB_REPOSITORY;
delete process.env.GITHUB_REPOSITORY;
try {
assert.throws(
() => main(undefined, fakeSpawn()),
/GITHUB_REPOSITORY unset/,
);
} finally {
if (saved !== undefined) process.env.GITHUB_REPOSITORY = saved;
}
});
test("main falls back to GITHUB_REPOSITORY when no repo is passed", () => {
// The other half of the default: with the variable set, `main(undefined, …)`
// must use it rather than throw. Together the two tests pin the default's
// behavior in both environments instead of inheriting whichever one happens
// to be running.
const saved = process.env.GITHUB_REPOSITORY;
process.env.GITHUB_REPOSITORY = "env/repo";
try {
const spawn = fakeSpawn({
outdated: {
".": { ajv: { current: "8.0.0", wanted: "8.1.0", latest: "8.1.0" } },
},
});
captureLog(() => main(undefined, spawn));
const create = ghCall(spawn, "create");
assert.equal(create.args[create.args.indexOf("--repo") + 1], "env/repo");
} finally {
if (saved === undefined) delete process.env.GITHUB_REPOSITORY;
else process.env.GITHUB_REPOSITORY = saved;
}
});