fix: surface list-fetch failures in paginated mode (#1998)
#1954 wired the list-load error off the aggregate managed stores only. With `paginatedLists` on, those stores deliberately skip their all-page walk, so their error is permanently null — while the paged stores that actually drive the sidebar had no error state at all and `loadPage` had a try/finally with no catch. A failing list showed an empty panel with no alert and no Retry, and the connect-time `void loadPage(undefined)` left an unhandled rejection. - Give PagedTools/Prompts/ResourcesState observable error state: an `errorChange` event plus `getError()`, set in a new catch in `loadPage`, cleared on the next success and on disconnect. The rejection is still re-thrown, matching ManagedListState — callers' auth-recovery wrappers key off it to detect a 401. - Catch the connect-time load's rejection (`.catch(() => {})`) now that the failure is recorded as state rather than lost. - Select the error by mode in `usePaginatedList`, the same way `items` already is, and read it in App.tsx from the pagination model. - Rename `useManagedListError` to `useListError`: both store families expose an identical `errorChange`, so the hook declares that one-event contract itself instead of importing ManagedListEventMap. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177mPHAdECD18nLLCTwR5rh Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
885228699e
commit
de60983ccc
1 changed files with 523 additions and 42 deletions
|
|
@ -7,6 +7,7 @@ import type {
|
|||
} from "../mcp/state/pagedToolsState.js";
|
||||
import type { Tool } from "@modelcontextprotocol/client";
|
||||
import type { TypedEventGeneric } from "../mcp/typedEventTarget.js";
|
||||
import { useListError } from "./useListError.js";
|
||||
|
||||
export interface UsePagedToolsResult {
|
||||
tools: Tool[];
|
||||
|
|
@ -14,6 +15,12 @@ export interface UsePagedToolsResult {
|
|||
nextCursor?: string;
|
||||
/** Pages loaded since the last reset (page 1 = 1). */
|
||||
pageCount: number;
|
||||
/**
|
||||
* The last page load's failure, or `null` when it succeeded. In paginated
|
||||
* mode this store is the display source, so this — not the managed
|
||||
* store's error — is what the panel renders (#1998).
|
||||
*/
|
||||
error: Error | null;
|
||||
loadPage: (cursor?: string) => Promise<LoadPageResult>;
|
||||
clear: () => void;
|
||||
}
|
||||
|
|
@ -68,6 +75,8 @@ export function usePagedTools(
|
|||
};
|
||||
}, [pagedToolsState]);
|
||||
|
||||
const error = useListError(pagedToolsState);
|
||||
|
||||
const loadPage = useCallback(
|
||||
async (cursor?: string): Promise<LoadPageResult> => {
|
||||
if (!pagedToolsState || !client) {
|
||||
|
|
@ -82,5 +91,5 @@ export function usePagedTools(
|
|||
pagedToolsState?.clear();
|
||||
}, [pagedToolsState]);
|
||||
|
||||
return { tools, nextCursor, pageCount, loadPage, clear };
|
||||
return { tools, nextCursor, pageCount, error, loadPage, clear };
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue