Same fix as #1698, applied to the Connection Info modal, which had the same pattern: a custom header Group (title + close) inside a Stack in the modal body, using the default `<Modal>` with no `scrollAreaComponent`. With a long server `instructions` section (e.g. the everything server) the details overflow the viewport and the whole modal scrolled, taking the header out of view. Switch to the compound `Modal.Root`/`Content`/`Header`/`Body` API, move the header into `Modal.Header` (sticky by design) and set `scrollAreaComponent={ScrollArea.Autosize}` so only the body scrolls. The fade-down transition is supplied app-wide by `ThemeModalRoot` (added in #1753), so no `transitionProps` literal is needed here. Closes #1754 Claude-Session: https://claude.ai/code/session_01XNdjEPKLG637X8YmhDiEk5 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
092165476e
commit
e788bcbaca
3 changed files with 53 additions and 21 deletions
|
|
@ -1,3 +1,25 @@
|
|||
# Connection Info modal: sticky header while body scrolls (#1754) — proof screenshots
|
||||
|
||||
Same fix as #1698, applied to the **Connection Info** modal. With a real server
|
||||
whose `instructions` are long (e.g. the everything server in a typical config),
|
||||
the connection details overflow the viewport; before the fix the whole modal
|
||||
scrolled and the header left the view. Captured from the `ConnectionInfoModal`
|
||||
Storybook story (`WithOAuth`, ~620px viewport) via Playwright.
|
||||
|
||||

|
||||
|
||||
Top of scroll: the **Connection Info** header (title + close) sits above the
|
||||
first section.
|
||||
|
||||

|
||||
|
||||
Scrolled down (now showing Server Instructions → OAuth Details): the **same
|
||||
header stays pinned**. Measured in-page: the body scroll container is
|
||||
`scrollHeight` 1172 × `clientHeight` 558 (scrolls internally), header
|
||||
`position: sticky` flush to the dialog top.
|
||||
|
||||
---
|
||||
|
||||
# Server/Client Settings modal: sticky header while body scrolls (#1698) — proof screenshots
|
||||
|
||||
Expanding enough accordion sections grew the Server Settings modal past the
|
||||
|
|
|
|||
BIN
pr-screenshots/ci-1754-header-pinned-scrolled.png
Normal file
BIN
pr-screenshots/ci-1754-header-pinned-scrolled.png
Normal file
Binary file not shown.
|
After Width: | Height: | Size: 39 KiB |
BIN
pr-screenshots/ci-1754-header-pinned-top.png
Normal file
BIN
pr-screenshots/ci-1754-header-pinned-top.png
Normal file
Binary file not shown.
|
After Width: | Height: | Size: 39 KiB |
Loading…
Reference in a new issue