fix: bound every header string, and make scrollable panels keyboard-reachable (#2263)
Copilot review round 8: the skill URI was still unbounded in the pane's fixed
header. It is the fourth instance of a pattern named in this PR's own round-7
reply — anything server-controlled and variable-height that sits beside the
zero-basis accordion sizes the layout — and it was directly above the
description clamped last round, which says something about naming a class not
being the same as sweeping for it.
So this audits the whole header rather than the reported element. All three
server-controlled strings are now bounded: the name truncates (already did),
the URI clamps to two lines, the description to three, and both clamps carry
the full value on a `title`. `HostileHeader` asserts the class is closed — a
long name, a 30-segment URI and a 400-word description, with the accordion
still taking more than half the card, every section non-zero, and the pane not
scrolling.
That new story then caught an accessibility defect this refactor introduced and
would otherwise have shipped: `scrollable-region-focusable`. Making each panel
its own scroll container means a panel whose content holds no focusable element
— the Conformance alerts, for instance — cannot be scrolled by keyboard at all.
Every `Accordion.Panel` now carries `tabIndex={0}`.
The geometric assertion lives in Storybook rather than the unit test, because a
CSS bound is not observable through happy-dom's `getComputedStyle`; the unit
test pins the contract that makes clamping safe instead — the full value stays
reachable on a `title`.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R4441JdNLZerCVM7mDDSfB
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
52e8e1b557
commit
e8bbcf115a
1 changed files with 146 additions and 17 deletions
|
|
@ -362,6 +362,47 @@ describe("SkillsScreen", () => {
|
|||
);
|
||||
});
|
||||
|
||||
it("bounds every server-controlled string in the fixed header", async () => {
|
||||
// The header sits beside an accordion whose flex-basis is 0, so anything
|
||||
// unbounded here is subtracted from the sections rather than resisted by
|
||||
// them. This has been the same bug three times over (#2263) — the viewer's
|
||||
// content-sized basis, the `skills/get` region, the description — so this
|
||||
// asserts the *class* is closed rather than chasing one more instance.
|
||||
const user = userEvent.setup();
|
||||
const hostile: SkillEntry = {
|
||||
uri: `skill://${"very-long-segment/".repeat(40)}SKILL.md`,
|
||||
frontmatter: {
|
||||
name: "x".repeat(300),
|
||||
// SEP-2640 permits 1,024 characters here.
|
||||
description: "word ".repeat(400).trim(),
|
||||
},
|
||||
resources: [
|
||||
{
|
||||
uri: `skill://${"very-long-segment/".repeat(40)}SKILL.md`,
|
||||
digest: SELF_DIGEST,
|
||||
size: textToBytes(SELF_TEXT).byteLength,
|
||||
},
|
||||
],
|
||||
};
|
||||
renderWithMantine(<ControlledSkillsScreen skills={[hostile]} />);
|
||||
await user.click(screen.getAllByText("x".repeat(300))[0]);
|
||||
|
||||
// The *geometric* bound is a CSS concern and belongs in a real browser —
|
||||
// `HostileHeader` in the stories asserts the header cannot starve the
|
||||
// accordion. What is worth pinning here is the contract that makes
|
||||
// clamping safe: the full value stays reachable on a `title`, so nothing
|
||||
// is actually hidden from the user.
|
||||
expect(screen.getByTitle(hostile.uri)).toBeInTheDocument();
|
||||
expect(
|
||||
screen.getByTitle(hostile.frontmatter.description as string),
|
||||
).toBeInTheDocument();
|
||||
// And the header still shows all three, rather than dropping any.
|
||||
const detail = screen.getByTestId("skill-detail");
|
||||
expect(detail.textContent).toContain("xxxx");
|
||||
expect(detail.textContent).toContain("skill://very-long-segment");
|
||||
expect(detail.textContent).toContain("word word");
|
||||
});
|
||||
|
||||
it("badges a warning-only entry yellow, not green", async () => {
|
||||
// Green reads as "nothing to see", which would hide the only signal the
|
||||
// section carries for an entry whose findings are all warnings (#2263).
|
||||
|
|
|
|||
Loading…
Reference in a new issue