chore(web): extract App.tsx's OAuth recovery cluster into useOAuthRecovery (#2153)
Phase 2 step 2 of the App.tsx decomposition (#2129, under #2126). App.tsx goes from 4,267 to 3,178 lines; no behaviour change. The new hook owns the step-up slot and its retry operation, the re-auth banner, the deferred background-tab recovery, the redirect plumbing (webOAuthStorage, sessionStorageAdapter, onBeforeOAuthRedirect, prepareOAuthRedirect), the command-scoped recovery wrappers, the four OAuth effects, the abandoned-redirect check, the /oauth/callback completion, the Connection Info OAuth details, and the clear/finalize paths. All five once-only latches move with it unchanged. Three seams could not be a straight move: - useSessionRef no longer takes pendingStepUp/pendingReauth. They are this hook's own state, so App.tsx would have had to hold them purely to hand them back; instead the owner mirrors them into the ref in an effect of its own, following the shape activeServerName already had. - setupClientForServer is injected through a ref, because it reads onBeforeOAuthRedirect and sessionStorageAdapter out of this hook and so cannot be declared before it. The callback effect reads the ref before burning its one-shot latch. - The two clear-OAuth modal adapters and onReauthenticateFromBanner stay in App.tsx: they bind App-owned state, and the latter drives a reconnect, which step 3 owns. Dropping ~1,100 lines took App.tsx under the React Compiler's bail-out, so the compiler-backed react-hooks rules now analyse it and report nine pre-existing findings that were previously invisible. Each is suppressed with a narrow justified disable naming #2161, which is filed to resolve them; the one new finding (exhaustive-deps on setReAuthBanner) is fixed rather than suppressed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hzwzS8UvBsr4yZm7o7sev Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
6c9c149406
commit
ed38a5e5fe
1 changed files with 2962 additions and 1237 deletions
File diff suppressed because it is too large
Load diff
Loading…
Reference in a new issue