From edab149d5b2bd90aa769382521e27d6ca35ff5e6 Mon Sep 17 00:00:00 2001 From: cliffhall Date: Sun, 6 Sep 2026 12:17:31 -0400 Subject: [PATCH] docs: name the two smokes that set 1280x900, not a wildcard MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Copilot review round 2 on #2271: `scripts/smoke-web-*.mjs` overclaimed — smoke-web-app.mjs and smoke-web-browser.mjs create pages with no viewport at all, so only the tabs and elicitation smokes back the number. Name those two explicitly and say the other two set none. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_017nLLLTGc37hQiC8s3mNyhq Signed-off-by: cliffhall --- .claude/skills/pr-flow/SKILL.md | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.claude/skills/pr-flow/SKILL.md b/.claude/skills/pr-flow/SKILL.md index 8cde16b8..af6093a6 100644 --- a/.claude/skills/pr-flow/SKILL.md +++ b/.claude/skills/pr-flow/SKILL.md @@ -114,11 +114,13 @@ the web client. A **TUI** change has no viewport and no `fullPage` mode: size the terminal so no line wraps or truncates, and go straight to 5b, which applies to every image regardless of how it was taken. -**Shoot the web client at 1280×900, full page.** That is the viewport the web -smokes already use (`scripts/smoke-web-*.mjs`), and adopting it as the standard -here is what makes a reviewer comparing two PRs compare the same thing — the -older shots checked into `specification/screenshots/` were taken at assorted -sizes, which is the problem, not the precedent. Prefer a full-page shot over a +**Shoot the web client at 1280×900, full page.** It is the one size already +written down anywhere in the repo — `scripts/smoke-web-tabs.mjs` and +`scripts/smoke-web-elicitation.mjs` set exactly that viewport (the other two web +smokes set none) — and adopting it as the standard here is what makes a reviewer +comparing two PRs compare the same thing. The older shots checked into +`specification/screenshots/` were taken at assorted sizes, which is the problem, +not the precedent. Prefer a full-page shot over a Playwright `clip` region: a clip sized to one panel cuts off anything placed beside it, and two clips of different sizes make a before/after pair hard to read as a pair.