fix: guard the automatic read, and reset panel scroll on skill change (#2263)
Copilot review round 11: zero inline comments, two findings in the suppressed block. Third round where the inline count alone would have ended the cycle. The automatic SKILL.md read fired twice. I noted this possibility early and dismissed it as harmless dev noise, which was wrong twice over: `ScreenStage` remounts this screen while the selection persists, so it is not dev-only, and this app is a protocol inspector — a phantom `resources/read` in the Protocol panel that the user's own client would never send is the tool misreporting the conversation, not merely a wasted round trip. An `autoReadKey` ref makes the replay a no-op. Panel scroll positions survived a skill change. `scrollTop` lives on the DOM node rather than in React state, so switching between two long manifests showed the new one part-way down with its first rows hidden, which reads as missing data. The accordion is keyed by `manifestKey` so every panel gets a fresh scroll container; `openSections` is controlled and survives. ⚠️ The test for the first fix is a SPECIFICATION, not a regression guard, and is labelled as such in the file. It was written, then checked by removing the guard — and it still passed. Three shapes were tried (a plain re-render, a StrictMode wrapper, StrictMode with the selection present at mount) and none reproduce the replay, because this environment does not double-invoke mount effects. The fix stands on the reported reasoning; the test pins the contract of one read per selection and must not be read as evidence the defect is fixed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R4441JdNLZerCVM7mDDSfB Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
parent
10c8f5deb3
commit
ede9658d62
1 changed files with 68 additions and 3 deletions
|
|
@ -906,8 +906,23 @@ export function SkillsScreen({
|
|||
// with identical content.
|
||||
const selectedUri = selected?.uri;
|
||||
|
||||
// Which manifest the automatic read has already been issued for.
|
||||
//
|
||||
// A ref rather than state, because this must not itself cause a render — and
|
||||
// it is what stops the read being issued twice for one selection. React
|
||||
// StrictMode deliberately replays effects (`main.tsx` renders under it), and
|
||||
// `ScreenStage` remounts this screen while the selected-skill UI state
|
||||
// persists, so without a guard both paths fire a second identical
|
||||
// `resources/read`. In an app whose whole purpose is showing people the
|
||||
// protocol traffic, an extra request in the Protocol panel that the user's
|
||||
// own client would never send is worse than a wasted round trip: it is the
|
||||
// Inspector misreporting the conversation.
|
||||
const autoReadKey = useRef<string | null>(null);
|
||||
|
||||
useEffect(() => {
|
||||
if (selectedUri === undefined) return;
|
||||
if (autoReadKey.current === manifestKey) return;
|
||||
autoReadKey.current = manifestKey;
|
||||
showResource(selectedUri, manifestKey);
|
||||
}, [manifestKey, selectedUri, showResource]);
|
||||
|
||||
|
|
@ -1223,6 +1238,14 @@ export function SkillsScreen({
|
|||
focusable element (the Conformance alerts, for instance) is
|
||||
otherwise unscrollable without a pointer. */}
|
||||
<Accordion
|
||||
// Keyed by the manifest so a skill change gives every panel a
|
||||
// FRESH scroll container. `scrollTop` lives on the DOM node, not
|
||||
// in React state, so reusing these panels carried one skill's
|
||||
// scroll position into the next — switching between two long
|
||||
// manifests showed the new one part-way down with its first rows
|
||||
// hidden, which reads as missing data rather than as scroll.
|
||||
// `openSections` is controlled, so it survives the remount.
|
||||
key={manifestKey}
|
||||
multiple
|
||||
variant="skillSections"
|
||||
chevron={<RiArrowRightSLine />}
|
||||
|
|
|
|||
Loading…
Reference in a new issue