Apply suggestions from code review
Co-authored-by: John McBride <jpmmcbride@gmail.com>
This commit is contained in:
parent
652027dd7a
commit
ef6d84933a
2 changed files with 4 additions and 5 deletions
1
.github/workflows/main.yml
vendored
1
.github/workflows/main.yml
vendored
|
|
@ -95,6 +95,7 @@ jobs:
|
||||||
with:
|
with:
|
||||||
context: .
|
context: .
|
||||||
push: true
|
push: true
|
||||||
|
platforms: linux/amd64,linux/arm64
|
||||||
tags: ${{ steps.meta.outputs.tags }}
|
tags: ${{ steps.meta.outputs.tags }}
|
||||||
labels: ${{ steps.meta.outputs.labels }}
|
labels: ${{ steps.meta.outputs.labels }}
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -14,12 +14,10 @@ RUN npm install --no-package-lock
|
||||||
# Build the application
|
# Build the application
|
||||||
RUN npm run build
|
RUN npm run build
|
||||||
|
|
||||||
ENV CLIENT_PORT=6274
|
ARG CLIENT_PORT=6274
|
||||||
ENV SERVER_PORT=6277
|
ARG SERVER_PORT=6277
|
||||||
|
|
||||||
# Expose the CLIENT_PORT and SERVER_PORT
|
EXPOSE ${CLIENT_PORT} ${SERVER_PORT}
|
||||||
EXPOSE $CLIENT_PORT
|
|
||||||
EXPOSE $SERVER_PORT
|
|
||||||
|
|
||||||
# Use ENTRYPOINT with CMD for arguments
|
# Use ENTRYPOINT with CMD for arguments
|
||||||
ENTRYPOINT ["npm", "start"]
|
ENTRYPOINT ["npm", "start"]
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue