modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: surface list-fetch failures instead of swallowing them

Browse source 
A list load that failed — a transport error, or a result the SDK's era
codec rejects as invalid — reported nothing. The connect-time refresh is
fired with no caller to await it (`void this.refresh()`), so its rejection
became an unhandled rejection: the header said "Connected", the panel
rendered an empty list indistinguishable from a server that has none, and
the failed exchange showed in the Protocol panel as a clean success.

Two surfaces now tell the truth:

- ManagedListState records the failure as observable state (`getError` +
  an `errorChange` event) and still re-throws, so App's auth-recovery
  wrapper keeps working. The four `useManaged*` hooks expose it via a
  shared `useManagedListError`, and the Tools/Prompts/Resources sidebars
  render a `ListLoadError` alert with the reason and a Retry.
- A response the client refused is attributed back to its Protocol entry
  (`markResponseRejected` → `responseRejected` → `MessageEntry.clientError`),
  which now renders an Error status and a "Rejected by the Inspector"
  alert rather than the green resultType badge alone. The SDK gives no
  request id with a decode failure, so the id is recovered by correlation;
  see the comment on `markResponseRejected` for why that is exact.

Also stops `listAllTools` from dropping a failing excluded-tools walk on
the floor — it stays non-fatal but is logged.

Closes #1953

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SW1p8E2uiyyLx4RKwrwSrt
This commit is contained in:
cliffhall 2026-08-08 16:48:48 -04:00
commit f201032137
1 changed files with 1080 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

11
core/react/useManagedTools.ts
View file

@ -4,8 +4,15 @@ import type { ManagedToolsState } from "../mcp/state/managedToolsState.js";
import type { ManagedToolsStateEventMap } from "../mcp/state/managedToolsState.js";
import type { Tool } from "@modelcontextprotocol/client";
import type { TypedEventGeneric } from "../mcp/typedEventTarget.js";
import { useManagedListError } from "./useManagedListError.js";
export interface UseManagedToolsResult {
/**
* The last fetch's failure (transport error, or a result the SDK codec
* rejected), or `null` when it succeeded. Includes the connect-time load,
* whose failure has no caller to surface it (#1953).
*/
error: Error | null;
tools: Tool[];
/** True when a `tools/list_changed` arrived since the last user refresh. */
listChanged: boolean;
@ -65,6 +72,8 @@ export function useManagedTools(
};
}, [managedToolsState]);
const error = useManagedListError(managedToolsState);
const refresh = useCallback(async (): Promise<Tool[]> => {
if (!managedToolsState || !client) return [];
// A user-initiated refresh acknowledges the change — clear the indicator
@ -85,5 +94,5 @@ export function useManagedTools(
managedToolsState?.clearListChanged();
}, [managedToolsState]);
return { tools, listChanged, refresh, clearListChanged };
return { tools, error, listChanged, refresh, clearListChanged };
}