test: close ≥90% per-file coverage gaps for mid-session auth

The mid-session auth work passed `validate`/CI but failed the local-only
`npm run test:coverage` per-file gate (≥90% lines/statements/functions/
branches) on 12 files. Add targeted unit/integration tests so every changed
file clears the gate; annotate provably-dead defensive branches with justified
`/* v8 ignore */` comments rather than relaxing the gate.

Files brought to ≥90 on all four dimensions:
- core/auth: mcpAuth, oauthUx, utils, challenge, node/runner-interactive-oauth
- core/mcp: oauthManager, inspectorClient, node/authChallengeFetch,
  remote/remoteClientTransport, remote/node/{remote-session,server}
- clients/web/src/utils: oauthResume, browserTabVisibility

`npm run test:coverage` now passes (3575 tests, 0 threshold failures);
`npm run validate` green across all four clients.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DZyeWManYTvcXxjcrhxSQc
This commit is contained in:
cliffhall 2026-07-03 12:54:37 -04:00
commit f4b6095719
2 changed files with 3447 additions and 37 deletions

View file

@ -2042,10 +2042,8 @@ export function createRemoteApp(
// deliberate side-effect of using `readMcpConfig` + full rewrite
// here.
const existing = current.mcpServers[originalId];
/* v8 ignore next 5 -- the `in` check above guarantees this branch is unreachable; narrowing without the non-null assertion keeps TS happy and makes the contract explicit for future refactors. */
if (!existing) {
// The `in` check above guarantees this branch is unreachable;
// narrowing without the non-null assertion keeps TS happy and
// makes the contract explicit for future refactors.
return c.json({ error: `Server '${originalId}' not found` }, 404);
}
// Split the existing entry into its SDK-only config (no Inspector-

View file

@ -103,7 +103,10 @@ function requestIdForMessage(
function isConnectAuthChallenge(
json: RemoteConnectResponse,
): json is Extract<RemoteConnectResponse, { ok: false; kind: "auth_challenge" }> {
): json is Extract<
RemoteConnectResponse,
{ ok: false; kind: "auth_challenge" }
> {
return (
typeof json === "object" &&
json !== null &&
@ -116,7 +119,10 @@ function isConnectAuthChallenge(
function isConnectTransportError(
json: RemoteConnectResponse,
): json is Extract<RemoteConnectResponse, { ok: false; kind: "transport_error" }> {
): json is Extract<
RemoteConnectResponse,
{ ok: false; kind: "transport_error" }
> {
return (
typeof json === "object" &&
json !== null &&
@ -212,7 +218,10 @@ export class RemoteClientTransport implements Transport {
private eventStreamConsumeTask: Promise<void> | null = null;
private restartingEventStream = false;
private closed = false;
private readonly sseResponseWaits = new Map<string | number, SseResponseWait>();
private readonly sseResponseWaits = new Map<
string | number,
SseResponseWait
>();
private readonly options: RemoteTransportOptions;
private readonly config: import("../types.js").MCPServerConfig;
@ -287,10 +296,7 @@ export class RemoteClientTransport implements Transport {
): Promise<void> {
const recovery = this.options.authRecovery;
if (!recovery) {
throw new AuthChallengeError(
challenge,
challenge.raw?.httpStatus ?? 401,
);
throw new AuthChallengeError(challenge, challenge.raw?.httpStatus ?? 401);
}
const outcome = await recovery.handleAuthChallenge(challenge);
@ -536,7 +542,9 @@ export class RemoteClientTransport implements Transport {
if (!res.ok) {
const text = await res.text();
throw new Error(`Remote auth-state update failed (${res.status}): ${text}`);
throw new Error(
`Remote auth-state update failed (${res.status}): ${text}`,
);
}
const json = (await res.json()) as { ok?: boolean; error?: string };