Forward RFC 9207 iss to the v2 SDK (fixes OAuth + EMA leg 1)

SDK v2 added RFC 9207 §2.4 authorization-response issuer validation
(`validateAuthorizationResponseIssuer` / `IssuerMismatchError`) as a mix-up
attack defense. It is strict: when AS metadata advertises
`authorization_response_iss_parameter_supported: true` and no `iss` reaches
`exchangeAuthorization`/`auth()`, the exchange throws.

v1.29.0 had no `iss` parameter and no RFC 9207 validation at all, so dropping
the callback `iss` was harmless. The migration swapped in the stricter SDK
without feeding it the new input, breaking the authorization-code exchange
against any RFC 9207 authorization server (Okta/xaa.dev advertise it):

    Issuer mismatch in authorization response (RFC 9207):
    expected "https://idp.xaa.dev", received undefined

Found by smoke-testing EMA against live xaa.dev staging; not caught by CI
because the mock IdP never advertised the parameter, so the SDK took its
lenient path (a missing `iss` is only fatal when advertised).

`iss` was dropped in three places, with the plumbing half-built —
`oauthManager`/`inspectorClient` already accepted `iss`, but nothing supplied
or forwarded it:

- `parseOAuthCallbackParams` never extracted `iss` from the callback query
- `mcpAuth` never forwarded `options.iss` to SDK `auth()` — its own comment
  ("forwarded on v2 upgrade; ignored by v1 SDK auth()") predicted this exact
  gap, so standard OAuth was broken identically, not just EMA
- EMA leg 1 (`completeIdpOidcAuthorization`) never passed `iss` to
  `exchangeAuthorization`

Thread `iss` end to end: callback query -> CallbackParams -> resumeAfterOAuth
-> completeOAuthFlow -> {mcpAuth | EMA leg 1} -> SDK. The Node callback server
and runner carry it for CLI/TUI.

Tests: `ema-mock-servers.ts` now advertises
`authorization_response_iss_parameter_supported: true` so the mock is at least
as strict as real IdPs — with it absent the SDK silently takes the lenient path
and a dropped `iss` goes unnoticed. Flipping it made three existing tests
reproduce the failure. Adds regression coverage for forwarding and for
rejecting a mismatched `iss` before any network call.

Verified end to end against live xaa.dev staging: EMA legs 1-3 (IdP SSO ->
ID-JAG mint -> resource token) now complete and the MCP session initializes.

web 3099, cli 212, tui 274 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VjMemXZohSR2EndBQYif2b

clients/web/src/test/core/auth/ema/emaFlow.test.ts

@@ -381,6 +381,7 @@ describe("emaFlow", () => {
     const tokens = await completeEmaIdpAuthorizationAndMint(
       config,
       "auth-code",
+      IDP_ISSUER,
     );
 
     expect(tokens.access_token).toBe("resource-access-token");
@@ -415,7 +416,7 @@ describe("emaFlow", () => {
     await startEmaIdpAuthorization(config);
 
     await expect(
-      completeEmaIdpAuthorizationAndMint(config, "auth-code"),
+      completeEmaIdpAuthorizationAndMint(config, "auth-code", IDP_ISSUER),
     ).rejects.toThrow(/EMA legs 2–3 \(resource token mint\)/);
   });
 
@@ -480,7 +481,7 @@ describe("emaFlow", () => {
     });
 
     await expect(
-      completeEmaIdpAuthorizationAndMint(config, "auth-code"),
+      completeEmaIdpAuthorizationAndMint(config, "auth-code", IDP_ISSUER),
     ).rejects.toThrow(
       "EMA leg 1 (IdP authorization code exchange): leg1-non-error",
     );

clients/web/src/test/core/auth/ema/idpOidc.test.ts

@@ -390,6 +390,7 @@ describe("completeIdpOidcAuthorization", () => {
     const result = await completeIdpOidcAuthorization({
       idp,
       authorizationCode: "auth-code-xyz",
+      iss: IDP_ISSUER,
       redirectUrl: "http://127.0.0.1:3000/oauth/callback",
       storage,
       fetchFn,
@@ -465,6 +466,7 @@ describe("completeIdpOidcAuthorization", () => {
     const result = await completeIdpOidcAuthorization({
       idp,
       authorizationCode: "code",
+      iss: IDP_ISSUER,
       redirectUrl: "http://127.0.0.1:3000/oauth/callback",
       storage,
       fetchFn,
@@ -498,10 +500,67 @@ describe("completeIdpOidcAuthorization", () => {
       completeIdpOidcAuthorization({
         idp,
         authorizationCode: "code",
+        iss: IDP_ISSUER,
         redirectUrl: "http://127.0.0.1:3000/oauth/callback",
         storage,
         fetchFn,
       }),
     ).rejects.toThrow("IdP token response did not include an ID Token");
   });
+
+  // Regression: the IdP metadata advertises
+  // `authorization_response_iss_parameter_supported`, so the SDK enforces
+  // RFC 9207 §2.4 and rejects the exchange unless the callback `iss` is
+  // forwarded. Dropping `iss` anywhere between the callback and
+  // `exchangeAuthorization` breaks EMA leg 1 against every real IdP.
+  it("forwards the callback iss to the token exchange (RFC 9207)", async () => {
+    storage = buildStorage();
+    const idToken = jwtWithExp(Math.floor(Date.now() / 1000) + 3600);
+    const fetchFn = vi.fn(
+      async () =>
+        new Response(
+          JSON.stringify({
+            id_token: idToken,
+            access_token: "at",
+            token_type: "Bearer",
+          }),
+        ),
+    );
+
+    await expect(
+      completeIdpOidcAuthorization({
+        idp,
+        authorizationCode: "code",
+        redirectUrl: "http://127.0.0.1:3000/oauth/callback",
+        storage,
+        fetchFn,
+      }),
+    ).rejects.toThrow(/Issuer mismatch/);
+
+    const result = await completeIdpOidcAuthorization({
+      idp,
+      authorizationCode: "code",
+      iss: IDP_ISSUER,
+      redirectUrl: "http://127.0.0.1:3000/oauth/callback",
+      storage,
+      fetchFn,
+    });
+    expect(result.idToken).toBe(idToken);
+  });
+
+  it("rejects a callback iss from a different issuer (mix-up defense)", async () => {
+    storage = buildStorage();
+    const fetchFn = vi.fn();
+    await expect(
+      completeIdpOidcAuthorization({
+        idp,
+        authorizationCode: "code",
+        iss: "https://evil.example.com",
+        redirectUrl: "http://127.0.0.1:3000/oauth/callback",
+        storage,
+        fetchFn,
+      }),
+    ).rejects.toThrow(/Issuer mismatch/);
+    expect(fetchFn).not.toHaveBeenCalled();
+  });
 });

clients/web/src/test/core/auth/runner-interactive-oauth.test.ts

@@ -56,15 +56,21 @@ function createMockCallbackServer(handlers: {
   } as unknown as OAuthCallbackServer;
 }
 
-/** Drive the loopback callback the way a browser redirect would. */
+const CALLBACK_ISS = "https://as.example";
+
+/**
+ * Drive the loopback callback the way a browser redirect would, including the
+ * RFC 9207 `iss` that real authorization servers send.
+ */
 async function simulateCallback(
   handlers: MockCallbackHandlers,
   code = "auth-code-123",
+  iss: string | undefined = CALLBACK_ISS,
 ): Promise<void> {
   if (!handlers.onCallback) {
     throw new Error("onCallback not registered");
   }
-  await handlers.onCallback({ code });
+  await handlers.onCallback({ code, iss });
 }
 
 describe("runRunnerInteractiveOAuth", () => {
@@ -145,7 +151,10 @@ describe("runRunnerInteractiveOAuth", () => {
     });
 
     expect(result).toEqual({ kind: "success" });
-    expect(client.completeOAuthFlow).toHaveBeenCalledWith("auth-code-123");
+    expect(client.completeOAuthFlow).toHaveBeenCalledWith(
+      "auth-code-123",
+      CALLBACK_ISS,
+    );
     expect(redirectUrlProvider.redirectUrl).toBe(
       "http://127.0.0.1:6276/oauth/callback",
     );
@@ -179,7 +188,10 @@ describe("runRunnerInteractiveOAuth", () => {
       authorizationUrl,
     );
     expect(client.authenticate).not.toHaveBeenCalled();
-    expect(client.completeOAuthFlow).toHaveBeenCalledWith("step-up-code");
+    expect(client.completeOAuthFlow).toHaveBeenCalledWith(
+      "step-up-code",
+      CALLBACK_ISS,
+    );
   });
 
   it("returns insufficient_scope when post-step-up check fails", async () => {

clients/web/src/test/core/mcp/oauthManager.test.ts

@@ -1525,11 +1525,12 @@ describe("OAuthManager", () => {
       );
       expect(outcome.kind).toBe("interactive");
 
-      await manager.completeOAuthFlow("auth-code");
+      await manager.completeOAuthFlow("auth-code", "https://idp.example.com");
 
       expect(mintSpy).toHaveBeenCalledWith(
         expect.objectContaining({ scope: "mcp tools:read weather:read" }),
         "auth-code",
+        "https://idp.example.com",
       );
       expect(storageOf(params).saveScope).toHaveBeenCalledWith(
         SERVER_URL,

clients/web/src/test/integration/mcp/ema-mock-servers.ts

@@ -21,7 +21,15 @@ export const EMA_MOCK_IDP_CLIENT_SECRET = "ema-mock-idp-secret";
 export const EMA_MOCK_RESOURCE_CLIENT_ID = "ema-mock-resource-client";
 export const EMA_MOCK_RESOURCE_CLIENT_SECRET = "ema-mock-resource-secret";
 
-/** Fields required by SDK `OAuthMetadataSchema` for discovery in tests. */
+/**
+ * Fields required by SDK `OAuthMetadataSchema` for discovery in tests.
+ *
+ * `authorization_response_iss_parameter_supported` mirrors real-world IdPs
+ * (e.g. Okta/xaa.dev): once advertised, the SDK enforces RFC 9207 §2.4 and
+ * rejects a callback whose `iss` is missing. Keep it on so the mock stays at
+ * least as strict as production servers — with it absent the SDK silently takes
+ * its lenient path and a dropped `iss` goes unnoticed.
+ */
 export function minimalOAuthAsMetadata(
   baseUrl: string,
   authorizationEndpoint = `${baseUrl}/authorize`,
@@ -32,6 +40,7 @@ export function minimalOAuthAsMetadata(
     token_endpoint: `${baseUrl}/token`,
     response_types_supported: ["code"],
     token_endpoint_auth_methods_supported: ["client_secret_post"],
+    authorization_response_iss_parameter_supported: true,
   };
 }