Address @claude review: format core/, typed output-validation error, document progress heuristic

- Run Prettier on the 60 core/ files this PR touched — the deterministic
  import rewrite had collapsed multi-line imports and left throws unwrapped;
  core/ is in no format gate so it slipped past CI. Now Prettier-clean.
- Default-path output-schema violation now throws
  ProtocolError(ProtocolErrorCode.InvalidParams, …) instead of a bare Error,
  matching the prior v1 contract (SDK threw a typed McpError with a code) so
  downstream `instanceof`/`.code` branching keeps working.
- Document the "assumes serial construction" invariant on pollTaskToolCall's
  progress-subscription revival (the `_progressHandlers` new-key heuristic).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
cliffhall 2026-07-15 11:08:54 -04:00
commit f9f79fff54

View file

@ -1,4 +1,8 @@
import { ProtocolErrorCode, ProtocolError, UrlElicitationRequiredError } from "@modelcontextprotocol/client";
import {
ProtocolErrorCode,
ProtocolError,
UrlElicitationRequiredError,
} from "@modelcontextprotocol/client";
import type { ElicitRequestURLParams } from "@modelcontextprotocol/client";
export type { ElicitRequestURLParams };
@ -46,7 +50,10 @@ export function getUrlElicitationsFromError(
if (error instanceof UrlElicitationRequiredError) {
return error.elicitations ?? [];
}
if (error instanceof ProtocolError && error.code === ProtocolErrorCode.UrlElicitationRequired) {
if (
error instanceof ProtocolError &&
error.code === ProtocolErrorCode.UrlElicitationRequired
) {
const data = error.data as
| { elicitations?: ElicitRequestURLParams[] }
| undefined;