* Extensions: advertised-extensions toggle in Server Settings (Phase 2 of #1633) Adds the debugging knob from #1633: users choose which extensions the Inspector advertises to a server, and a server may register different tools in response. Builds on Phase 1's registry + advertisedExtensions option (#1738). Settings + persistence (core): - InspectorServerSettings.advertisedExtensions + StoredMCPServer field, wired through serverList's read/write converters and INSPECTOR_FIELD_KEY_MAP (omit-when-empty, byte-stable round-trip). - validateSettings (remote PUT route): isBooleanRecord guard + carry a non-empty map; unknown/malformed rejected. - App.tsx threads savedSettings.advertisedExtensions into the client options. UI: - ServerSettingsForm renders an "Advertised Extensions" group of checkboxes driven by ADVERTISABLE_EXTENSIONS; a per-server override wins over the registry default. Modal folds a toggle into settings.advertisedExtensions. Test server + proof: - composable-test-server extensionGatedTools: a tool registered disabled and enabled on `initialized` iff the client declared the mapped extension (getClientCapabilities). Legacy stateful leg. Threaded through load-config/resolve-config; advertised-extensions-http.json showcase + README. - Integration test connects legacy with/without the tasks extension advertised and asserts the gated tool appears/disappears in tools/list — the acceptance criterion, proven end to end, not asserted. Tests: serverList round-trip (non-empty/absent/empty), ServerSettingsForm toggle rows, ServerSettingsModal fold, validateSettings accept/reject, and the integration gating test. npm run ci green (per-file ≥90 gate held). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XNdjEPKLG637X8YmhDiEk5 * Extensions: add #1739 proof screenshots (advertised-extensions toggle) End-to-end smoke test in the web client against the legacy advertised-extensions-http.json test server (port 3220): connecting with the Tasks extension advertised (default) lists echo + get_weather, unchecking the Advertised Extensions → Tasks toggle and reconnecting lists only echo — the server's tool registration changing on the client-declared extension. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XNdjEPKLG637X8YmhDiEk5 * Extensions: reconverge advertisedExtensions to no-override on default (review) Address Phase 2 review observation #1: toggling an extension back to its registry default now deletes the override key (and drops the whole map to undefined when it empties), so the on-disk `advertisedExtensions` reconverges to the byte-stable "no override" state instead of persisting a redundant `{ key: <default> }`. Matches the omit-when-default policy the other settings use. Only a value that differs from the default is persisted. Adds a modal test asserting the reconvergence (re-checking the sole disabling override drops advertisedExtensions to undefined). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XNdjEPKLG637X8YmhDiEk5 --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
2f80958d3f
commit
fe295396af
1 changed files with 585 additions and 0 deletions
|
|
@ -1354,6 +1354,12 @@ export function createRemoteApp(
|
|||
typeof (e as Record<string, unknown>).value === "string",
|
||||
);
|
||||
};
|
||||
const isBooleanRecord = (v: unknown): v is Record<string, boolean> => {
|
||||
if (v === null || typeof v !== "object" || Array.isArray(v)) return false;
|
||||
return Object.values(v as Record<string, unknown>).every(
|
||||
(flag) => typeof flag === "boolean",
|
||||
);
|
||||
};
|
||||
if (!isKvArray(obj.headers)) {
|
||||
return {
|
||||
ok: false,
|
||||
|
|
@ -1498,6 +1504,19 @@ export function createRemoteApp(
|
|||
"settings.modernLogLevel must be 'off' or a logging level (debug…emergency)",
|
||||
};
|
||||
}
|
||||
// advertisedExtensions is optional on the wire (older clients won't send
|
||||
// it); when present it must be a flat record of boolean flags keyed by
|
||||
// extension id, otherwise it defaults to absent below.
|
||||
if (
|
||||
obj.advertisedExtensions !== undefined &&
|
||||
!isBooleanRecord(obj.advertisedExtensions)
|
||||
) {
|
||||
return {
|
||||
ok: false,
|
||||
error:
|
||||
"settings.advertisedExtensions must be an object of boolean flags",
|
||||
};
|
||||
}
|
||||
// Build the validated value from explicitly named fields rather than
|
||||
// casting the raw object through. Unknown keys silently drop so a
|
||||
// misconfigured client can't smuggle stowaways onto disk, and consumers
|
||||
|
|
@ -1568,6 +1587,15 @@ export function createRemoteApp(
|
|||
if (isModernLogLevel(obj.modernLogLevel)) {
|
||||
value.modernLogLevel = obj.modernLogLevel;
|
||||
}
|
||||
// Optional; carry a non-empty boolean-flag map. Empty/absent reads back as
|
||||
// unset downstream (omit-on-empty in inspectorSettingsToStoredFields), so a
|
||||
// client that sent none writes no spurious advertisedExtensions to disk.
|
||||
if (
|
||||
isBooleanRecord(obj.advertisedExtensions) &&
|
||||
Object.keys(obj.advertisedExtensions).length > 0
|
||||
) {
|
||||
value.advertisedExtensions = { ...obj.advertisedExtensions };
|
||||
}
|
||||
// Empty cwd coerces to absent on the value (matching the read side); the
|
||||
// write-through distinguishes "sent cwd: '' " (clear) from "cwd omitted"
|
||||
// (preserve) via `cwdProvided` below rather than the value alone.
|
||||
|
|
|
|||
Loading…
Reference in a new issue