modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: salvage a list result's valid entries when one is malformed (#1909)

Browse source 
The SDK validates a list result as a whole, so a single non-conforming entry
rejected the entire response and the panel showed "Couldn't load resources"
with zero items — the exact opposite of what a debugging tool should do with a
server that is 90% right. Reported against a PHP server whose empty
`annotations` object reaches the wire as `[]` rather than `{}`.

`listAll*` now falls back to a lenient re-walk when — and only when — the SDK
rejects a result it received (`InvalidResult` / `UnsupportedResultType`), keeps
the entries that validate, and reports the rest. A conforming server takes the
strict, cache-aware path exactly as before.

Salvaging is not accepting: the dropped entries are named with their reason in
a warning above the list, and the Protocol entry is still marked rejected, so
the wire truth survives. When every entry validates, the original error is
rethrown rather than swallowed — the rejection was about something the
per-item pass cannot explain.

`isClientDecodeRejection` moves to the new module and is now shared with
managedListState, which had the only copy.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HDdo1rNRVQnVRRdsqSrvG3
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-08-15 16:52:11 -04:00
commit fe5b622fd1
1 changed files with 1402 additions and 64 deletions
Download patch file Download diff file Expand all files Collapse all files

13
core/mcp/__tests__/fakeInspectorClient.ts
View file

@ -38,6 +38,7 @@ import type {
ExcludedTool,
} from "../types.js";
import { INACTIVE_SUBSCRIPTION_STREAM_STATE } from "../types.js";
import type { MalformedListItem } from "../listSalvage.js";
import type { JsonValue } from "../../json/jsonUtils.js";
type ListResult<TKey extends string, TItem> = {
@ -282,6 +283,18 @@ export class FakeInspectorClient
this.dispatchTypedEvent("excludedToolsChange", excluded);
}
private malformedListItems: MalformedListItem[] = [];
getMalformedListItems(): MalformedListItem[] {
return this.malformedListItems;
}
/** Test helper: set the malformed-entry set and emit the change (#1909). */
setMalformedListItems(malformed: MalformedListItem[]): void {
this.malformedListItems = malformed;
this.dispatchTypedEvent("malformedListItemsChange", malformed);
}
getDiscoverResult(): DiscoverResult | undefined {
return this.discoverResult;
}