99a194ca69
`lint` failed only on errors, so a warn-level rule was a channel nothing consumed. `react-hooks/exhaustive-deps` reported two stale-closure `useCallback` deps in App.tsx on every run, `npm run ci` passed anyway, and the defect was caught only by a review round on #2076. Add `--max-warnings 0` to all six lint scopes — each of clients/{web,cli,tui,launcher}'s `eslint .`, plus the root's `lint:core` and `lint:shared` — so a warning fails `lint`, and therefore `validate` and `ci`. All six were already warning-free, so no suppressions, rule downgrades, or ignore-list widening were needed. Also promote `react-hooks/exhaustive-deps` to `error` in both React scopes (web, tui). The flag makes severity irrelevant to the gate; it does not make it read correctly in an editor. Document the invariant in AGENTS.md as a new "Lint has no warning tier" section, note it in the README beside the type-aware-linting paragraph, and mirror it into .github/copilot-instructions.md. Signed-off-by: cliffhall <cliff@futurescale.com>
49 lines
1.9 KiB
JavaScript
49 lines
1.9 KiB
JavaScript
import js from "@eslint/js";
|
|
import globals from "globals";
|
|
import reactHooks from "eslint-plugin-react-hooks";
|
|
import tseslint from "typescript-eslint";
|
|
import { defineConfig, globalIgnores } from "eslint/config";
|
|
|
|
// The TUI is Node + React (Ink) TypeScript. This mirrors the web client's flat
|
|
// config minus the browser-only plugins (react-refresh / Storybook).
|
|
//
|
|
// react-hooks is registered for the two classic rules the Ink components were
|
|
// written against (rules-of-hooks + exhaustive-deps, which the source already
|
|
// references in inline disable directives). We deliberately do NOT pull in the
|
|
// full react-hooks@7 "recommended" set: its newer error-level rules (e.g.
|
|
// set-state-in-effect) flag long-standing, intentional patterns in the
|
|
// component/hook surface that is itself the interim-excluded one tracked in
|
|
// #1501. Enforcing them would require refactoring code out of scope here.
|
|
export default defineConfig([
|
|
globalIgnores(["build", "coverage"]),
|
|
{
|
|
files: ["**/*.{ts,tsx}"],
|
|
plugins: { "react-hooks": reactHooks },
|
|
extends: [js.configs.recommended, tseslint.configs.recommended],
|
|
languageOptions: {
|
|
ecmaVersion: 2022,
|
|
sourceType: "module",
|
|
globals: globals.node,
|
|
},
|
|
rules: {
|
|
"react-hooks/rules-of-hooks": "error",
|
|
// `error`, not `warn` — see the web config (#2085).
|
|
"react-hooks/exhaustive-deps": "error",
|
|
},
|
|
},
|
|
{
|
|
// Type-aware pass for `no-floating-promises` (#1959) — see the CLI config
|
|
// for the reasoning. Both tsconfig projects are listed because `src` and
|
|
// `__tests__` live in different ones.
|
|
files: ["**/*.{ts,tsx}"],
|
|
languageOptions: {
|
|
parserOptions: {
|
|
project: ["./tsconfig.json", "./tsconfig.test.json"],
|
|
tsconfigRootDir: import.meta.dirname,
|
|
},
|
|
},
|
|
rules: {
|
|
"@typescript-eslint/no-floating-promises": "error",
|
|
},
|
|
},
|
|
]);
|