566990382a
Two suppressed comments, both accurate. - Pin zod, zod/v4 and open to the root in vitest.shared.mts, and add matching paths to the three clients/web tsconfigs. The claim they replace — that these resolve unambiguously by walk-up — was wrong: both still sit at the top level of clients/web/node_modules as transitive copies (zod under eslint-plugin-react-hooks, open under Storybook), so an unpinned bare import from a web test resolved the client copy while core/ and the SDK packages resolved the root's. For open that is only wasteful; for zod it is a schema built by one copy and an instanceof check made by the other across the whole @modelcontextprotocol/* surface. zod is deduped as well, and zod/v4 gets its own entry because first-party code imports both specifiers and pinning one would split the package rather than collapse it. - Update the consumer comments that #2195 falsified. clients/web/vite.config.ts (three places) and server/start-vite-dev-server.ts all still said the shared aliases resolve pino/hono and friends from clients/web/node_modules; they now state the split — react and react-dom from the client install, everything root-declared from the repo root. - local-dev skill: replace the wrong 'resolves unambiguously' list with the distinction that actually matters. Deleting a declaration is not the same as the package resolving from the root, because chokidar, zod, open and react all sit in a client install transitively; check the install, not the manifest. ajv, commander and undici carry no pin because no client install has a copy. npm run local:gate passes from a cold tsc build. Signed-off-by: cliffhall <cliff@futurescale.com>
84 lines
3.1 KiB
TypeScript
84 lines
3.1 KiB
TypeScript
/**
|
|
* Start Vite dev server in-process via the Node API. Config is passed into the plugin; no shared state.
|
|
*
|
|
* Uses the shared base config so Node-only callers don't need to load
|
|
* `vite.config.ts` (which Node can't import directly).
|
|
*/
|
|
|
|
import { join, dirname, resolve } from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { createServer, type InlineConfig } from "vite";
|
|
import react from "@vitejs/plugin-react";
|
|
import type { WebServerConfig } from "./web-server-config.js";
|
|
import { honoMiddlewarePlugin } from "./vite-hono-plugin.js";
|
|
import {
|
|
clearViteDepsCache,
|
|
getViteDevOptimizeDeps,
|
|
} from "./vite-base-config.js";
|
|
import { vitestSharedPaths } from "../../../vitest.shared.mts";
|
|
import type { WebServerHandle } from "./types.js";
|
|
|
|
export type { WebServerHandle };
|
|
|
|
const __dirname = dirname(fileURLToPath(import.meta.url));
|
|
|
|
/**
|
|
* Start the Vite dev server in-process. Passes config into the plugin. Caller owns SIGINT/SIGTERM.
|
|
*/
|
|
export async function startViteDevServer(
|
|
config: WebServerConfig,
|
|
): Promise<WebServerHandle> {
|
|
// Canonicalize paths under clients/web.
|
|
const root = resolve(join(__dirname, ".."));
|
|
clearViteDepsCache(root);
|
|
// `configFile: false` means this in-process server never loads
|
|
// `vite.config.ts`, so it must reproduce that file's `resolve` block and
|
|
// `server.fs.allow` here. Without them, App.tsx's `@inspector/core/*`
|
|
// imports fail to resolve and the page 500s (#1452 smoke test). The aliases
|
|
// and dedupe are factored into `vitest.shared.mts` so both paths stay in
|
|
// sync — pass the client dir (`root`), which is what the `react` /
|
|
// `react-dom` pins resolve against. The root-declared packages resolve from
|
|
// the repo root instead, which that file derives from the same argument.
|
|
const { repoRoot, sharedAliases, sharedDedupe, nodeModulesAliases } =
|
|
vitestSharedPaths(root);
|
|
const inlineConfig: InlineConfig = {
|
|
optimizeDeps: getViteDevOptimizeDeps(),
|
|
configFile: false,
|
|
root,
|
|
resolve: {
|
|
alias: [
|
|
...Object.entries(sharedAliases).map(([find, replacement]) => ({
|
|
find,
|
|
replacement,
|
|
})),
|
|
...nodeModulesAliases,
|
|
],
|
|
dedupe: sharedDedupe,
|
|
},
|
|
server: {
|
|
port: config.port,
|
|
host: config.hostname,
|
|
// `strictPort: true` (matching `vite.config.ts`) so a busy port fails
|
|
// loudly instead of silently binding a different one — the origin
|
|
// allow-list and the sandbox `frame-ancestors` are derived from
|
|
// `config.port`, so a drifted bind would 403 every connect and CSP-block
|
|
// the MCP Apps iframe while the banner advertises the unusable port.
|
|
strictPort: true,
|
|
// Allow Vite to serve source files from the repo root (core/ lives
|
|
// outside clients/web), matching `vite.config.ts`'s `server.fs.allow`.
|
|
fs: {
|
|
allow: [repoRoot],
|
|
},
|
|
},
|
|
plugins: [react(), honoMiddlewarePlugin(config)],
|
|
};
|
|
const server = await createServer(inlineConfig);
|
|
|
|
await server.listen();
|
|
|
|
return {
|
|
async close(): Promise<void> {
|
|
await server.close();
|
|
},
|
|
};
|
|
}
|