* refactor(web): update OAuth E2E tests to use new authentication method - Replaced `runGuidedAuth` with `authenticate` in the InspectorClient OAuth end-to-end tests to support quick authentication with CIMD pre-registration. - Updated comments to reflect the change in authentication method and its support for HTTP test metadata URLs. - Ensured that the tests continue to validate the expected authorization URL after the change. Additionally, imported `ensureCimdClientRegistration` in the OAuthManager to streamline client registration during the authentication process. * Guided-auth removal, OAuth smoke testing, and TUI/CLI support * Added CLI OAuth runner flags tests * Added clarifying comment on port 0 binding * README notes on TUI oauth callback port, prettier fixes for CLI tests * CIMD validation uses inline like EMA IdP * Fixed TUI test failures from merge * test: bring 5 OAuth files over the 90 per-file coverage gate The guided-auth-removal work added/touched several files that fell below the repo's >=90 per-file coverage gate (npm run coverage). CI doesn't run the gate (it's local-only), so validate + test:integration passed while these gaps slipped through. Bring them all back over the line: - core/auth/node/runner-oauth-callback.ts: test bad-URL/non-http-scheme throws, no-port->80 default, and IPv6 hostname bracketing. Annotate the provably-dead guards (empty host, out-of-range port, String(err) fallback, pathname "/" fallback) -- all rejected by new URL() upstream -- with justified v8 ignore comments instead of lowering the gate. - core/auth/cimd.ts: test the AS-doesn't-support-CIMD early return. - core/react/useClientSettingsDraft.ts: test the functional-updater path, the stale-onChange-after-close prev===null guard, and the timer-fires-after-close value===null guard. - ClientSettingsForm.tsx: test the CIMD checkbox toggle and CIMD URL clear. - clients/tui/src/utils/oauthDisplay.ts: test static/dcr registration kinds, the expired IdP session, and the configured-scope/empty-scope branches of formatScopes. npm run coverage now passes (exit 0) across web, cli, tui, launcher. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: cliffhall <cliff@futurescale.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
60 lines
2.1 KiB
TypeScript
60 lines
2.1 KiB
TypeScript
import type {
|
|
RedirectUrlProvider,
|
|
OAuthNavigationCallback,
|
|
} from "../providers.js";
|
|
import { CallbackNavigation, BaseOAuthClientProvider } from "../providers.js";
|
|
import { getBrowserOAuthStorage } from "./storage.js";
|
|
|
|
export type { OAuthNavigationCallback } from "../providers.js";
|
|
|
|
/**
|
|
* Browser navigation handler
|
|
* Redirects the browser window to the authorization URL.
|
|
*
|
|
* `beforeNavigate` runs **synchronously, immediately before** the
|
|
* `window.location.href` assignment. It is the last point at which code can
|
|
* run on the soon-to-unload document, so consumers that need to flush state
|
|
* across the OAuth redirect (e.g. persisting the Network log via a `keepalive`
|
|
* request) must do it here — a request dispatched synchronously before
|
|
* navigation survives the unload, whereas one fired from a later microtask
|
|
* (after `auth()` returns) is dropped when the document tears down.
|
|
*
|
|
* `callback` runs after navigation is requested; kept for backwards
|
|
* compatibility with callers that only need a post-redirect notification.
|
|
*/
|
|
export class BrowserNavigation extends CallbackNavigation {
|
|
constructor(
|
|
callback?: OAuthNavigationCallback,
|
|
beforeNavigate?: (authorizationUrl: URL) => void,
|
|
) {
|
|
super((url) => {
|
|
if (typeof window === "undefined") {
|
|
throw new Error("BrowserNavigation requires browser environment");
|
|
}
|
|
beforeNavigate?.(url);
|
|
window.location.href = url.href;
|
|
return callback?.(url);
|
|
});
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Browser OAuth client provider
|
|
* Uses sessionStorage directly (for web client reference)
|
|
*/
|
|
export class BrowserOAuthClientProvider extends BaseOAuthClientProvider {
|
|
constructor(serverUrl: string) {
|
|
if (typeof window === "undefined") {
|
|
throw new Error(
|
|
"BrowserOAuthClientProvider requires browser environment",
|
|
);
|
|
}
|
|
const storage = getBrowserOAuthStorage();
|
|
const redirectUrlProvider: RedirectUrlProvider = {
|
|
getRedirectUrl: () => `${window.location.origin}/oauth/callback`,
|
|
};
|
|
const navigation = new BrowserNavigation();
|
|
|
|
super(serverUrl, { storage, redirectUrlProvider, navigation });
|
|
}
|
|
}
|