50502269f4
Every state-subscription hook in core/react/ seeded local React state from its store prop and re-synced it inside a useEffect. That shape paints one frame of the previous store's data when the prop changes (switching servers), and loses any event dispatched between the render that took the snapshot and the effect that attached the listener. Convert all 16 to useSyncExternalStore through a new shared useStoreSnapshot, following useManagedListError (#1954). useSyncExternalStore needs a referentially stable snapshot, and these getters hand back a defensive copy, so TypedEventTarget now keeps a per-event-type dispatch counter (getEventRevision) that the snapshot is cached against. A contents comparison would not do: MessageLogState folds a response into its request entry by mutating that entry in place, which a shallow compare reports as unchanged. The bump lives on the dispatchEvent override so no dispatch — including a hand-rolled CustomEvent — can bypass it. useInspectorClient is included though the issue did not list it; its nine subscribed slices made the stale frame most visible. Its lastError stays useState (accumulated from events, no getter to read back) but resets on client swap during render rather than in an effect. The settings-draft and async fetch hooks are deliberately untouched: the former hold genuinely local editable state, the latter are I/O rather than store subscriptions. Also answers the issue's open question. react-hooks/set-state-in-effect never fired here because eslint-plugin-react-hooks has never linted core/react/ at all — it is a clients/web devDependency and the root config loads no React plugin. Corrected the config comment that gave "no JSX" as the reason; the gap itself is #2192, measured at 15 findings, none of them in the hooks converted here. Closes #1955 Signed-off-by: cliffhall <cliff@futurescale.com>
15 lines
592 B
TypeScript
15 lines
592 B
TypeScript
import type { PagePaginationState } from "../mcp/state/pagedToolsState.js";
|
|
|
|
/**
|
|
* The pagination snapshot reported while no paged store is attached (no
|
|
* active server): nothing loaded, nowhere to go next.
|
|
*
|
|
* Module scope and frozen because it is a `useStoreSnapshot` fallback — a
|
|
* fresh object literal per render would make the snapshot look different on
|
|
* every read. Shared by the three `usePaged*` list hooks, which is safe
|
|
* precisely because it is immutable.
|
|
*/
|
|
export const NO_PAGINATION: PagePaginationState = Object.freeze({
|
|
nextCursor: undefined,
|
|
pageCount: 0,
|
|
});
|