cliffhall
03af5b966f
Review round 6: 80% does not clear a strictly-compared 0.8
...
Copilot, accepted — and the sharpest catch of the six, because it is
the rationale contradicting the operator two paragraphs below it.
Round 1 rewrote the CHAIN_THRESHOLD comment to say a well-shaped
pointer "does clear 0.8" and cited 100%/80% as the evidence. This
threshold is compared with `>`, so 80% would FAIL an 0.8 bar; the
example refuted the sentence it was offered in support of. It was also
stale: 100%/80% was an intermediate build, and the shipped state
measures 100%/100%.
Both copies now cite 100%/100% as the clearing evidence and keep
100%/80% only as the residual-noise figure, saying explicitly that it
is not an example of clearing the bar.
While checking the claim I found the docs copy needed the same care for
a different reason: `passesThreshold` is strict for the chain and
INCLUSIVE for the first move (`rate > t` vs `rate >= t`, skill-eval.mjs
:558), and 0.8 is the constant for the inclusive one. So "0.8 is
compared strictly" is false as literally read. The docs now say a
*chain* bar of 0.8 would be the strict one, name the operator for both,
and spell out the consequence at RUNS=5 — only 5/5 passes, 4/5 does not.
No functional change; CHAIN_THRESHOLD is still 0.5, still strict.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EQVdemwgUhh45yzeaRSLhW
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-09-05 17:39:11 -04:00
..
lib
feat(skills): measure a skill reached from another skill ( #2204 )
2026-09-04 19:07:26 -04:00
dependabot-alerts.mjs
chore(deps): address Copilot review round 15 on #2243
2026-09-04 09:26:20 -04:00
dependabot-alerts.test.mjs
chore(deps): address Copilot review round 15 on #2243
2026-09-04 09:26:20 -04:00
dependency-refresh.mjs
chore(deps): address Copilot review round 1 on #2243
2026-09-04 09:06:32 -04:00
dependency-refresh.test.mjs
chore(deps): paginate the release list so the highest version is actual
2026-09-04 09:06:31 -04:00
install-clients.mjs
feat: port CLI, TUI, and launcher from v1.5 into v2 ( #1452 )
2026-06-14 20:27:49 -04:00
install-smoke-browser.mjs
fix(smoke): reject an empty SMOKE_BROWSER; test the installer's argument logic
2026-08-25 22:52:02 -04:00
install-smoke-browser.test.mjs
fix(smoke): reject an empty SMOKE_BROWSER; test the installer's argument logic
2026-08-25 22:52:02 -04:00
pack-and-verify.mjs
ci: drop the Firefox smoke job; keep the engines as an on-demand tool
2026-08-25 23:55:19 -04:00
run-engine-smokes.mjs
fix(smoke): route the Chromium tier through ENGINE_SMOKES too
2026-08-26 08:55:51 -04:00
run-engine-smokes.test.mjs
Merge remote-tracking branch 'origin/v2/main' into v2/chore/2146-rename-local-gate
2026-08-27 00:16:14 -04:00
skill-eval.mjs
Review round 6: 80% does not clear a strictly-compared 0.8
2026-09-05 17:39:11 -04:00
skill-eval.test.mjs
feat(skills): address Copilot review round 3 on #2204
2026-09-04 20:28:37 -04:00
smoke-cli.mjs
chore(scripts): build test-servers unconditionally from one shared helper
2026-08-25 00:57:48 -04:00
smoke-launcher.mjs
refactor: self-validating clients, fast validate + separate coverage/smoke ( #1504 ) ( #1505 )
2026-06-21 11:41:33 -04:00
smoke-tui.mjs
fix(scripts): make the test stubs drain, and the raw-mode guard testable ( #2147 )
2026-08-26 22:13:35 -04:00
smoke-web-app.mjs
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
smoke-web-browser.mjs
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
smoke-web-elicitation.mjs
Merge remote-tracking branch 'origin/v2/main' into v2/chore/2146-rename-local-gate
2026-08-27 00:16:14 -04:00
smoke-web-tabs.mjs
Merge remote-tracking branch 'origin/v2/main' into v2/chore/2146-rename-local-gate
2026-08-27 00:16:14 -04:00
smoke-web.mjs
fix(smoke): await the server's exit before removing its catalog, and test it
2026-08-11 14:32:20 -04:00
verify-build-gate.mjs
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
verify-bundle-externals.mjs
test(proxy): isolate proxy env per file; word the guard failure by candidate source
2026-08-23 23:00:28 -04:00
verify-bundle-externals.test.mjs
test(proxy): isolate proxy env per file; word the guard failure by candidate source
2026-08-23 23:00:28 -04:00
verify-dep-lockstep.main.test.mjs
Merge origin/v2/main: move the #1939 npx fix into the shared tsc-program lib
2026-08-16 17:07:50 -07:00
verify-dep-lockstep.mjs
chore(scripts): compare only the copies a program actually met
2026-08-16 12:35:38 -04:00
verify-dep-lockstep.test.mjs
chore(scripts): compare only the copies a program actually met
2026-08-16 12:35:38 -04:00
verify-format-coverage.main.test.mjs
chore: address Copilot review round 20
2026-08-29 05:32:12 -04:00
verify-format-coverage.mjs
chore: address Copilot review round 9
2026-08-29 03:04:03 -04:00
verify-skills-cli.mjs
chore: address Copilot review round 17
2026-08-29 04:54:04 -04:00
verify-skills-cli.test.mjs
chore: address Copilot review round 16
2026-08-29 04:40:48 -04:00
verify-skills.main.test.mjs
feat(skills): measure a skill reached from another skill ( #2204 )
2026-09-04 19:07:26 -04:00
verify-skills.mjs
feat(skills): measure a skill reached from another skill ( #2204 )
2026-09-04 19:07:26 -04:00
verify-typecheck-coverage.main.test.mjs
Merge origin/v2/main: move the #1939 npx fix into the shared tsc-program lib
2026-08-16 17:07:50 -07:00
verify-typecheck-coverage.mjs
Merge origin/v2/main: move the #1939 npx fix into the shared tsc-program lib
2026-08-16 17:07:50 -07:00
verify-typecheck-coverage.test.mjs
chore(scripts): derive dep-lockstep candidates from what enters each tsc program
2026-08-16 12:17:15 -04:00