cliffhall
09b8f0e834
chore: address Copilot review round 7 (Windows .cmd shims) ...
Node has refused shell-free `.cmd`/`.bat` spawns since CVE-2024-27980, and an
npm-installed `claude` is a `.cmd` shim on Windows — so every shell-free spawn
of it reported ENOENT there, each in a quiet way: `verify:skills` skipped its
authoritative hand-off, `verify:skills:cli` downloaded the pinned package it
already had (and failed offline), and `skills:eval` said "not on PATH".
- New `scripts/lib/claude-cli.mjs` is the one place that decides how `claude` is
spawned: `shell` on win32, arguments through the existing `winShellArgs`
quoting so `cmd.exe` cannot re-parse them as syntax (#1939 ). Unit-tested with
the platform injected, since a win32-only bug no runner here executes is
exactly the kind that ships.
- `verify-skills`, `verify-skills-cli` and `skill-eval` all route their probes
and spawns through it.
- skill-eval sends the prompt on **stdin** rather than in argv. `claude -p` reads
a piped prompt (verified end to end), which sidesteps `cmd.exe` metacharacter
re-parsing entirely rather than relying on quoting a model-visible string, and
keeps the prompt out of the process table.
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-08-29 02:32:30 -04:00
chore: address Copilot review round 7 (Windows .cmd shims)
2026-08-29 02:32:30 -04:00
feat: port CLI, TUI, and launcher from v1.5 into v2 ( #1452 )
2026-06-14 20:27:49 -04:00
fix(smoke): reject an empty SMOKE_BROWSER; test the installer's argument logic
2026-08-25 22:52:02 -04:00
fix(smoke): reject an empty SMOKE_BROWSER; test the installer's argument logic
2026-08-25 22:52:02 -04:00
ci: drop the Firefox smoke job; keep the engines as an on-demand tool
2026-08-25 23:55:19 -04:00
fix(smoke): route the Chromium tier through ENGINE_SMOKES too
2026-08-26 08:55:51 -04:00
Merge remote-tracking branch 'origin/v2/main' into v2/chore/2146-rename-local-gate
2026-08-27 00:16:14 -04:00
chore: address Copilot review round 7 (Windows .cmd shims)
2026-08-29 02:32:30 -04:00
chore: address Copilot review round 7 (Windows .cmd shims)
2026-08-29 02:32:30 -04:00
chore(scripts): build test-servers unconditionally from one shared helper
2026-08-25 00:57:48 -04:00
refactor: self-validating clients, fast validate + separate coverage/smoke ( #1504 ) ( #1505 )
2026-06-21 11:41:33 -04:00
fix(scripts): make the test stubs drain, and the raw-mode guard testable ( #2147 )
2026-08-26 22:13:35 -04:00
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
Merge remote-tracking branch 'origin/v2/main' into v2/chore/2146-rename-local-gate
2026-08-27 00:16:14 -04:00
Merge remote-tracking branch 'origin/v2/main' into v2/chore/2146-rename-local-gate
2026-08-27 00:16:14 -04:00
fix(smoke): await the server's exit before removing its catalog, and test it
2026-08-11 14:32:20 -04:00
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
test(proxy): isolate proxy env per file; word the guard failure by candidate source
2026-08-23 23:00:28 -04:00
test(proxy): isolate proxy env per file; word the guard failure by candidate source
2026-08-23 23:00:28 -04:00
Merge origin/v2/main: move the #1939 npx fix into the shared tsc-program lib
2026-08-16 17:07:50 -07:00
chore(scripts): compare only the copies a program actually met
2026-08-16 12:35:38 -04:00
chore(scripts): compare only the copies a program actually met
2026-08-16 12:35:38 -04:00
test(scripts): cover verify-format-coverage's sibling-guard vouch
2026-08-10 22:16:29 -04:00
chore(deps): scope the allowlist to a major, cover vitest.shared.mts, fix the vouch comment
2026-08-10 21:00:31 -04:00
chore: address Copilot review round 7 (Windows .cmd shims)
2026-08-29 02:32:30 -04:00
chore: address Copilot review round 7 (Windows .cmd shims)
2026-08-29 02:32:30 -04:00
chore: address Copilot review round 4
2026-08-29 01:47:43 -04:00
chore: address Copilot review round 7 (Windows .cmd shims)
2026-08-29 02:32:30 -04:00
Merge origin/v2/main: move the #1939 npx fix into the shared tsc-program lib
2026-08-16 17:07:50 -07:00
Merge origin/v2/main: move the #1939 npx fix into the shared tsc-program lib
2026-08-16 17:07:50 -07:00
chore(scripts): derive dep-lockstep candidates from what enters each tsc program
2026-08-16 12:17:15 -04:00
09b8f0e834