Migrate all three clients + core + test-servers from
@modelcontextprotocol/sdk@1.29 to SDK v2 (2.0.0-beta.4), keeping behavior
identical against legacy (2025-11-25) servers. Foundation for the SDK V2 +
New Spec stack.
Packages
- Split @modelcontextprotocol/sdk -> @modelcontextprotocol/client (Client,
transports, OAuth, error taxonomy, protocol types) + core (Zod schemas);
stdio -> client/stdio, Ajv -> client/validators/ajv. Test-servers ->
@modelcontextprotocol/server (+ server-legacy/sse). Deterministic import
rewrite (schemas -> core, everything else -> client); the codemod misroutes
client code to /server so it was not used for path routing.
- new Client(..., { versionNegotiation: { mode: 'legacy' } }) — nothing
2026-era goes on the wire.
Runtime (core/mcp/inspectorClient.ts)
- Error taxonomy: McpError -> ProtocolError, ErrorCode -> ProtocolErrorCode;
RequestTimeout -> SdkError/SdkErrorCode.
- Handlers take method strings; task methods (tasks/*, notifications/tasks/*)
use the 3-arg custom form (excluded from v2's spec-method set).
- Legacy tasks kept working (per project requirement): requestor tasks re-
implemented over raw client.request + explicit deprecated schemas;
experimental.tasks.callToolStream replaced by a local pollTaskToolCall
async generator (with _progressHandlers revival so task-execution progress
still reaches the caller). Receiver (server-initiated) tasks: the v2 Client
validates a sampling/elicit handler result and rejects the legacy { task }
response with -32602 — installReceiverTaskResponseBypass swaps the wrapped
entry in the private _requestHandlers map for the task-augmented branch so
{ task } reaches the wire (fixes server-initiated sampling-via-task).
- Pagination: list verbs use raw client.request({method}, List*ResultSchema)
for single-page behavior (v2's client.listX() auto-aggregate all pages).
Web / auth / apps
- Rename local JsonSchemaType -> InspectorFormSchema + add toFormSchema()
structural narrowing at the SDK-schema -> form boundary.
- ext-apps still peers on SDK v1: one compat boundary with documented casts
(remove when ext-apps#702 lands a v2 peer).
- OAuth provider saveClientInformation reconciled with v2's
OAuthClientInformationContext; InvalidClientMetadataError re-homed as a
local class (server-legacy/auth is not browser-safe).
- vitest.shared.mts dedupes @modelcontextprotocol/client+core to one copy so
vi.mock intercepts the SUT's import.
Accepted v2 behavior changes (per #1624 / spec §9.2): unknown-tool call
rejects with -32602; cancellation is stream-abort (no guaranteed
notifications/cancelled frame); output-schema strictness restored via the
Inspector's own Ajv check on the default path.
npm run ci green: validate (web 3087 / cli 212 / tui 274 / launcher 5),
coverage (>=90 per-file, all clients), smoke (launcher/cli/web), storybook
(410).
Closes #1624
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
161 lines
5.8 KiB
TypeScript
161 lines
5.8 KiB
TypeScript
import { useState } from "react";
|
|
import { describe, it, expect, vi } from "vitest";
|
|
import userEvent from "@testing-library/user-event";
|
|
import type { Prompt } from "@modelcontextprotocol/client";
|
|
import { renderWithMantine, screen } from "../../../test/renderWithMantine";
|
|
import { PromptControls, type PromptControlsProps } from "./PromptControls";
|
|
|
|
const samplePrompts: Prompt[] = [
|
|
{
|
|
name: "summarize",
|
|
description: "Summarize the given text into key points",
|
|
},
|
|
{
|
|
name: "translate",
|
|
description: "Translate text from one language to another",
|
|
},
|
|
{ name: "analyze", description: "Analyze sentiment and tone of the text" },
|
|
{ name: "code-review", description: "Review code for issues" },
|
|
{ name: "refactor" },
|
|
];
|
|
|
|
const baseProps = {
|
|
prompts: samplePrompts,
|
|
listChanged: false,
|
|
onRefreshList: vi.fn(),
|
|
onSelectPrompt: vi.fn(),
|
|
onSearchChange: vi.fn(),
|
|
};
|
|
|
|
// The search box is controlled: typing fires onSearchChange but does not
|
|
// update the component's own state. This host holds the searchText state so
|
|
// interaction tests that filter by typing behave like the real parent.
|
|
function ControlledPromptControls(props: Partial<PromptControlsProps>) {
|
|
const [searchText, setSearchText] = useState(props.searchText ?? "");
|
|
return (
|
|
<PromptControls
|
|
{...baseProps}
|
|
{...props}
|
|
searchText={searchText}
|
|
onSearchChange={(value) => {
|
|
setSearchText(value);
|
|
props.onSearchChange?.(value);
|
|
}}
|
|
/>
|
|
);
|
|
}
|
|
|
|
describe("PromptControls", () => {
|
|
it("renders the title and search input", () => {
|
|
renderWithMantine(<PromptControls {...baseProps} />);
|
|
expect(screen.getByText("Prompts")).toBeInTheDocument();
|
|
expect(
|
|
screen.getByPlaceholderText("Search prompts..."),
|
|
).toBeInTheDocument();
|
|
});
|
|
|
|
it("renders all prompts by default", () => {
|
|
renderWithMantine(<PromptControls {...baseProps} />);
|
|
expect(screen.getByText("summarize")).toBeInTheDocument();
|
|
expect(screen.getByText("translate")).toBeInTheDocument();
|
|
expect(screen.getByText("analyze")).toBeInTheDocument();
|
|
expect(screen.getByText("code-review")).toBeInTheDocument();
|
|
expect(screen.getByText("refactor")).toBeInTheDocument();
|
|
});
|
|
|
|
it("filters prompts by name when typing in the search input", async () => {
|
|
const user = userEvent.setup();
|
|
renderWithMantine(<ControlledPromptControls />);
|
|
await user.type(screen.getByPlaceholderText("Search prompts..."), "trans");
|
|
expect(screen.getByText("translate")).toBeInTheDocument();
|
|
expect(screen.queryByText("summarize")).not.toBeInTheDocument();
|
|
expect(screen.queryByText("refactor")).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("filters prompts by description when typing in the search input", async () => {
|
|
const user = userEvent.setup();
|
|
renderWithMantine(<ControlledPromptControls />);
|
|
await user.type(
|
|
screen.getByPlaceholderText("Search prompts..."),
|
|
"sentiment",
|
|
);
|
|
expect(screen.getByText("analyze")).toBeInTheDocument();
|
|
expect(screen.queryByText("summarize")).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("filters prompts by title when present", async () => {
|
|
const user = userEvent.setup();
|
|
const promptsWithTitle: Prompt[] = [
|
|
{ name: "p1", title: "Alpha Title" },
|
|
{ name: "p2", title: "Beta Title" },
|
|
];
|
|
renderWithMantine(<ControlledPromptControls prompts={promptsWithTitle} />);
|
|
await user.type(screen.getByPlaceholderText("Search prompts..."), "alpha");
|
|
expect(screen.getByText("Alpha Title")).toBeInTheDocument();
|
|
expect(screen.queryByText("Beta Title")).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("invokes onSelectPrompt when an unselected prompt is clicked", async () => {
|
|
const user = userEvent.setup();
|
|
const onSelectPrompt = vi.fn();
|
|
renderWithMantine(
|
|
<PromptControls {...baseProps} onSelectPrompt={onSelectPrompt} />,
|
|
);
|
|
await user.click(screen.getByText("translate"));
|
|
expect(onSelectPrompt).toHaveBeenCalledWith("translate");
|
|
});
|
|
|
|
it("does not invoke onSelectPrompt when the already-selected prompt is clicked", async () => {
|
|
const user = userEvent.setup();
|
|
const onSelectPrompt = vi.fn();
|
|
renderWithMantine(
|
|
<PromptControls
|
|
{...baseProps}
|
|
selectedName="translate"
|
|
onSelectPrompt={onSelectPrompt}
|
|
/>,
|
|
);
|
|
await user.click(screen.getByText("translate"));
|
|
expect(onSelectPrompt).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("does not show the list-changed indicator when listChanged is false", () => {
|
|
renderWithMantine(<PromptControls {...baseProps} />);
|
|
expect(screen.queryByText("List updated")).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("shows the list-changed indicator when listChanged is true and invokes onRefreshList", async () => {
|
|
const user = userEvent.setup();
|
|
const onRefreshList = vi.fn();
|
|
renderWithMantine(
|
|
<PromptControls
|
|
{...baseProps}
|
|
listChanged
|
|
onRefreshList={onRefreshList}
|
|
/>,
|
|
);
|
|
expect(screen.getByText("List updated")).toBeInTheDocument();
|
|
await user.click(screen.getByRole("button", { name: "Refresh" }));
|
|
expect(onRefreshList).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("clears the search via the Clear button (onSearchChange with empty value)", async () => {
|
|
const user = userEvent.setup();
|
|
const onSearchChange = vi.fn();
|
|
renderWithMantine(
|
|
<ControlledPromptControls
|
|
searchText="trans"
|
|
onSearchChange={onSearchChange}
|
|
/>,
|
|
);
|
|
// The Clear button only renders while searchText is non-empty.
|
|
await user.click(screen.getByRole("button", { name: "Clear" }));
|
|
expect(onSearchChange).toHaveBeenLastCalledWith("");
|
|
});
|
|
|
|
it("renders empty list when no prompts", () => {
|
|
renderWithMantine(<PromptControls {...baseProps} prompts={[]} />);
|
|
expect(screen.getByText("Prompts")).toBeInTheDocument();
|
|
expect(screen.queryByText("translate")).not.toBeInTheDocument();
|
|
});
|
|
});
|