inspector/clients/web/tsconfig.node.json
cliffhall 566990382a chore: address Copilot review round 3 on #2200
Two suppressed comments, both accurate.

- Pin zod, zod/v4 and open to the root in vitest.shared.mts, and add matching
  paths to the three clients/web tsconfigs. The claim they replace — that these
  resolve unambiguously by walk-up — was wrong: both still sit at the top level
  of clients/web/node_modules as transitive copies (zod under
  eslint-plugin-react-hooks, open under Storybook), so an unpinned bare import
  from a web test resolved the client copy while core/ and the SDK packages
  resolved the root's. For open that is only wasteful; for zod it is a schema
  built by one copy and an instanceof check made by the other across the whole
  @modelcontextprotocol/* surface. zod is deduped as well, and zod/v4 gets its
  own entry because first-party code imports both specifiers and pinning one
  would split the package rather than collapse it.
- Update the consumer comments that #2195 falsified. clients/web/vite.config.ts
  (three places) and server/start-vite-dev-server.ts all still said the shared
  aliases resolve pino/hono and friends from clients/web/node_modules; they now
  state the split — react and react-dom from the client install, everything
  root-declared from the repo root.
- local-dev skill: replace the wrong 'resolves unambiguously' list with the
  distinction that actually matters. Deleting a declaration is not the same as
  the package resolving from the root, because chokidar, zod, open and react
  all sit in a client install transitively; check the install, not the manifest.
  ajv, commander and undici carry no pin because no client install has a copy.

npm run local:gate passes from a cold tsc build.

Signed-off-by: cliffhall <cliff@futurescale.com>
2026-08-31 20:27:08 -04:00

65 lines
2.8 KiB
JSON

{
"compilerOptions": {
"tsBuildInfoFile": "./node_modules/.tmp/tsconfig.node.tsbuildinfo",
"target": "ES2023",
/* DOM is included so dev-backend files (and transitively core/) can use
* Web Fetch APIs (Request, Response, Headers, RequestInfo) without losing
* type info. Node 18+ provides these as globals at runtime; the DOM lib
* is the canonical source of their type declarations. */
"lib": ["ES2023", "DOM", "DOM.Iterable"],
"module": "ESNext",
"types": ["node"],
"skipLibCheck": true,
/* Bundler mode */
"moduleResolution": "bundler",
"allowImportingTsExtensions": true,
"verbatimModuleSyntax": true,
"moduleDetection": "force",
"noEmit": true,
/* Linting */
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"erasableSyntaxOnly": true,
"noFallthroughCasesInSwitch": true,
"noUncheckedSideEffectImports": true,
/* Path aliases. The dev-backend files imported by vite.config.ts
* (vite-hono-plugin.ts, web-server-config.ts, server.ts,
* start-vite-dev-server.ts) live in src/ and import from @inspector/core/*;
* tsc follows those transitive imports while type-checking vite.config.ts,
* so this tsconfig needs the same alias tsconfig.app.json has.
*
* Two prefixes, and the difference is ownership rather than style. A
* `./node_modules/...` mapping names a package this client declares — the
* `@types/*` packages, `vitest`, `yaml`. A `../../node_modules/...` one
* names a package declared only in the root manifest (#2195), which is
* every runtime dependency `core/` imports. Those must be spelled out:
* `chokidar` in particular is still present under `clients/web` as a
* transitive copy of Vite's, so a `./node_modules` mapping resolves the
* client's copy at compile time while Vitest and the shipped bundle both
* resolve the root's. Same version today, and a silent skew tomorrow.
*
* Paths are relative to this config file (no `baseUrl` — deprecated in
* TypeScript 6 / removed in 7).
*/
"paths": {
"@inspector/core/*": ["../../core/*"],
"pino": ["../../node_modules/pino"],
"hono": ["../../node_modules/hono"],
"hono/streaming": [
"../../node_modules/hono/dist/types/helper/streaming/index"
],
"@hono/node-server": ["../../node_modules/@hono/node-server"],
"atomically": ["../../node_modules/atomically"],
"chokidar": ["../../node_modules/chokidar"],
"@napi-rs/keyring": ["../../node_modules/@napi-rs/keyring"],
"zod": ["../../node_modules/zod"],
"zod/v4": ["../../node_modules/zod/v4"],
"open": ["../../node_modules/open"]
}
},
"include": ["vite.config.ts", "tsup.runner.config.ts", "server/**/*.ts"]
}