baf79b843f* feat(web): expand ContentViewer to render PDF, CSV, HTML, XML, JSON, CSS (closes #1329) Turn ContentViewer into a per-MIME dispatch surface for resource content. It now accepts raw TextResourceContents | BlobResourceContents (in addition to the existing ContentBlock path), so ResourcePreviewPanel.toContentBlock collapses to a passthrough and blob-typed resources render natively instead of falling back to opaque "[Binary content …]" text. New renderers (clients/web/src/components/elements/): - CodeHighlight: lazy react-syntax-highlighter prism-light element. Runtime, tomorrow theme, and each grammar dynamic-import on first use (one chunk per grammar). Module-level registeredLanguages / failedLoads / loadingPromises caches; plain Code block until a grammar resolves. - PdfFrame: iframe over a Blob URL (#view=FitH), revoked on unmount. - CsvTable: papaparse -> Mantine Table (first 100 rows), plain-Code fallback. - HtmlFrame: sandbox="" iframe over a Blob URL with an injected CSP meta (no script-src, falls through to default-src 'none'). - contentViewerUtils: getMimeKind, base64 decode helpers, formatXml, wrapHtmlWithCsp, SAFE_HREF markdown-anchor allowlist (unsafe href -> span). ResourcePreviewPanel: extend the URI-suffix MIME inference table (.csv/.json/.xml/.html/.htm/.css/.pdf alongside .md). Deps: papaparse + react-syntax-highlighter (+ @types). tsconfig paths stubs redirect the deep RSH imports for typecheck (the @types ambient declarations are shadowed by the real .js under bundler resolution) — same pattern the repo uses for react/pino. Tests cover PDF blob-URL creation + cleanup, CSV table render + fallback, HTML sandbox attributes + CSP injection, JSON/XML/CSS highlighted output, the lazy-load/alias/failed-load/shared-runtime paths, and the URI-suffix MIME-inference paths. validate, test:coverage (per-file gate), test:storybook, and integration all pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(web): harden ContentViewer blob/CSV rendering per review (#1551) Address review feedback on the ContentViewer MIME-dispatch PR: - useObjectUrl: fix a dev-only StrictMode bug where the committed object URL was revoked but never recreated (setup→cleanup→setup with no re-render), blanking PDF/HTML previews. Revocation is now deferred to a microtask and guarded by a "live URL" ref so a StrictMode re-setup cancels it, while a real unmount / blob change still releases the URL. Avoids set-state-in-effect; mirrors AppRenderer's deferred-disposal. - atob: guard base64 decoding with tryDecodeBase64ToUtf8 / tryDecodeBase64ToBytes so a malformed blob from an external server degrades to the binary-content notice instead of throwing during render and taking down the whole preview panel. - CsvTable: surface the 100-row display cap with a "Showing first N of M rows" caption (no silent truncation). - Extract BinaryNotice into its own module so PdfFrame can reuse it without an import cycle. Tests added for the StrictMode path, malformed-base64 fallbacks (PDF + textual blob), the safe-decode helpers, and the truncation caption. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
56 lines
2.3 KiB
TypeScript
56 lines
2.3 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { renderWithMantine, screen } from "../../../test/renderWithMantine";
|
|
import { CsvTable, MAX_ROWS } from "./CsvTable";
|
|
|
|
describe("CsvTable", () => {
|
|
it("renders a table with headers and rows", () => {
|
|
const csv = "name,age\nAlice,30\nBob,25";
|
|
renderWithMantine(<CsvTable text={csv} />);
|
|
expect(
|
|
screen.getByRole("columnheader", { name: "name" }),
|
|
).toBeInTheDocument();
|
|
expect(
|
|
screen.getByRole("columnheader", { name: "age" }),
|
|
).toBeInTheDocument();
|
|
expect(screen.getByRole("cell", { name: "Alice" })).toBeInTheDocument();
|
|
expect(screen.getByRole("cell", { name: "25" })).toBeInTheDocument();
|
|
});
|
|
|
|
it("fills missing cells with empty strings", () => {
|
|
const csv = "a,b,c\n1,2";
|
|
const { container } = renderWithMantine(<CsvTable text={csv} />);
|
|
const cells = container.querySelectorAll("tbody td");
|
|
expect(cells).toHaveLength(3);
|
|
expect(cells[2].textContent).toBe("");
|
|
});
|
|
|
|
it("caps rendered rows at MAX_ROWS and surfaces the truncation", () => {
|
|
const total = MAX_ROWS + 50;
|
|
const rows = Array.from({ length: total }, (_, i) => `r${i},${i}`);
|
|
const csv = `name,n\n${rows.join("\n")}`;
|
|
const { container } = renderWithMantine(<CsvTable text={csv} />);
|
|
expect(container.querySelectorAll("tbody tr")).toHaveLength(MAX_ROWS);
|
|
expect(
|
|
screen.getByText(`Showing first ${MAX_ROWS} of ${total} rows`),
|
|
).toBeInTheDocument();
|
|
});
|
|
|
|
it("shows no truncation caption when all rows fit", () => {
|
|
const csv = "name,age\nAlice,30\nBob,25";
|
|
const { container } = renderWithMantine(<CsvTable text={csv} />);
|
|
expect(container.querySelector("caption")).toBeNull();
|
|
});
|
|
|
|
it("falls back to a plain code block when there are no columns", () => {
|
|
const { container } = renderWithMantine(<CsvTable text="" />);
|
|
expect(container.querySelector("table")).toBeNull();
|
|
expect(container.querySelector(".mantine-Code-root")).toBeInTheDocument();
|
|
});
|
|
|
|
it("falls back to a plain code block when there are no data rows", () => {
|
|
// Header only, no data rows → not a useful table.
|
|
const { container } = renderWithMantine(<CsvTable text="only_header" />);
|
|
expect(container.querySelector("table")).toBeNull();
|
|
expect(screen.getByText("only_header")).toBeInTheDocument();
|
|
});
|
|
});
|