cliffhall
47b3c6fc9c
chore(scripts): read a shell-expanded name as unreadable, and env keys case-insensitively ( #2146 ) ...
Copilot, seventh review:
- The unreadable-name rules only knew GitHub expression syntax, so
`ENGINE: firefox` plus `npm run smoke:web:$ENGINE` ran a forbidden pass with
the guard silent — the shell resolves the name, which makes it exactly as
unreadable as a ${{ }} expression and forbidden for the same reason. The
pattern keys off a leading $ or %, covering $VAR, ${VAR}, $env:VAR and cmd's
%VAR% in one, for both the engine and `local:` families.
- The env-key comparison was case-sensitive, but Windows environment variables
are not: `env: { smoke_browser: firefox }` on a windows-latest job sets the
very variable Node reads as SMOKE_BROWSER. Compared case-insensitively now,
as is the POSIX assignment pattern. On a POSIX runner that spelling would be
a different variable and harmless, so this is stricter there than it needs to
be — the right direction for a guard, and the alternative is a verdict that
depends on a `runs-on` which may itself be an expression.
Signed-off-by: Cliff Hall <cliff@futurescale.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-08-27 01:54:23 -04:00
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
fix(scripts): await the pack:verify web child's exit before removing its work dir ( #1895 )
2026-08-01 19:50:00 -04:00
fix(scripts): await the pack:verify web child's exit before removing its work dir ( #1895 )
2026-08-01 19:50:00 -04:00
chore(web): connected-flow smoke for the Tools, Resources and Prompts tabs
2026-08-26 23:09:44 -04:00
chore(web): connected-flow smoke for the Tools, Resources and Prompts tabs
2026-08-26 23:09:44 -04:00
docs(scripts): correct the deleted-source caveat — it is silent, not loud
2026-08-25 01:37:40 -04:00
fix(scripts): pin the tsbuildinfo inside build/, assert on cache hits
2026-08-25 01:11:10 -04:00
fix(smoke): assert the requested engine is the one launched; fix the remedy
2026-08-26 09:33:21 -04:00
fix(smoke): assert the requested engine is the one launched; fix the remedy
2026-08-26 09:33:21 -04:00
chore(web): connected-flow smoke for the Tools, Resources and Prompts tabs
2026-08-26 23:09:44 -04:00
Merge branch 'v2/main' into v2/chore/2003-pack-verify-app-render
2026-08-24 09:05:53 -04:00
test(cli,tui): typecheck the __tests__ dirs ( #1791 ) ( #1799 )
2026-07-27 12:05:35 -04:00
test(cli,tui): typecheck the __tests__ dirs ( #1791 ) ( #1799 )
2026-07-27 12:05:35 -04:00
test(smoke): cover loadBrowser's failure branches; fix a stale helper comment
2026-08-25 22:42:06 -04:00
fix(smoke): pin the teardown ordering, and correct a docblock the test refuted
2026-08-11 15:17:56 -04:00
fix(scripts): address Copilot review round 2 on #2147
2026-08-26 21:36:40 -04:00
fix(scripts): address Copilot review round 2 on #2147
2026-08-26 21:36:40 -04:00
fix(scripts): make the test stubs drain, and the raw-mode guard testable ( #2147 )
2026-08-26 22:13:35 -04:00
fix(scripts): make the test stubs drain, and the raw-mode guard testable ( #2147 )
2026-08-26 22:13:35 -04:00
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
fix(scripts): validate the bin name and that its file exists
2026-08-16 23:43:24 -04:00
chore(scripts): compare only the copies a program actually met
2026-08-16 12:35:38 -04:00
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
fix(scripts): keep the resolver local, complete the cmd.exe quoting
2026-08-17 00:18:40 -04:00
chore(scripts): read a shell-expanded name as unreadable, and env keys case-insensitively ( #2146 )
2026-08-27 01:54:23 -04:00
chore(scripts): read a shell-expanded name as unreadable, and env keys case-insensitively ( #2146 )
2026-08-27 01:54:23 -04:00
47b3c6fc9c