inspector/core/json/rootUnion.ts
cliffhall 81f2115e8b fix: decline a union branch requiring a name it never declares (#2224)
`isOfferable` in `core/json/rootUnion.ts` checked that a merged branch carries
at least one property and that every property value is readable, but never that
each name in `required` resolves to a property a form can render. A branch like
`{ properties: { kind }, required: ["kind", "payload"] }` was therefore offered
in the picker, rendered no control for `payload`, and had the submit-time check
report it missing permanently — the exact dead end the function's own comment
already reasons through for a `false`-schema required field, one case short.

Judge the merge, so a branch requiring only names the ROOT declares —
`anyOf: [{ required: ["email"] }, …]` — stays offerable as before. `hasOwn`
rather than `in`, since an argument legally named `constructor` would otherwise
resolve through the prototype and read as declared.

Declining every branch of a union leaves the web form with neither a picker nor
a field, which is a different dead end. `SchemaForm` now seeds the raw-JSON
editor (#2151) in that one case — a root union that resolved to no branches and
no properties — so the arguments stay expressible. Seeded rather than forced, so
the switch still works, and re-seeded during render (never in an effect) because
the form is reused across tools rather than remounted. A tool that genuinely
takes no arguments is untouched. The TUI has no such editor; there the union is
simply not offered, which is already better than a section that can never be
submitted.

Adds a `record_shipment_by` preset and wires it into the
`root-union-schemas-http.json` showcase so the shape is reproducible by hand,
with docs/test-servers.md covering it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PxYT4eKdnx1yRw7x4bW7Ts
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-09-06 12:59:52 -04:00

900 lines
37 KiB
TypeScript

/**
* Flattening of the JSON Schema **composition** keywords that a tool's
* `inputSchema` may carry at its **root** — `allOf`, and a top-level `anyOf` /
* `oneOf` union — into the plain object schema a form renderer can build fields
* from.
*
* Both form builders — the web client's `SchemaForm` and the TUI's
* `schemaToForm` — enumerate the root schema's `properties` and nothing else.
* A schema that keeps its fields on composition branches therefore rendered
* **no controls at all**: not a branch picker, not even the raw-JSON fallback a
* union-typed *property* already gets, so the tool could only ever be called
* with empty arguments (#2123). The 2026-07-28 revision makes such a schema
* explicitly legal — `type: "object"` is required at the root, and "any JSON
* Schema 2020-12 keyword may appear alongside `type`, including composition
* keywords".
*
* Shared for the same reason {@link ./nullableUnion.ts} is: the two clients
* would otherwise grow separate answers to "which schemas can I render", and
* the CLI's argument coercion (`convertToolParameters`) needs the same view of
* where a property's schema lives.
*
* Deliberately **not** a JSON Schema evaluator. It rewrites nothing it cannot
* do faithfully: `not`, and branches that are not object schemas, are left
* alone rather than guessed at (see {@link resolveRootUnion}).
*/
/**
* The keywords this module reads. Both clients' own schema types are
* structurally assignable to this — the shape is the minimum needed to
* *recognize* root composition, not a full JSON Schema model.
*/
export interface RootUnionSchema {
type?: string | string[];
title?: string;
properties?: Record<string, unknown>;
required?: string[];
allOf?: readonly unknown[];
anyOf?: readonly unknown[];
oneOf?: readonly unknown[];
/**
* OpenAPI's discriminator, which real servers emit beside `oneOf` (the issue's
* own repro does). Read only to *label* a branch — never to validate.
*/
discriminator?: { propertyName?: string };
/**
* Read only to *decline*: `additionalProperties` constrains the names its
* **sibling** `properties` does not list, so a restrictive one at the root
* rejects every field a branch adds. See {@link resolveRootUnion}.
*/
additionalProperties?: unknown;
/**
* Read only to *decline* a member: its referent is not resolved here, so a
* `$ref` member's constraints are unknown rather than absent.
*/
$ref?: string;
}
/**
* What a resolved schema is: the caller's own type, intersected with the
* keywords this module may have *added* to it.
*
* The intersection is load-bearing rather than decorative. A schema that keeps
* every field on a branch declares no `properties` of its own, so returning the
* caller's `T` unchanged would hand back a type on which `properties` does not
* exist — precisely the property the flattening was performed to produce.
*/
export type ResolvedSchema<T extends RootUnionSchema> = T & RootUnionSchema;
/** One selectable alternative of a root union. */
export interface RootUnionBranch<T extends RootUnionSchema> {
/**
* The base schema merged with this branch: the object schema a renderer
* builds fields from while this alternative is selected.
*/
schema: ResolvedSchema<T>;
/** Human-readable name for the picker — see {@link branchLabel}. */
label: string;
/**
* The names **this branch itself declares** — including one the base also
* declares, since a branch commonly *specializes* a root property (root
* `count: {}`, branch `count: { type: "number" }`) and a renderer that showed
* only the base's version would render the untyped one.
*/
declaredFields: string[];
}
/** What {@link resolveRootUnion} decomposes a root schema into. */
export interface ResolvedRootUnion<T extends RootUnionSchema> {
/**
* The schema without its composition keywords: the root's own `properties` /
* `required` with every `allOf` branch merged in. Renderable on its own, and
* what a renderer uses when there is no union.
*/
base: ResolvedSchema<T>;
/**
* One entry per union alternative, or **empty** when the root carries no
* usable union — which is the overwhelmingly common case, so callers can
* treat a non-empty array as "this schema needs a branch picker".
*/
branches: RootUnionBranch<T>[];
}
/**
* A composition keyword's members, or `[]` when the value is not a list.
*
* These annotations describe the wire, and the wire is whatever a server sent:
* the web client narrows its schema with a cast and every member arrives as
* `unknown`, so `anyOf: {}` really can reach this module. Reading it as a list
* would throw and take all three clients down with it, which is a worse answer
* than declining to flatten a schema nobody can interpret.
*/
function membersOf(value: readonly unknown[] | undefined): readonly unknown[] {
return Array.isArray(value) ? value : [];
}
/** A schema's `required`, keeping only the string entries a list-shaped one holds. */
function requiredOf(schema: RootUnionSchema): string[] {
const { required } = schema;
return Array.isArray(required)
? required.filter((name): name is string => typeof name === "string")
: [];
}
/** Narrow a composition member to a readable object, or `null` if it isn't one. */
function toBranch(value: unknown): RootUnionSchema | null {
if (typeof value !== "object" || value === null || Array.isArray(value)) {
return null;
}
return value as RootUnionSchema;
}
/** Whether a schema's `type` permits an object instance. */
function admitsObject(schema: RootUnionSchema): boolean {
const { type } = schema;
if (type === undefined) return true;
return Array.isArray(type) ? type.includes("object") : type === "object";
}
/** Whether a schema's `properties` is a readable map rather than junk. */
function hasReadableProperties(schema: RootUnionSchema): boolean {
const { properties } = schema;
return (
typeof properties === "object" &&
properties !== null &&
!Array.isArray(properties)
);
}
/**
* A schema's `properties`, or an empty map when it has none — or when what it
* has is not a map at all, which a wire schema really can be. Total by design:
* every caller but {@link isOfferable} wants to enumerate whatever is there,
* and a nullable return would leave each of them carrying a `?? {}` that
* nothing can reach.
*/
function propertiesOf(schema: RootUnionSchema): Record<string, unknown> {
return hasReadableProperties(schema)
? (schema.properties as Record<string, unknown>)
: {};
}
/**
* Whether a branch is one a form can offer as an alternative.
*
* Four ways it is not, all of which would put an option in the picker that
* cannot be filled in:
*
* - **It carries no fields.** A `{ type: "null" }` member — the nullable
* encoding {@link ./nullableUnion.ts} owns — and a `$ref`-only or empty
* branch render nothing.
* - **`properties` is not an object.** Members arrive as `unknown`, so a
* malformed `properties: null` is reachable and would throw in `Object.keys`
* rather than being declined.
* - **Its `type` rules objects out.** Tool arguments are a JSON object, so a
* `{ type: "string", properties: {…} }` member can never match — rendering it
* as a fillable form would offer a call that cannot be valid.
* - **It requires a name it never declares.** `required` is a list of names,
* not of declarations, so `{ properties: { kind: … }, required: ["kind",
* "payload"] }` is legal and says nothing about what `payload` accepts. Both
* form builders enumerate `properties` alone, so no control is rendered for
* it and the submit-time check reports it missing *permanently* — the same
* dead end a `false`-schema required field produces (#2224).
*/
function isOfferable(
branch: RootUnionSchema,
merged: RootUnionSchema,
): boolean {
// The MEMBER decides whether the shape is readable at all…
if (branch.properties !== undefined && !hasReadableProperties(branch)) {
return false;
}
if (!admitsObject(branch)) return false;
// …and the MERGE decides whether there is anything to render. A member may
// legitimately declare no properties of its own and only add `required` over
// names the root already declares — `anyOf: [{ required: ["email"] }, …]` is
// a perfectly ordinary way to say "one of these two" — and judging it on its
// own properties would decline it, leaving the gate checking the base alone
// and accepting `{}`, which the schema rejects.
const mergedProperties = propertiesOf(merged);
// Judged on the MERGE for the same reason the fields are: a member may
// require a name the root declares, which is exactly the
// `anyOf: [{ required: ["email"] }, …]` shape above. `hasOwn` rather than
// `in`, since an argument legally named `constructor` or `toString` would
// otherwise resolve to the inherited one and read as declared.
if (
requiredOf(merged).some((name) => !Object.hasOwn(mergedProperties, name))
) {
return false;
}
const properties = Object.values(mergedProperties);
return (
properties.length > 0 &&
// Every value has to be something a renderer can read AND something a
// caller can satisfy. A `null` or an array is not a schema at all, and the
// web form dereferences one on the way to choosing a widget. JSON Schema's
// boolean form is legal, but only `true` is harmless — it constrains
// nothing and answers every keyword lookup with `undefined`, while `false`
// admits no value whatsoever, so a field declared with it can never be
// filled and a required one makes the whole branch unsatisfiable. Either
// way the branch is declined rather than offered as a callable shape.
properties.every(
(property) =>
property === true ||
(typeof property === "object" &&
property !== null &&
!Array.isArray(property)),
)
);
}
/**
* Keywords that annotate rather than constrain. Two declarations may disagree
* about these without describing different values, so a disagreement here is
* not a reason to refuse to flatten.
*/
const ANNOTATION_KEYWORDS = new Set([
"title",
"description",
"examples",
"deprecated",
"readOnly",
"writeOnly",
"$comment",
// An annotation too: a suggested initial value constrains nothing, so two
// declarations suggesting different ones still accept the same values.
"default",
]);
/**
* A JSON rendering whose object keys are sorted, so two values that differ only
* in the order their properties were written render identically.
*
* Member order carries no meaning in JSON, so `{ a: 1, b: 2 }` and
* `{ b: 2, a: 1 }` are the same value — a plain `JSON.stringify` comparison
* would call them different and, for a discriminator, would report two
* alternatives as mutually exclusive when both accept the same input.
*/
function canonicalJson(value: unknown): string {
if (Array.isArray(value)) {
return `[${value.map(canonicalJson).join(",")}]`;
}
if (typeof value === "object" && value !== null) {
const entries = Object.entries(value as Record<string, unknown>)
.sort(([a], [b]) => (a < b ? -1 : a > b ? 1 : 0))
.map(
([key, member]) => `${JSON.stringify(key)}:${canonicalJson(member)}`,
);
return `{${entries.join(",")}}`;
}
return JSON.stringify(value) ?? "undefined";
}
/**
* Structural equality, via canonical JSON — enough for schema keyword values.
*
* Exported because a caller comparing a *supplied* value against a schema's
* `const` has to reach the same answer this module does; two implementations
* would disagree the moment one of them met an object.
*/
export function sameJsonValue(a: unknown, b: unknown): boolean {
return sameValue(a, b);
}
function sameValue(a: unknown, b: unknown): boolean {
return a === b || canonicalJson(a) === canonicalJson(b);
}
/**
* Whether two declarations of one property name disagree about a constraint.
*
* Where a base and a branch both name a property, JSON Schema applies **both**
* — the value must satisfy the two together. A keyword only one side states is
* therefore safe to carry across, but a keyword they state *differently* is a
* conjunction this module cannot compute: root `minimum: 10` under branch
* `minimum: 0` is still 10, disjoint `enum`s leave nothing satisfiable at all,
* and `type: "string"` under `type: "number"` describes a value that cannot
* exist. Taking either side would render a form that accepts what the schema
* rejects, so the caller declines the composition instead.
*/
function conflicts(baseProperty: unknown, branchProperty: unknown): boolean {
const a = toBranch(baseProperty);
const b = toBranch(branchProperty);
if (a === null || b === null) {
// At least one side is not a readable schema object — JSON Schema's boolean
// form, or something malformed. Nothing can be merged keyword-wise, so the
// two agree only if they are the same declaration. (Only reached for a name
// the base declares, so `baseProperty` is never simply absent here.)
return !sameValue(baseProperty, branchProperty);
}
const left = a as Record<string, unknown>;
const right = b as Record<string, unknown>;
if (
Object.keys(right).some(
(keyword) =>
!ANNOTATION_KEYWORDS.has(keyword) &&
keyword in left &&
!sameValue(left[keyword], right[keyword]),
)
) {
return true;
}
// Keywords the two sides state *separately* can still contradict each other:
// root `{ type: "string" }` under branch `{ const: 1 }` shares no keyword at
// all, yet nothing satisfies both — and the merged declaration would seed an
// immutable `1` into a field the schema rejects.
return !constSatisfiesSiblings({ ...left, ...right });
}
/** The JSON type name of a value, in JSON Schema's vocabulary. */
function jsonTypeOf(value: unknown): string {
if (value === null) return "null";
if (Array.isArray(value)) return "array";
if (typeof value === "number") {
return Number.isInteger(value) ? "integer" : "number";
}
return typeof value;
}
/**
* Whether a merged declaration's `const` is one its own `type` and `enum` admit.
*
* `const` names the single value the schema accepts, so a sibling that excludes
* it leaves nothing satisfiable. An `integer` const satisfies a `number` type,
* which is the one direction JSON Schema widens.
*/
const CONST_CHECKABLE = new Set(["const", "type", "enum"]);
function constSatisfiesSiblings(schema: Record<string, unknown>): boolean {
if (!("const" in schema)) return true;
const value = schema.const;
const { type, enum: allowed } = schema;
// A `const` can be contradicted by any assertion, and only `type` and `enum`
// are evaluated here — `minimum: 10` beside `const: 1` is as unsatisfiable as
// a type mismatch. Rather than partially evaluate JSON Schema, a merged
// declaration pairing a `const` with an assertion this cannot check is
// declined: proving the conjunction safe is the requirement, not disproving
// it. Annotations are exempt, since they assert nothing.
if (
Object.keys(schema).some(
(keyword) =>
!CONST_CHECKABLE.has(keyword) && !ANNOTATION_KEYWORDS.has(keyword),
)
) {
return false;
}
const actual = jsonTypeOf(value);
const admits = (name: unknown) =>
name === actual || (name === "number" && actual === "integer");
if (typeof type === "string" && !admits(type)) return false;
if (Array.isArray(type) && !type.some(admits)) return false;
if (
Array.isArray(allowed) &&
!allowed.some((member) => sameValue(member, value))
) {
return false;
}
return true;
}
/**
* Merge two declarations of the same property name — a shallow union, which is
* the whole conjunction once {@link conflicts} has ruled out a keyword the two
* state differently.
*/
function mergeProperty(
baseProperty: unknown,
branchProperty: unknown,
): unknown {
const a = toBranch(baseProperty);
const b = toBranch(branchProperty);
if (a === null || b === null) {
return branchProperty;
}
return { ...a, ...b };
}
/**
* Whether a member can be folded into a base schema at all.
*
* Two ways it cannot, both of which would have the composition keyword
* *removed* while its constraint went unapplied — a form that submits fields
* the schema forbids:
*
* - **It is not an object schema.** JSON Schema's boolean form is legal, and
* `allOf: [false, …]` is unsatisfiable, so silently treating a non-object
* member as a no-op turns "nothing is valid here" into a fillable form.
* - **It is a `$ref`.** The referent is not resolved by this module, so its
* constraints are unknown rather than absent.
*/
const MERGEABLE_KEYWORDS = new Set(["type", "properties", "required"]);
function isFlattenable(member: unknown): boolean {
const branch = toBranch(member);
if (branch === null || !admitsObject(branch)) return false;
// `mergeBranch` applies `properties` and `required` and nothing else, so a
// member stating anything further would have that constraint erased along
// with the keyword — a nested `anyOf`, a `not`, an `additionalProperties`,
// a `$ref` whose referent is not resolved here. Only the keywords the merge
// actually carries, plus annotations that constrain nothing, are accepted.
return Object.keys(branch).every(
(keyword) =>
MERGEABLE_KEYWORDS.has(keyword) || ANNOTATION_KEYWORDS.has(keyword),
);
}
/** Whether any property declaration of `branch` conflicts with the base's. */
function conflictsWithBase(
base: RootUnionSchema,
branch: RootUnionSchema,
): boolean {
const baseProperties = propertiesOf(base);
const branchProperties = propertiesOf(branch);
return Object.entries(branchProperties).some(
([name, branchProperty]) =>
// `hasOwn`, not `in`: `properties` is a JSON record, so `constructor` and
// `toString` are legal argument names that `in` would find on
// `Object.prototype` and report as collisions the root never declared.
Object.hasOwn(baseProperties, name) &&
conflicts(baseProperties[name], branchProperty),
);
}
/**
* Whether some property discriminates the alternatives: declared by **every**
* member, pinned by each to a `const`, and pinned to a *different* one by each.
* That is what makes at most one alternative matchable, which is the constraint
* `oneOf` states and flattening cannot otherwise keep.
*
* When the schema names a `discriminator`, only that property is considered —
* the author has said which one carries the distinction.
*/
function hasDiscriminator(
members: RootUnionSchema[],
named: string | undefined,
rootRequired: string[],
): boolean {
const first = propertiesOf(members[0] ?? {});
const candidates = named !== undefined ? [named] : Object.keys(first);
return candidates.some((name) => {
// Required, or it discriminates nothing: two branches pinning an OPTIONAL
// `kind` to different constants both match `{}`, so arguments omitting it
// satisfy more than one alternative — exactly what `oneOf` forbids.
const constants = members.map((member) => {
if (!rootRequired.includes(name) && !requiredOf(member).includes(name)) {
return undefined;
}
const property = toBranch(propertiesOf(member)[name]) as {
const?: unknown;
} | null;
return property?.const;
});
if (constants.some((value) => value === undefined)) return false;
const seen = new Set(constants.map(canonicalJson));
return seen.size === constants.length;
});
}
/**
* Whether a schema's `additionalProperties` rejects names its own `properties`
* does not list.
*
* A schema that constrains nothing is the equivalent of `true`, and that is not
* only the empty object: `{ title: "Extra value" }` is annotation and no more.
* Treating either as restrictive would decline a legal permissive schema.
*/
function restrictsAdditional(schema: RootUnionSchema): boolean {
const additional = schema.additionalProperties;
return (
additional === false ||
(typeof additional === "object" &&
additional !== null &&
Object.keys(additional).some(
(keyword) => !ANNOTATION_KEYWORDS.has(keyword),
))
);
}
/**
* Whether folding a member into a base would make names the base forbids look
* allowed.
*
* `additionalProperties` constrains whatever its **sibling** `properties` does
* not name, so under a restrictive one the base rejects every field the member
* adds. Merging moves those fields beside the keyword, where they read as
* permitted — and a form built from that submits what the schema forbids.
*/
function addsForbiddenNames(
base: RootUnionSchema,
member: RootUnionSchema,
): boolean {
if (!restrictsAdditional(base)) return false;
const baseNames = propertiesOf(base);
return Object.keys(propertiesOf(member)).some(
(name) => !Object.hasOwn(baseNames, name),
);
}
/**
* Every property name the schema's composition members declare, whether or not
* the composition could be flattened.
*
* A caller deciding whether a tool takes arguments at all must count these: a
* union this module declines still *has* fields, and reporting "no fields"
* would auto-invoke the tool with `{}` rather than asking for them.
*/
export function declaresAnyFields(
schema: RootUnionSchema | undefined,
): boolean {
if (schema === undefined) return false;
if (Object.keys(propertiesOf(schema)).length > 0) return true;
// A schema may require a name it never declares — `{ required: ["token"] }`
// is a legal object schema, and the tool plainly takes an argument. Counting
// it here is what stops an App tool with that shape being auto-invoked with
// `{}` for want of a `properties` map.
if (requiredOf(schema).length > 0) return true;
// A `$ref`'s shape is unknown rather than empty, so it counts. Reporting "no
// fields" for `anyOf: [{ $ref: … }, { $ref: … }]` would auto-invoke an App
// tool with `{}` on the strength of something never read.
if (schema.$ref !== undefined) return true;
const members = [
...membersOf(schema.allOf),
...membersOf(schema.anyOf),
...membersOf(schema.oneOf),
];
return members.some((member) => {
const branch = toBranch(member);
return branch !== null && declaresAnyFields(branch);
});
}
/**
* Merge a composition branch's `properties` and `required` into a base schema.
*
* Both keywords are **conjunctive** where they meet: a value satisfying an
* `allOf` branch satisfies the base *and* the branch, and a value matching a
* union branch must satisfy the root's own constraints too. So properties union
* — a name both declare merged through {@link mergeProperty} rather than
* replaced — and `required` unions.
*/
function mergeBranch<T extends RootUnionSchema>(
base: T,
branch: RootUnionSchema,
): ResolvedSchema<T> {
const baseProperties = propertiesOf(base);
const branchProperties = propertiesOf(branch);
// Built through `fromEntries` rather than by assignment: a property named
// `__proto__` is a legal argument name, and assigning it would invoke the
// legacy prototype setter instead of creating an own property — losing the
// field entirely. `hasOwn` for the same reason `conflictsWithBase` uses it.
const properties: Record<string, unknown> = Object.fromEntries([
...Object.entries(baseProperties),
...Object.entries(branchProperties).map(([name, branchProperty]) => [
name,
Object.hasOwn(baseProperties, name)
? mergeProperty(baseProperties[name], branchProperty)
: branchProperty,
]),
]);
const baseRequired = requiredOf(base);
const required = [
...baseRequired,
...requiredOf(branch).filter((name) => !baseRequired.includes(name)),
];
// One cast, owned here: a branch member is `unknown` on the wire, so its
// property schemas are whatever the server sent however `T` declares them —
// exactly the situation `normalizeNullableUnion`'s hoist documents. Every
// consumer reads a property schema defensively, and the merged object is
// otherwise structurally `T`.
return {
...base,
...(Object.keys(properties).length > 0 ? { properties } : {}),
...(required.length > 0 ? { required } : {}),
} as ResolvedSchema<T>;
}
/** Strip the composition keywords a resolved schema has absorbed. */
function withoutComposition<T extends RootUnionSchema>(
schema: T,
): ResolvedSchema<T> {
const { allOf: _allOf, anyOf: _anyOf, oneOf: _oneOf, ...rest } = schema;
return rest as ResolvedSchema<T>;
}
/**
* A branch's display name, in decreasing order of how deliberate it is:
*
* 1. the branch's own `title` — the author naming it outright;
* 2. the `const` of the discriminator property, when the root names one;
* 3. the `const` of the branch's only constant-valued property, which is what a
* discriminated union looks like without an OpenAPI `discriminator` (the
* `kind: { const: "email" }` shape) — restricted to a *single* candidate, so
* a branch with several constants is not labelled by an arbitrary one;
* 4. a positional fallback.
*/
function branchLabel(
branch: RootUnionSchema,
index: number,
discriminatorProperty: string | undefined,
): string {
if (typeof branch.title === "string" && branch.title.trim() !== "") {
return branch.title;
}
const properties = propertiesOf(branch);
// Every primitive constant is a usable label, not just the string and number
// cases: `hasDiscriminator` accepts distinct booleans and nulls, so a
// `true`/`false` union would otherwise be labelled "Option 1"/"Option 2"
// while being discriminated perfectly well. An object or array constant is
// not a label — `undefined` marks "nothing usable here", which lets a `null`
// constant be a value rather than the sentinel.
const constOf = (name: string): string | undefined => {
const property = toBranch(properties[name]) as { const?: unknown } | null;
if (property === null || !("const" in property)) return undefined;
const value = property.const;
return value === null || typeof value !== "object"
? String(value)
: undefined;
};
if (discriminatorProperty !== undefined) {
const value = constOf(discriminatorProperty);
if (value !== undefined) return value;
}
const constants = Object.keys(properties)
.map((name) => constOf(name))
.filter((value): value is string => value !== undefined);
if (constants.length === 1) return constants[0];
return `Option ${index + 1}`;
}
/**
* Decompose a root schema into the object schema a form renders and, when the
* root is a union, the alternatives a picker offers.
*
* `allOf` is merged unconditionally — its branches are conjunctive, so there is
* one correct rendering and no choice to present. A `oneOf` / `anyOf` becomes
* `branches` only when **every** member is an object schema carrying fields:
* a union mixing renderable and unrenderable members would give a picker
* options that show nothing, and the whole point of this module is to stop
* producing a form that cannot express the call.
*
* A schema carrying **both** `oneOf` and `anyOf` is declined rather than
* half-read. The two are independent keywords a value must satisfy *together*,
* not two spellings of one union, so picking one and dropping the other builds
* a form that silently omits real constraints — worse than the empty form this
* module exists to replace, because it looks complete. Satisfying both honestly
* means offering the cross product of their alternatives, which no real schema
* has yet asked for and which produces a picker whose option labels are pairs;
* until something does, declining leaves the root `properties` rendering
* unchanged and claims nothing that is not true.
*/
export function resolveRootUnion<T extends RootUnionSchema>(
schema: T,
): ResolvedRootUnion<T> {
// `allOf` is only folded in when EVERY member can be. A member this module
// cannot flatten would otherwise have its keyword stripped by
// `withoutComposition` while its constraint went unapplied — so an
// unsatisfiable `allOf: [false, …]` would render as a fillable form, and a
// `$ref` member's constraints would read as absent rather than unknown. When
// one cannot, nothing is flattened: the schema's own `properties` render, its
// composition keywords stay on it, and no union is offered either, since a
// branch would otherwise be merged against a base whose constraints are not
// all known.
const allOfMembers = membersOf(schema.allOf);
let merged = schema as ResolvedSchema<T>;
for (const member of allOfMembers) {
const branch = toBranch(member);
// Each member is checked against what has been merged **so far**, not
// against the original root: two members declaring `x.minimum` as 10 and 0
// agree with a root that declares neither, while contradicting each other.
if (
branch === null ||
!isFlattenable(member) ||
conflictsWithBase(merged, branch) ||
addsForbiddenNames(merged, branch)
) {
return { base: schema as ResolvedSchema<T>, branches: [] };
}
merged = mergeBranch(merged, branch);
}
const base = withoutComposition(merged);
if (schema.oneOf !== undefined && schema.anyOf !== undefined) {
return { base, branches: [] };
}
const isExclusiveUnion = schema.oneOf !== undefined;
const members = membersOf(schema.oneOf ?? schema.anyOf);
const branches = members.map(toBranch);
if (
branches.length === 0 ||
branches.some(
(branch) =>
branch === null ||
!isOfferable(branch, mergeBranch(base, branch)) ||
// The same faithfulness test the `allOf` fold applies: a member
// carrying a constraint the merge does not copy — a nested `allOf`, a
// `not`, a `$ref` — would have it erased along with the union keyword,
// which can present an unsatisfiable branch as a callable one.
!isFlattenable(branch) ||
conflictsWithBase(base, branch),
)
) {
return { base, branches: [] };
}
// `additionalProperties` applies to whatever its **sibling** `properties`
// does not name, so a restrictive one at the root rejects every field the
// branches add — the original schema admits none of them. Flattening moves
// those fields *beside* the keyword, where they would read as allowed, so a
// form built from it would submit what the schema forbids.
if (
branches.some((branch) =>
addsForbiddenNames(base, branch as RootUnionSchema),
)
) {
return { base, branches: [] };
}
// `oneOf` demands that **exactly one** alternative match, which flattening
// cannot preserve: the merged branches are offered as if any of them would
// do. That is only safe when the alternatives are mutually exclusive by
// construction — a discriminator, i.e. some property every branch pins to a
// `const` of its own. Without one, two branches can accept the same
// arguments, and a call the form calls valid is one the server refuses.
if (
isExclusiveUnion &&
!hasDiscriminator(
branches as RootUnionSchema[],
schema.discriminator?.propertyName,
requiredOf(base),
)
) {
return { base, branches: [] };
}
const discriminatorProperty = schema.discriminator?.propertyName;
return {
base,
branches: branches
.filter((branch): branch is RootUnionSchema => branch !== null)
.map((branch, index) => ({
// `base` is already composition-free and `mergeBranch` copies only
// `properties`/`required` off the branch, so the merge stays that way.
schema: mergeBranch(base, branch),
label: branchLabel(branch, index, discriminatorProperty),
declaredFields: Object.keys(propertiesOf(branch)),
})),
};
}
/**
* The index of the branch a set of values already identifies, or `null` when
* they identify none uniquely.
*
* A discriminated union pins its discriminator with `const`, so values carrying
* one name the branch they belong to. Shared because more than one caller has
* to reach the same answer: the web form opens its picker on that branch, and
* the defaults seeded before the values are overlaid must belong to the same
* one, or the arguments carry a shape the picker is not showing.
*/
export function selectBranchIndex<T extends RootUnionSchema>(
branches: RootUnionBranch<T>[],
values: Record<string, unknown>,
): number | null {
const supplied = (name: string) =>
// `hasOwn`: a field legally named `constructor` would otherwise read the
// inherited one as a supplied value.
Object.hasOwn(values, name) && values[name] !== undefined;
// A branch is out of the running as soon as a supplied value disagrees with
// one of its constants; one whose constants agree is a candidate. A constant
// the caller did not supply is one this identification exists to *seed*, so
// it is not evidence either way — which is why a branch that pins nothing
// relevant stays a candidate rather than being ruled in or out.
const candidates: number[] = [];
const agreeing: number[] = [];
branches.forEach((branch, index) => {
const pinned = Object.entries(propertiesOf(branch.schema))
.map(
([name, schema]) =>
[
name,
(toBranch(schema) as { const?: unknown } | null)?.const,
] as const,
)
.filter(
([name, constValue]) => constValue !== undefined && supplied(name),
);
// Structural, not reference: a `const` may be an object or an array, and
// deep-link arguments arrive as freshly parsed instances that could never
// be `===` the schema's own.
const agrees = pinned.every(([name, constValue]) =>
sameValue(values[name], constValue),
);
if (!agrees) return;
candidates.push(index);
if (pinned.length > 0) agreeing.push(index);
});
// What the supplied NAMES say comes first: a matching constant does not
// identify a branch on its own while another candidate leaves that property
// unpinned — `{ kind: "email", phone: "555" }` agrees with an email branch
// whose `address` is missing while satisfying a phone branch outright, and
// the picker must show the one that could actually be called.
const narrowed = narrowBySuppliedNames(
branches,
candidates,
Object.keys(values).filter(supplied),
);
if (narrowed !== null) return narrowed;
// Nothing in the names settled it, so a lone agreeing constant is the last
// evidence left — a branch pinning `kind` to what was supplied says more
// than one that merely permits any value there.
return agreeing.length === 1 ? agreeing[0] : null;
}
/**
* Choose among candidate branches using only *which* argument names were
* supplied — first the branch whose own required fields they cover, then a name
* only one candidate declares.
*
* Split out because two callers need the same answer from different evidence:
* the form holds typed values, while the CLI holds strings it has not coerced
* yet, and a name is a name in both. A name more than one candidate declares is
* ambiguous and says nothing.
*/
export function narrowBySuppliedNames<T extends RootUnionSchema>(
branches: RootUnionBranch<T>[],
candidates: number[],
suppliedNames: string[],
): number | null {
if (candidates.length === 1) return candidates[0];
if (candidates.length === 0 || suppliedNames.length === 0) return null;
const supplied = new Set(suppliedNames);
const satisfied = candidates.filter((index) => {
const branch = branches[index]!;
const required = requiredOf(branch.schema);
const own = required.filter((name) => branch.declaredFields.includes(name));
return own.length > 0 && own.every((name) => supplied.has(name));
});
if (satisfied.length === 1) return satisfied[0];
const exclusiveTo = new Map<string, number>();
for (const index of candidates) {
for (const name of branches[index]!.declaredFields) {
exclusiveTo.set(name, exclusiveTo.has(name) ? -1 : index);
}
}
const named = new Set(
suppliedNames
.map((name) => exclusiveTo.get(name))
.filter((index): index is number => index !== undefined && index >= 0),
);
return named.size === 1 ? [...named][0] : null;
}
/**
* Whether a branch's own constants are compatible with the values in hand — the
* question "could this call be making this shape".
*
* A required-field check alone is not that question: in an email/SMS union,
* `{ kind: "sms", address: "x" }` supplies everything the *email* branch
* requires while carrying a discriminator that branch rejects, so treating it
* as satisfiable would enable a submit the server refuses.
*/
export function branchAcceptsValues<T extends RootUnionSchema>(
branch: RootUnionBranch<T>,
values: Record<string, unknown>,
): boolean {
return Object.entries(propertiesOf(branch.schema)).every(([name, schema]) => {
const constValue = (toBranch(schema) as { const?: unknown } | null)?.const;
if (constValue === undefined) return true;
if (!Object.hasOwn(values, name) || values[name] === undefined) {
return true;
}
return sameValue(values[name], constValue);
});
}