519ecf49ee
A floated promise is invisible at review time — the call reads like an awaited one minus four characters — and the unhandled rejection it produces surfaces in a different test, in a different file, as a stack pointing at SDK internals. In #1947 two un-held `callTool` calls made `npm run ci` unpassable and took a full investigation to attribute; the fix was two lines. `@typescript-eslint/no-floating-promises` catches the class outright, so enable it at `error` everywhere. The rule is type-aware and `tseslint.configs.recommended` is not, so each scope's config gains a parser project. The four clients name their own tsconfig projects (both of them — `src` and `__tests__`/`server` live in different ones). The root scope has no tsconfig at all, so add `tsconfig.lint.json`: a lint-only project covering `core/**`, `test-servers/src/**`, and `vitest.shared.mts`, emitting nothing and gating nothing. It sets `moduleResolution: bundler` deliberately — under NodeNext `core/`'s extensionless imports fail to resolve, every import degrades to `any`, and the rule silently stops seeing promises at all. Measured surface, and the fixes: - core (2) — `stream.close()` in two Hono `onAbort` listeners. Hono invokes subscribers with a bare `subscriber()`, so a promise returned from the listener is floated one layer up; `closeAbortedStream` owns the rejection where it can actually be owned. - tui (5) — `handleDisconnect` had no catch of its own and its only caller is a key handler that cannot await, so a failing disconnect was a live unhandled rejection; it now surfaces the message the way `handleConnect` does. The rest are `void` at callers that genuinely cannot await, over callees that already own their failures. - web (92) — 83 are Storybook `expect(...)`, which is instrumented and returns a promise, now awaited (`scrollAreaStoryAssertions` is async for the same reason). Two tests were asserting against a provider call they never awaited. `open(url)` in both web servers now warns instead of escaping a synchronous callback. - cli, launcher — already clean. Type-aware linting costs time: `clients/web`'s `eslint .` goes from ~8s to ~19s, inside `validate`. Narrowing the loaded projects is the lever if that needs reducing later; dropping the rule is not. Closes #1959 Signed-off-by: cliffhall <cliff@futurescale.com>
34 lines
1.3 KiB
JSON
34 lines
1.3 KiB
JSON
{
|
|
// Parser project for the ROOT eslint config's type-aware rules (#1959), and
|
|
// nothing else — it emits nothing and gates nothing.
|
|
//
|
|
// `@typescript-eslint/no-floating-promises` needs a program containing the
|
|
// file being linted, and the root scope (`core/**`, `test-servers/src/**`,
|
|
// `vitest.shared.mts`) has no tsconfig of its own: `core/` is typechecked
|
|
// through `clients/web`'s `tsc -b` and `test-servers/src` through
|
|
// `clients/cli`'s test project, neither of which is rooted here. Type
|
|
// *checking* stays where it is; this file only gives the parser a program.
|
|
//
|
|
// `moduleResolution: bundler` because `core/` is written for a bundler
|
|
// (extensionless relative imports) — under NodeNext those fail to resolve,
|
|
// every import degrades to `any`, and the rule silently stops seeing
|
|
// promises at all.
|
|
"extends": "./tsconfig.base.json",
|
|
"compilerOptions": {
|
|
"noEmit": true,
|
|
"module": "ESNext",
|
|
"moduleResolution": "bundler",
|
|
"lib": ["ES2023", "DOM", "DOM.Iterable"],
|
|
"jsx": "react-jsx",
|
|
"types": ["node"],
|
|
"typeRoots": ["./clients/web/node_modules/@types", "./node_modules/@types"]
|
|
},
|
|
"include": [
|
|
"core/**/*.ts",
|
|
"core/**/*.tsx",
|
|
"test-servers/src/**/*.ts",
|
|
"test-servers/src/**/*.mts",
|
|
"test-servers/src/**/*.cts",
|
|
"vitest.shared.mts"
|
|
]
|
|
}
|