inspector/clients/web/src/components/elements/KeyValueRows
Repository files (latest commit first)
Filename Latest commit message Latest commit date
cliffhall 51d35d864b fix(web): correct the OAuth header hint, keep utils off components (#1915)
Round-4 review follow-ups on #2038.

The Custom Headers hint claimed a custom `Authorization` value is "ignored"
once OAuth is configured. Verified against the installed
@modelcontextprotocol/client: both SSE and streamable-HTTP `_commonHeaders()`
set the bearer first and then spread `requestInit.headers`, so a custom
value *overrides* the OAuth token. The hint told users the opposite of what
would happen, and could have them silently break their own auth. Corrected in
both places — the modal's new hint and the pre-existing one in
ServerSettingsForm, which carried the same wrong claim.

`utils/serverSettingsPatch.ts` imported both its shared types from
components, reversing the one-way `components -> utils` direction AGENTS.md
sets. `KeyValuePair` moves to `utils/keyValuePairs.ts` (KeyValueRows
re-exports it), and the mode is spelled as a literal union — still checked,
since `ServerConfigModalMode` must stay assignable to it at the call site.

Signed-off-by: cliffhall <cliff@futurescale.com>
2026-08-16 22:14:40 -04:00
..
KeyValueRows.stories.tsx fix(web): only write settings on a real header edit; label rows by position (#1915) 2026-08-16 21:57:09 -04:00
KeyValueRows.test.tsx fix(web): only write settings on a real header edit; label rows by position (#1915) 2026-08-16 21:57:09 -04:00
KeyValueRows.tsx fix(web): correct the OAuth header hint, keep utils off components (#1915) 2026-08-16 22:14:40 -04:00