inspector/.claude/skills
Repository files (latest commit first)
Filename Latest commit message Latest commit date
cliffhall 5b80a5d834 fix: address Copilot review round 7
Two scanner bypasses and a wrong claim in the testing skill.

The call scan used `\b` before the binding name, and a word boundary succeeds
straight after a dot — so `other.configure({ asyncUtilTimeout: 1000 })` satisfied
the check while the imported binding was never called at all. A negative
lookbehind excludes a member access and any identifier the name is merely the
tail of; both shapes are now tested.

The retry scan required a colon, so JavaScript's shorthand property form
`it("x", { retry }, …)` — the same declaration with the value bound above — went
through. Both forms are recognized now, and `{ retryCount }` still does not
match.

The testing skill told developers the auto-settle "no-ops under fake timers".
It throws, deliberately, so a deadlock reports immediately instead of hanging
until the project's hookTimeout. Documenting it as a silent no-op is the more
dangerous direction to be wrong in: someone combining the two would expect
degraded cleanup and get a failed test. The skill now says which it is and why.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsmUAZ6aLUAFqenjJKSSRp
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-09-12 15:15:09 -04:00
..
board-ops docs: address Copilot review round 1 on #2203 2026-09-01 10:10:06 -04:00
issue-create docs: tune skill eval cases and document how to write them 2026-08-31 23:22:25 -04:00
issue-triage docs: tune skill eval cases and document how to write them 2026-08-31 23:22:25 -04:00
local-dev chore: address Copilot review round 3 (#2226) 2026-09-05 17:14:44 -04:00
pr-flow docs: paginate the review-comments fetch 2026-09-06 12:34:20 -04:00
pre-push-gate fix: state every test-gate timeout instead of inheriting a library default 2026-09-12 08:32:34 -04:00
project-structure docs: address Copilot review round 7 on #2203 2026-09-01 12:21:09 -04:00
release docs(release): make the two-PR flow, smoke, ledger and UI tag explicit (#2298) 2026-09-08 22:45:52 -04:00
test-servers chore: land the #2247 round-9 review findings on v2/main (#2322) 2026-09-11 08:22:16 -04:00
testing fix: address Copilot review round 7 2026-09-12 15:15:09 -04:00