cliffhall
5b80a5d834
fix: address Copilot review round 7 ...
Two scanner bypasses and a wrong claim in the testing skill.
The call scan used `\b` before the binding name, and a word boundary succeeds
straight after a dot — so `other.configure({ asyncUtilTimeout: 1000 })` satisfied
the check while the imported binding was never called at all. A negative
lookbehind excludes a member access and any identifier the name is merely the
tail of; both shapes are now tested.
The retry scan required a colon, so JavaScript's shorthand property form
`it("x", { retry }, …)` — the same declaration with the value bound above — went
through. Both forms are recognized now, and `{ retryCount }` still does not
match.
The testing skill told developers the auto-settle "no-ops under fake timers".
It throws, deliberately, so a deadlock reports immediately instead of hanging
until the project's hookTimeout. Documenting it as a silent no-op is the more
dangerous direction to be wrong in: someone combining the two would expect
degraded cleanup and get a failed test. The skill now says which it is and why.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsmUAZ6aLUAFqenjJKSSRp
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-09-12 15:15:09 -04:00
fix: address Copilot review round 4
2026-09-12 14:21:54 -04:00
chore(deps): address Copilot review round 15 on #2243
2026-09-04 09:26:20 -04:00
chore(deps): address Copilot review round 15 on #2243
2026-09-04 09:26:20 -04:00
chore(deps): address Copilot review round 1 on #2243
2026-09-04 09:06:32 -04:00
chore(deps): paginate the release list so the highest version is actual
2026-09-04 09:06:31 -04:00
feat: port CLI, TUI, and launcher from v1.5 into v2 ( #1452 )
2026-06-14 20:27:49 -04:00
fix(smoke): reject an empty SMOKE_BROWSER; test the installer's argument logic
2026-08-25 22:52:02 -04:00
fix(smoke): reject an empty SMOKE_BROWSER; test the installer's argument logic
2026-08-25 22:52:02 -04:00
ci: drop the Firefox smoke job; keep the engines as an on-demand tool
2026-08-25 23:55:19 -04:00
fix(smoke): route the Chromium tier through ENGINE_SMOKES too
2026-08-26 08:55:51 -04:00
Merge remote-tracking branch 'origin/v2/main' into v2/chore/2146-rename-local-gate
2026-08-27 00:16:14 -04:00
fix: address Copilot review round 5 on the SDK watch
2026-09-06 11:00:01 -04:00
fix: address Copilot review round 6, and close out the federation follow-up
2026-09-06 11:19:17 -04:00
chore: land the #2247 round-9 review findings on v2/main ( #2322 )
2026-09-11 08:22:16 -04:00
feat(skills): address Copilot review round 3 on #2204
2026-09-04 20:28:37 -04:00
chore(scripts): build test-servers unconditionally from one shared helper
2026-08-25 00:57:48 -04:00
refactor: self-validating clients, fast validate + separate coverage/smoke ( #1504 ) ( #1505 )
2026-06-21 11:41:33 -04:00
fix(scripts): make the test stubs drain, and the raw-mode guard testable ( #2147 )
2026-08-26 22:13:35 -04:00
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
fix: state every test-gate timeout instead of inheriting a library default
2026-09-12 08:32:34 -04:00
fix: state every test-gate timeout instead of inheriting a library default
2026-09-12 08:32:34 -04:00
fix: state every test-gate timeout instead of inheriting a library default
2026-09-12 08:32:34 -04:00
fix(smoke): await the server's exit before removing its catalog, and test it
2026-08-11 14:32:20 -04:00
chore(scripts): rename the local pre-push gate off ci, and guard it out of CI ( #2146 )
2026-08-26 23:56:34 -04:00
test(proxy): isolate proxy env per file; word the guard failure by candidate source
2026-08-23 23:00:28 -04:00
test(proxy): isolate proxy env per file; word the guard failure by candidate source
2026-08-23 23:00:28 -04:00
chore: address Copilot review round 1 ( #2226 )
2026-09-05 16:09:44 -04:00
chore: address Copilot review round 3 ( #2226 )
2026-09-05 17:14:44 -04:00
chore: address Copilot review round 1 ( #2226 )
2026-09-05 16:09:44 -04:00
chore: address Copilot review round 20
2026-08-29 05:32:12 -04:00
chore: address Copilot review round 9
2026-08-29 03:04:03 -04:00
chore: address Copilot review round 17
2026-08-29 04:54:04 -04:00
chore: address Copilot review round 16
2026-08-29 04:40:48 -04:00
feat(skills): measure a skill reached from another skill ( #2204 )
2026-09-04 19:07:26 -04:00
feat(skills): measure a skill reached from another skill ( #2204 )
2026-09-04 19:07:26 -04:00
fix: address Copilot review round 7
2026-09-12 15:15:09 -04:00
fix: address Copilot review round 7
2026-09-12 15:15:09 -04:00
Merge origin/v2/main: move the #1939 npx fix into the shared tsc-program lib
2026-08-16 17:07:50 -07:00
Merge origin/v2/main: move the #1939 npx fix into the shared tsc-program lib
2026-08-16 17:07:50 -07:00
chore(scripts): derive dep-lockstep candidates from what enters each tsc program
2026-08-16 12:17:15 -04:00
5b80a5d834