inspector/clients/web/src/hooks/useTabUiState.ts
cliffhall edac58e304 chore(web): address Copilot review on #2128
Seven of the eight comments, plus the three suppressed ones (the same
double-cast class):

- Narrow the toast hooks to `InspectorClientEventSource`, the client's
  typed event-listener surface. A bare `EventTarget` cannot satisfy it
  (its listener takes an `Event`, the typed one a `TypedEventGeneric`
  with `detail`), so both tests now construct a real
  `InspectorClientEventTarget` and dispatch through `dispatchTypedEvent`
  rather than casting a stand-in. That failed to compile immediately and
  caught two bad fixtures: `task()` was a `Pick<Task, "status">` where
  the event map wants a full `Task`, and `toolCallTaskUpdated` was
  dispatched with no `task` at all.
- Narrow `useExportActions`'s three store parameters to the single
  clearing method each handler calls, so the test doubles are
  structurally checked instead of cast away.
- Build real `MessageEntry` fixtures (`timestamp` is a `Date`, not `0`),
  removing four more double casts.
- Fix a tautological assertion in useTabUiState.test: it compared a
  callback to itself, so it held however the identity changed. Every
  callback is now captured before the update and compared to those
  references.
- Reword `resetTabUiState`'s doc: `exhaustive-deps` cannot infer
  stability across a hook boundary, so the dependency IS named — the
  stability buys no churn, not omission.
- Justify the one remaining double cast in place, per the type-safety
  rule.

`useProgressToasts` still returns `void` rather than an object,
deliberately: it has nothing to return, and `{}` would imply an API that
is not there. Noted on the PR as the one deviation from #2128's
"returns one object" criterion.

Signed-off-by: cliffhall <cliff@futurescale.com>
2026-08-26 19:58:02 -04:00

163 lines
5.2 KiB
TypeScript

import { useCallback, useMemo, useState } from "react";
import type { ConsoleUiState } from "../components/screens/ConsoleScreen/ConsoleScreen";
import {
EMPTY_APPS_UI,
EMPTY_CONSOLE_UI,
EMPTY_LOGS_UI,
EMPTY_NETWORK_UI,
EMPTY_PROMPTS_UI,
EMPTY_PROTOCOL_UI,
EMPTY_RESOURCES_UI,
EMPTY_TASKS_UI,
EMPTY_TOOLS_UI,
} from "../components/screens/screenUiState";
import type { LiftedTabUiState, TabUiSetters } from "../lib/oauthResume";
import { INSPECTOR_SERVERS_TAB } from "../utils/inspectorTabs";
/**
* The per-screen `ui` objects, keyed exactly as {@link LiftedTabUiState} keys
* them so the OAuth-resume snapshot can be built straight from this object.
* `consoleUi` is the one addition — the Console screen is not snapshotted
* across an OAuth redirect (its entries survive in `StderrLogState`), but its
* search filter is lifted here with the rest.
*/
export interface TabUiState extends LiftedTabUiState {
consoleUi: ConsoleUiState;
}
/** Matching setters, named as {@link TabUiSetters} names them. */
export interface TabUiStateSetters extends TabUiSetters {
setConsoleUi: (next: ConsoleUiState) => void;
}
export interface TabUiStateResult {
/** Every screen's lifted UI object. */
ui: TabUiState;
/** Stable per-screen setters. The object identity is stable too. */
setUi: TabUiStateSetters;
activeTab: string;
setActiveTab: (next: string) => void;
/** Protocol entries the user pinned, by entry id. */
pinnedProtocolIds: Set<string>;
setPinnedProtocolIds: (next: Set<string>) => void;
/** Pin/unpin one Protocol entry. */
togglePinProtocol: (id: string) => void;
/**
* Reset every screen's UI object and the pin set to their empty defaults.
* Its identity never changes, so naming it in the dependency array of the
* session-reset callback that drives it — which `exhaustive-deps` requires,
* since the rule cannot infer stability across a custom-hook boundary —
* costs that callback no churn. Deliberately leaves `activeTab` alone: the
* tab the user is on is shell state, reset separately on an *explicit*
* disconnect.
*/
resetTabUiState: () => void;
}
/**
* Per-screen selection / search / filter state, one object per screen.
*
* Lifted out of the individual screens because the screens unmount on tab
* switch, so screen-local state would be lost on plain navigation. It is
* cleared only on disconnect (via `resetTabUiState`) or an explicit user
* action (#1414/#1417).
*/
export function useTabUiState(): TabUiStateResult {
const [toolsUi, setToolsUi] = useState(EMPTY_TOOLS_UI);
const [promptsUi, setPromptsUi] = useState(EMPTY_PROMPTS_UI);
const [resourcesUi, setResourcesUi] = useState(EMPTY_RESOURCES_UI);
const [appsUi, setAppsUi] = useState(EMPTY_APPS_UI);
const [tasksUi, setTasksUi] = useState(EMPTY_TASKS_UI);
const [logsUi, setLogsUi] = useState(EMPTY_LOGS_UI);
const [protocolUi, setProtocolUi] = useState(EMPTY_PROTOCOL_UI);
const [networkUi, setNetworkUi] = useState(EMPTY_NETWORK_UI);
const [consoleUi, setConsoleUi] = useState(EMPTY_CONSOLE_UI);
// Session-scoped — the ids reference message-log entries, which clear on
// disconnect, so this resets with the rest of the per-screen state.
const [pinnedProtocolIds, setPinnedProtocolIds] = useState<Set<string>>(
() => new Set(),
);
const [activeTab, setActiveTab] = useState<string>(INSPECTOR_SERVERS_TAB);
const ui: TabUiState = useMemo(
() => ({
toolsUi,
promptsUi,
resourcesUi,
appsUi,
tasksUi,
logsUi,
protocolUi,
networkUi,
consoleUi,
}),
[
toolsUi,
promptsUi,
resourcesUi,
appsUi,
tasksUi,
logsUi,
protocolUi,
networkUi,
consoleUi,
],
);
// `useState` setters are stable, so this object is built once and its
// identity never changes — safe to pass straight into a memo dependency.
const setUi: TabUiStateSetters = useMemo(
() => ({
setToolsUi,
setPromptsUi,
setResourcesUi,
setAppsUi,
setTasksUi,
setLogsUi,
setProtocolUi,
setNetworkUi,
setConsoleUi,
}),
[],
);
// ProtocolListPanel sorts pinned entries to the top.
const togglePinProtocol = useCallback((id: string) => {
setPinnedProtocolIds((prev) => {
const next = new Set(prev);
if (next.has(id)) {
next.delete(id);
} else {
next.add(id);
}
return next;
});
}, []);
const resetTabUiState = useCallback(() => {
setToolsUi(EMPTY_TOOLS_UI);
setPromptsUi(EMPTY_PROMPTS_UI);
setResourcesUi(EMPTY_RESOURCES_UI);
setAppsUi(EMPTY_APPS_UI);
setTasksUi(EMPTY_TASKS_UI);
setLogsUi(EMPTY_LOGS_UI);
setProtocolUi(EMPTY_PROTOCOL_UI);
setPinnedProtocolIds(new Set());
setNetworkUi(EMPTY_NETWORK_UI);
// Only the search filter resets here; the stderr entries themselves live in
// StderrLogState, which deliberately survives connect/disconnect so a failed
// launch's output stays visible for diagnosis (#1621).
setConsoleUi(EMPTY_CONSOLE_UI);
}, []);
return {
ui,
setUi,
activeTab,
setActiveTab,
pinnedProtocolIds,
setPinnedProtocolIds,
togglePinProtocol,
resetTabUiState,
};
}