519ecf49ee
A floated promise is invisible at review time — the call reads like an awaited one minus four characters — and the unhandled rejection it produces surfaces in a different test, in a different file, as a stack pointing at SDK internals. In #1947 two un-held `callTool` calls made `npm run ci` unpassable and took a full investigation to attribute; the fix was two lines. `@typescript-eslint/no-floating-promises` catches the class outright, so enable it at `error` everywhere. The rule is type-aware and `tseslint.configs.recommended` is not, so each scope's config gains a parser project. The four clients name their own tsconfig projects (both of them — `src` and `__tests__`/`server` live in different ones). The root scope has no tsconfig at all, so add `tsconfig.lint.json`: a lint-only project covering `core/**`, `test-servers/src/**`, and `vitest.shared.mts`, emitting nothing and gating nothing. It sets `moduleResolution: bundler` deliberately — under NodeNext `core/`'s extensionless imports fail to resolve, every import degrades to `any`, and the rule silently stops seeing promises at all. Measured surface, and the fixes: - core (2) — `stream.close()` in two Hono `onAbort` listeners. Hono invokes subscribers with a bare `subscriber()`, so a promise returned from the listener is floated one layer up; `closeAbortedStream` owns the rejection where it can actually be owned. - tui (5) — `handleDisconnect` had no catch of its own and its only caller is a key handler that cannot await, so a failing disconnect was a live unhandled rejection; it now surfaces the message the way `handleConnect` does. The rest are `void` at callers that genuinely cannot await, over callees that already own their failures. - web (92) — 83 are Storybook `expect(...)`, which is instrumented and returns a promise, now awaited (`scrollAreaStoryAssertions` is async for the same reason). Two tests were asserting against a provider call they never awaited. `open(url)` in both web servers now warns instead of escaping a synchronous callback. - cli, launcher — already clean. Type-aware linting costs time: `clients/web`'s `eslint .` goes from ~8s to ~19s, inside `validate`. Narrowing the loaded projects is the lever if that needs reducing later; dropping the rule is not. Closes #1959 Signed-off-by: cliffhall <cliff@futurescale.com>
29 lines
1.3 KiB
TypeScript
29 lines
1.3 KiB
TypeScript
import { expect } from "storybook/test";
|
|
|
|
/**
|
|
* Assert a list `ScrollArea.Autosize` reserves a scrollbar gutter
|
|
* (`offsetScrollbars`, so the bar never overlays the cards) and keeps the bar
|
|
* hidden when idle (`type="scroll"`, so it shows only while scrolling rather
|
|
* than on hover). Shared by the Protocol/Network/Logging panel stories (#1474).
|
|
*/
|
|
export async function expectScrollbarGutterIdleHidden(
|
|
canvasElement: HTMLElement,
|
|
) {
|
|
const viewport = canvasElement.querySelector(".mantine-ScrollArea-viewport");
|
|
if (!(viewport instanceof HTMLElement)) {
|
|
throw new Error("scroll viewport not found");
|
|
}
|
|
// offsetScrollbars reserves a non-zero inline-end gutter for the scrollbar.
|
|
const pad = parseFloat(getComputedStyle(viewport).paddingInlineEnd);
|
|
await expect(pad).toBeGreaterThan(0);
|
|
// type="scroll" → scrollbars are mounted but hidden until the user scrolls.
|
|
// Assert at least one exists first so the loop isn't trivially-true if a
|
|
// future change stops rendering the scrollbar element.
|
|
const scrollbars = canvasElement.querySelectorAll(
|
|
".mantine-ScrollArea-scrollbar",
|
|
);
|
|
await expect(scrollbars.length).toBeGreaterThan(0);
|
|
for (const bar of scrollbars) {
|
|
await expect(bar.getAttribute("data-state")).toBe("hidden");
|
|
}
|
|
}
|