69e6097b68
Round 8 of the review asked for an AST. That was the right diagnosis of the
wrong problem: the question was never which parser to use, it was why a
test-timeout guard was parsing JavaScript at all.
It got there one reasonable step at a time. The guard enforces two rules no
Vitest config can report — a per-test `retry`, and Testing Library's
`asyncUtilTimeout` — so it read them out of source text, and the review found a
new valid spelling it missed in five consecutive rounds: a trailing comment,
nested parens in `it.each([makeCase()])`, a member-access prefix, the shorthand
`{ retry }`, an aliased import, a non-literal title. Each fix was correct and
each made it more parser-shaped, until it carried eight helpers doing quote
tracking and bracket balancing.
Both rules are observable at runtime, exactly:
- `vitest.setup.shared.mts` is loaded by all six projects and reads
`ctx.task.retry` — the value Vitest resolved for the test. That covers
strictly more than the scan did: a per-test option, a `describe` option
inherited by children, a project-level setting, and a `--retry` flag typed at
a command line, which the scan could never see since it only read npm scripts.
- `clients/web/src/test/asyncUtilTimeout.test.ts` asserts
`getConfig().asyncUtilTimeout`, the value this project's own waitFors read.
Neither has a spelling to anticipate, so neither can be outrun by a new one.
Both were observed firing before being trusted.
The guard keeps only what it can answer by asking Vitest: resolved budgets,
project-level retry, config discovery, and that each project still loads the
setup file — the one thing about the runtime assertion a config CAN report.
868 lines to 361, every scanner helper gone, and 33 of 48 unit tests deleted
because they pinned edge cases of a thing that no longer exists.
storybookSetup.ts goes with it. At the library's own value its configure() call
was a no-op, and the assertion is what pins the number.
AGENTS.md gains the general rule: a rule about what the code DOES is asserted at
runtime, not read out of the source — reach for a verify:* guard when the
question is about configuration, which a tool can be asked to resolve.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsmUAZ6aLUAFqenjJKSSRp
Signed-off-by: cliffhall <cliff@futurescale.com>
51 lines
1.8 KiB
TypeScript
51 lines
1.8 KiB
TypeScript
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { defineConfig } from "vitest/config";
|
|
import {
|
|
NO_RETRY_SETUP,
|
|
TIMEOUTS,
|
|
vitestSharedPaths,
|
|
} from "../../vitest.shared.mts";
|
|
|
|
const dirname = path.dirname(fileURLToPath(import.meta.url));
|
|
const { projectResolve } = vitestSharedPaths(dirname);
|
|
|
|
export default defineConfig({
|
|
resolve: projectResolve,
|
|
test: {
|
|
globals: false,
|
|
environment: "node",
|
|
include: ["__tests__/**/*.test.ts"],
|
|
setupFiles: ["__tests__/helpers/mock-open-url.ts", NO_RETRY_SETUP],
|
|
// Shared budgets (#2323). `testTimeout` was already 15000 here by hand;
|
|
// the hook and teardown budgets were Vitest's defaults until now.
|
|
...TIMEOUTS,
|
|
// The in-process runner (__tests__/helpers/cli-runner.ts) patches
|
|
// process.std{out,err}.write to capture CLI output. Test files run in
|
|
// separate forked processes (and tests within a file run sequentially), so
|
|
// those global patches never overlap. `forks` is vitest's default, but pin
|
|
// it explicitly so the capture isolation can't regress to a shared-thread
|
|
// pool. See #1484.
|
|
pool: "forks",
|
|
coverage: {
|
|
provider: "v8",
|
|
reporter: ["text", "html", "json-summary"],
|
|
include: ["src/**/*.ts"],
|
|
exclude: [
|
|
// Binary bootstrap: shebang + `isMain` guard + `runCli()`/`process.exit`
|
|
// wiring that only runs when launched as the real binary. Exercised by
|
|
// the out-of-process layer (__tests__/e2e.test.ts + scripts/smoke-cli.mjs),
|
|
// which spawns build/index.js and so can't be measured under in-process
|
|
// coverage. Mirrors web's `**/index.{ts,tsx}` exclusion.
|
|
"src/index.ts",
|
|
],
|
|
thresholds: {
|
|
perFile: true,
|
|
lines: 90,
|
|
statements: 90,
|
|
functions: 90,
|
|
branches: 90,
|
|
},
|
|
},
|
|
},
|
|
});
|