d830213796
Copilot round 2 (PR #2039) surfaced no new visible comments but six suppressed ones. Four were actionable. `clients/tui/src/App.tsx` — a stale-completion race in the new banner: start disconnecting server A, switch to B, then let A's disconnect reject, and A's failure appears under B. Rapid same-server retries had the same shape, and the stale attempt is the one most likely to reject. Claim a monotonic attempt token before awaiting and publish only if it is still current and the server has not changed; `handleConnect` bumps the same counter so a connect retires an in-flight disconnect. The rejection is still owned when superseded — just not published. The regression test drives a deferred rejection across a server switch, and fails without the guard. `tsconfig.lint.json` — the root type-aware block matches `test-servers/src/**/*.tsx` but the parser project omitted that extension, so such a file would have failed with "not found in any of the provided project(s)" instead of being linted. Added, and AGENTS.md now states the invariant: the include must stay a superset of the lint globs. `clients/web/server/{server,vite-hono-plugin}.ts` — the `open()` rejection branch was untested, and duplicated. Both were fixed by removing the duplication: `openBrowser` now lives beside `printServerBanner` in `web-server-config.ts`, with one implementation to test. Two copies of a one-line `.catch` is two chances for one to drift back to a bare `open(url)`. The dev plugin is not booted in tests — it returns early under VITEST by design — but it calls the same tested helper. `core/mcp/remote/node/server.ts` — `closeAbortedStream`'s rejecting-close path, the entire reason the helper exists, had no test. Exported it (as this file already does for `requestIdForSendWait` / `mcpParamHeadersOnly`) and covered both legs, asserting no unhandledRejection fires. Also corrects AGENTS.md, which said each client lists "both" tsconfig projects — true for cli/tui/launcher, but web lists four leaf projects. Signed-off-by: cliffhall <cliff@futurescale.com>
35 lines
1.4 KiB
JSON
35 lines
1.4 KiB
JSON
{
|
|
// Parser project for the ROOT eslint config's type-aware rules (#1959), and
|
|
// nothing else — it emits nothing and gates nothing.
|
|
//
|
|
// `@typescript-eslint/no-floating-promises` needs a program containing the
|
|
// file being linted, and the root scope (`core/**`, `test-servers/src/**`,
|
|
// `vitest.shared.mts`) has no tsconfig of its own: `core/` is typechecked
|
|
// through `clients/web`'s `tsc -b` and `test-servers/src` through
|
|
// `clients/cli`'s test project, neither of which is rooted here. Type
|
|
// *checking* stays where it is; this file only gives the parser a program.
|
|
//
|
|
// `moduleResolution: bundler` because `core/` is written for a bundler
|
|
// (extensionless relative imports) — under NodeNext those fail to resolve,
|
|
// every import degrades to `any`, and the rule silently stops seeing
|
|
// promises at all.
|
|
"extends": "./tsconfig.base.json",
|
|
"compilerOptions": {
|
|
"noEmit": true,
|
|
"module": "ESNext",
|
|
"moduleResolution": "bundler",
|
|
"lib": ["ES2023", "DOM", "DOM.Iterable"],
|
|
"jsx": "react-jsx",
|
|
"types": ["node"],
|
|
"typeRoots": ["./clients/web/node_modules/@types", "./node_modules/@types"]
|
|
},
|
|
"include": [
|
|
"core/**/*.ts",
|
|
"core/**/*.tsx",
|
|
"test-servers/src/**/*.ts",
|
|
"test-servers/src/**/*.tsx",
|
|
"test-servers/src/**/*.mts",
|
|
"test-servers/src/**/*.cts",
|
|
"vitest.shared.mts"
|
|
]
|
|
}
|